[REVIEW] 16114 ksh should not be isaexec'd

[REVIEW] 16114 ksh should not be isaexec'd

[Richard Lowe]

https://code.illumos.org/c/illumos-gate/+/3184

Like the others.  No difference to the binaries, just where they're placed.

I mentioned this in the bug and the review, but please note that all
I've done is remove the use of isaexec where it will give a constant
result.  I have not made anything explicitly 32bit become 64bit.
Perhaps someone who knows the history here, or uses ksh more often,
could come along and do that as a follow up, but I don't feel like I'm
qualified to.

-- Rich

Re: [REVIEW] 16114 ksh should not be isaexec'd

[Richard Lowe]

Ping, now the holidays are largely over.


-- Rich

Ar Sul, 17 Rhag 2023 am 14:28 Richard Lowe <richlowe@richlowe.net> ysgrifennodd:
>
> https://code.illumos.org/c/illumos-gate/+/3184
>
> Like the others.  No difference to the binaries, just where they're placed.
>
> I mentioned this in the bug and the review, but please note that all
> I've done is remove the use of isaexec where it will give a constant
> result.  I have not made anything explicitly 32bit become 64bit.
> Perhaps someone who knows the history here, or uses ksh more often,
> could come along and do that as a follow up, but I don't feel like I'm
> qualified to.
>
> -- Rich

Re: [developer] Re: [REVIEW] 16114 ksh should not be isaexec'd

[Peter Tribble]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

> > I mentioned this in the bug and the review, but please note that all
> > I've done is remove the use of isaexec where it will give a constant
> > result.  I have not made anything explicitly 32bit become 64bit.
> > Perhaps someone who knows the history here, or uses ksh more often,
> > could come along and do that as a follow up, but I don't feel like I'm
> > qualified to.
>

So I think the reason (or part of *a* reason, at least) why we have this
explicit
32-bit ksh referenced as /bin.sh and /sbin/sh was to do with the way the
OpenSolaris live ISO image was built - the root archive doesn't have /usr
on it, that is mounted later via lofi, but you need a working /bin/sh to get
there. Which is achieved by placing a copy of ksh (and a bunch of other
files)
into a thin /usr on the root archive that later gets overlaid. When 32-bit
was
supported, it made sense to only drop the 32-bit ksh in there and point to
it
directly.

It would be perfectly fine to have /bin/sh and /sbin/sh point to a 64-bit
ksh,
but any distro still using the old Live CD layout (ie OpenIndiana) would
need
to update the ISO build process to copy across the right file(s).

That's my understanding of why it's that way, at any rate.

-- 
-Peter Tribble
http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/

[-- Attachment #2: Type: text/html, Size: 2025 bytes --]