Re: [developer] Review - 15665 svc:/network/loopback exits successfully even if it fails

[Peter Tribble <peter.tribble@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Fri, Jul 26, 2024 at 9:21 AM Andy Fiddaman <illumos@fiddaman.net> wrote:

> Please can you review the following change?
>
>     15665 svc:/network/loopback exits successfully even if it fails
>     https://www.illumos.org/issues/15665
>     https://code.illumos.org/c/illumos-gate/+/3610
>

When this first came up I expressed my belief that making this change is
the wrong
thing to do, and I'll express it again.

If this service fails, I think the best thing to do is drive on so that the
system can come
up as far as possible to maximise the chance that the system comes up far
enough for
an administrator to be able to get in and fix it. Not putting the service
into maintenance
is a feature, not a bug.

(If it fails, then there's something deeper wrong with the system, and
those fundamental
causes should be dealt with.)

I think generally it would be wrong for a single voice to veto any change,
which means I
would generally be uncomfortable sticking a -1 on it, but if this does get
into the gate
it will be reverted in Tribblix.

Regards,

-- 
-Peter Tribble
http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/

[-- Attachment #2: Type: text/html, Size: 2168 bytes --]