From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 5693F1E1834D for ; Fri, 26 Jul 2024 08:44:28 -0400 (EDT) (envelope-from peter.tribble@gmail.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id F2FEF4DE642; Fri, 26 Jul 2024 08:44:28 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1721997868; b=bu9X0nT6epm9hjGChnhbDXBhSP/rHBIU+dnl3h8v/CoSWYMNh+ LyENREsmWVoJWbr7zyniI9exdNqqjLapCnHAAQ5tzdTloZNkPac7Z5LI360CV05K 2tTTnhpsWzJ3m1xpnYIKzTu8Qd17cx6EDH8RcAz4SkZQiQu6VvLfADDg1SEuIyw2 D7mu3Lj1+xhliJ7ddrPpPIT/fV4KUAQNeB9hK65MoX9BbbEJ4JkbVYBP283UNq4k 9nTKOEKNl77p21521SmNAYWEKMKCSF8y8w8CPJeCF6Q8WKOjobwoOeSM+Ro6zGVn GY9yeM+7tmH/SFetEWmAFLjzTW0BatCqU4gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=mime-version:references:in-reply-to:from:date :message-id:subject:to:content-type; s=arcseal; t=1721997868; bh=m+AC3tSUNezFWWbBew1gwsXQPe8Mx3iW7T/g90P/DVs=; b=xhI8CTUp6nNE g3C7wfpla0pWSi/T7zU0aXg64624MMD7ATAyLmNcCYC85dFptgR9/zdcLVY1Ztzd mEGMJyjjFHRFCn6W+GRFyTtUsqpvN8yuWSGERspj+4iEXHQkMtc+HR1zcn+1wJ05 GCMmTBlYCSwtqo4mYZkttvQkp7ZUO11JukRl0XfCfftOl1Z/bnED46eaJvylEgdI nL2dOqjlCFlfsK3WFbOV6jiIBS5C5HhyQ2Bp7ubP+vwCbW+xZ+lBYFX+yA/6T4ya QPNDIei/C+dCInol5LGMve6koMBJXoLdbuCt3ZP3FhOC9QZJZYY9Jt9fYtJ34UDU R8fScttkKw== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=hlbrunay header.a=rsa-sha256 header.s=20230601 x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=none,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=gmail.com; iprev=pass smtp.remote-ip=209.85.167.178 (mail-oi1-f178.google.com); spf=pass smtp.mailfrom=peter.tribble@gmail.com smtp.helo=mail-oi1-f178.google.com; x-aligned-from=pass (Address match); x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LwYqzHCQ; x-me-sender=none; x-ptr=pass smtp.helo=mail-oi1-f178.google.com policy.ptr=mail-oi1-f178.google.com; x-return-mx=pass header.domain=gmail.com policy.is_org=yes (MX Records found: alt4.gmail-smtp-in.l.google.com,gmail-smtp-in.l.google.com,alt2.gmail-smtp-in.l.google.com,alt1.gmail-smtp-in.l.google.com,alt3.gmail-smtp-in.l.google.com); x-return-mx=pass smtp.domain=gmail.com policy.is_org=yes (MX Records found: alt4.gmail-smtp-in.l.google.com,gmail-smtp-in.l.google.com,alt2.gmail-smtp-in.l.google.com,alt1.gmail-smtp-in.l.google.com,alt3.gmail-smtp-in.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-51 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=hlbrunay header.a=rsa-sha256 header.s=20230601 x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=none,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=gmail.com; iprev=pass smtp.remote-ip=209.85.167.178 (mail-oi1-f178.google.com); spf=pass smtp.mailfrom=peter.tribble@gmail.com smtp.helo=mail-oi1-f178.google.com; x-aligned-from=pass (Address match); x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LwYqzHCQ; x-me-sender=none; x-ptr=pass smtp.helo=mail-oi1-f178.google.com policy.ptr=mail-oi1-f178.google.com; x-return-mx=pass header.domain=gmail.com policy.is_org=yes (MX Records found: alt4.gmail-smtp-in.l.google.com,gmail-smtp-in.l.google.com,alt2.gmail-smtp-in.l.google.com,alt1.gmail-smtp-in.l.google.com,alt3.gmail-smtp-in.l.google.com); x-return-mx=pass smtp.domain=gmail.com policy.is_org=yes (MX Records found: alt4.gmail-smtp-in.l.google.com,gmail-smtp-in.l.google.com,alt2.gmail-smtp-in.l.google.com,alt1.gmail-smtp-in.l.google.com,alt3.gmail-smtp-in.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-51 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrieehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughrpegg fhgjhfffkffuvfgtsegrtderredttdejnecuhfhrohhmpefrvghtvghrucfvrhhisggslh gvuceophgvthgvrhdrthhrihgssghlvgesghhmrghilhdrtghomheqnecuggftrfgrthht vghrnhepteduheevfeejheeuheelfeeliefffeevfeejhfeitefffedvkeeiveeugedtud elnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgpdhpvghtvghrthhrihgssghlvgdr tghordhukhdpsghlohhgshhpohhtrdgtohhmnecukfhppedvtdelrdekhedrudeijedrud ejkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvtdelrdek hedrudeijedrudejkedphhgvlhhopehmrghilhdqohhiuddqfhdujeekrdhgohhoghhlvg drtghomhdpmhgrihhlfhhrohhmpeeophgvthgvrhdrthhrihgssghlvgesghhmrghilhdr tghomheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepoeguvghvvghlohhpvghrse hlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -51 X-ME-VSCategory: clean Received-SPF: pass (gmail.com ... _spf.google.com: Sender is authorized to use 'peter.tribble@gmail.com' in 'mfrom' identity (mechanism 'include:_netblocks.google.com' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="peter.tribble@gmail.com"; helo=mail-oi1-f178.google.com; client-ip=209.85.167.178 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Fri, 26 Jul 2024 08:44:27 -0400 (EDT) (envelope-from peter.tribble@gmail.com) Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3db12a2f530so555191b6e.1 for ; Fri, 26 Jul 2024 05:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721997867; x=1722602667; darn=lists.illumos.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=m+AC3tSUNezFWWbBew1gwsXQPe8Mx3iW7T/g90P/DVs=; b=hlbrunay1AumLck+kXRIQJhSlrKT75N1AdDWNAz95t36ke0bfQC+fTGEcB+3D4cQIN 5bMPVMbuZ7T1/AJjocz9dH6cQ4VYxMeh8wVvm1AAp8AJrIaa0g/bWMeq/9PmQjula1n5 X4zICbntpWSEkW1BEnG6D1UpGI0PlYJUHDQqI9M64zzmpWMiI2AqLnO4mPBSugOJ7YBk n9qlzq+1IMvHQtrFyJYEQvPtD3C+Fr4qa/h7U0Bc98+d/OXe6NTIfLwStw+3rxwj4toN B5FUo1c3qLFlcEqHb1UjQSf2Tp6dIL14t06GNxaM6gLy1Vsimw2Md9Cc+p198G2h6IEq bxHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721997867; x=1722602667; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m+AC3tSUNezFWWbBew1gwsXQPe8Mx3iW7T/g90P/DVs=; b=LwYqzHCQaVdb+m+jtgKOYx2rkfqIrozCoFXndtb71qsLFZCKEAHCMP4uaLMvXT0G+w mDpWoX2dGeo88nmtren3VZGelYgW5/8RkNuZrnFPMHKtUo5TrzkGM4I7OfbbYpngVnhF nMtlvBVicc0XOjMJlbDTDeO3v82Y6Jf/gKKgJWfzRmySmM5m95cZ+irAw96HHQabIful xgU4yV6znG+y2WzUi2ZmJ/uPuZ/KgU2pdlFvASjoedp85WIEwI5E9yNDwVtMQR9olsMe YMiVQfaHWgW1b6N6awLXrBF99V9RAjigfmGh8L0LP6vx8jkf8mOXSbbVxSCGcsQN2QFn nv7g== X-Gm-Message-State: AOJu0YyX9UQeLhEioUfmGWZIFED7Fqfzu7DyDAOXg80cUWol67GKJi/h Xn56uk3dvfGw09vYFdJD3IAJTgbX5OI9CGp0B+ZYA0PEq/PPUUweyBEa4XjIBZLpIx+8Sf86l+c pBB16H1cefn+bFOIoXpA9jvirZD65b7Y= X-Google-Smtp-Source: AGHT+IGN2dIrSODdp7kUsErahGmC7y/FgYWvj/isCmbRcIaGTZJEYJxKWKioufPVjjrXTvNl/IrQoIxrzKB/qs/HX+s= X-Received: by 2002:a05:6808:10c5:b0:3db:2025:122 with SMTP id 5614622812f47-3db20250edfmr535818b6e.36.1721997866812; Fri, 26 Jul 2024 05:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20240726082032.GA10040@reaper.citrus-it.net> In-Reply-To: <20240726082032.GA10040@reaper.citrus-it.net> From: Peter Tribble Date: Fri, 26 Jul 2024 13:44:15 +0100 Message-ID: Subject: Re: [developer] Review - 15665 svc:/network/loopback exits successfully even if it fails To: illumos-developer Content-Type: multipart/alternative; boundary="00000000000027cdc0061e25df09" Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: ce8a2b02-4b4c-11ef-9149-e983bce29379 --00000000000027cdc0061e25df09 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 26, 2024 at 9:21=E2=80=AFAM Andy Fiddaman wrote: > Please can you review the following change? > > 15665 svc:/network/loopback exits successfully even if it fails > https://www.illumos.org/issues/15665 > https://code.illumos.org/c/illumos-gate/+/3610 > When this first came up I expressed my belief that making this change is the wrong thing to do, and I'll express it again. If this service fails, I think the best thing to do is drive on so that the system can come up as far as possible to maximise the chance that the system comes up far enough for an administrator to be able to get in and fix it. Not putting the service into maintenance is a feature, not a bug. (If it fails, then there's something deeper wrong with the system, and those fundamental causes should be dealt with.) I think generally it would be wrong for a single voice to veto any change, which means I would generally be uncomfortable sticking a -1 on it, but if this does get into the gate it will be reverted in Tribblix. Regards, --=20 -Peter Tribble http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/ --00000000000027cdc0061e25df09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jul 26, 2024 at 9:21=E2=80=AFAM Andy Fiddaman &l= t;illumos@fiddaman.net> wrot= e:
Please can you review the following change?

=C2=A0 =C2=A0 15665 svc:/network/loopback exits successfully even if it fai= ls
=C2=A0 =C2=A0 https://www.illumos.org/issues/15665
=C2=A0 =C2=A0 https://code.illumos.org/c/illumos-gate/= +/3610

When this first ca= me up I expressed my belief that making this change is the wrong
t= hing to do, and I'll express it again.

If this service fai= ls, I think the best thing to do is drive on so that the system can come
up as far as possible to maximise the chance that the system comes u= p far enough for
an administrator to be able to get in and fix it.= Not putting the service into maintenance
is a feature, not a bug.=

(If it fails, then there's something deeper wrong with th= e system, and those fundamental
causes should be dealt with.)
<= br>
I think generally it would be wrong for a single voice to veto any= change, which means I
would generally be uncomfortable sticking a= -1 on it, but if this does get into the gate
it will be reverted = in Tribblix.

Regards,
--00000000000027cdc0061e25df09--