public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
* [REVIEW] 16763: dladm simnet functionality should be documented
@ 2024-09-11  5:24 william
  2024-09-11 18:48 ` [developer] " Olaf Bohlen
  0 siblings, 1 reply; 6+ messages in thread
From: william @ 2024-09-11  5:24 UTC (permalink / raw)
  To: developer

Hello all,

I have an initial contribution for basic simnet documentation that I'd 
like to have reviewed.

Gerrit Review: https://code.illumos.org/c/illumos-gate/+/3683

Bug Ticket: https://www.illumos.org/issues/16763

For ease of review, I attached an HTML rendition of the proposed man 
page changes. Unfortunately, redmine helpfully renders the markup to 
text. I've temporarily made the page available at:

http://bill.welliver.org/dist/dladm.8.html

Any feedback would be welcome!

Best,

Bill

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [developer] [REVIEW] 16763: dladm simnet functionality should be documented
  2024-09-11  5:24 [REVIEW] 16763: dladm simnet functionality should be documented william
@ 2024-09-11 18:48 ` Olaf Bohlen
  2024-09-12  4:20   ` H. William Welliver
  0 siblings, 1 reply; 6+ messages in thread
From: Olaf Bohlen @ 2024-09-11 18:48 UTC (permalink / raw)
  To: illumos-developer

Dear William,

maybe the create-simnet subcommand should include a very brief explanation what “simnet” actually is. So that end users understand that it is mostly a debugging facility.

Regards,

Olaf Bohlen
olbohlen@eenfach.de

> Am 11.09.2024 um 07:24 schrieb william@welliver.org:
> 
> Hello all,
> 
> I have an initial contribution for basic simnet documentation that I'd like to have reviewed.
> 
> Gerrit Review: https://code.illumos.org/c/illumos-gate/+/3683
> 
> Bug Ticket: https://www.illumos.org/issues/16763
> 
> For ease of review, I attached an HTML rendition of the proposed man page changes. Unfortunately, redmine helpfully renders the markup to text. I've temporarily made the page available at:
> 
> http://bill.welliver.org/dist/dladm.8.html
> 
> Any feedback would be welcome!
> 
> Best,
> 
> Bill
> 
> ------------------------------------------
> illumos: illumos-developer
> Permalink: https://illumos.topicbox.com/groups/developer/Ta3283bbd32ecf85f-M32dbe25c3985f34d45a63077
> Delivery options: https://illumos.topicbox.com/groups/developer/subscription


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [developer] [REVIEW] 16763: dladm simnet functionality should be documented
  2024-09-11 18:48 ` [developer] " Olaf Bohlen
@ 2024-09-12  4:20   ` H. William Welliver
  2024-09-12  8:33     ` Olaf Bohlen
  0 siblings, 1 reply; 6+ messages in thread
From: H. William Welliver @ 2024-09-12  4:20 UTC (permalink / raw)
  To: illumos-developer

Hi!

I did add a brief description of what simnets are in the “Description” section, as that is where other types of objects (vnics, etherstubs, etc) are introduced. I’ll also willingly admit that I don’t normally read that section and jump right to the command details but I was trying to remain consistent with the existing document.

As a side-note: I didn’t specifically describe simnets as a debugging facility because I think they can be handy for other things, as well. I first (mis)used them by adding one to a bridge created from the physical nics on the device. I then configured the other end as the host’s primary interface. This enabled the host to be accessible without a particular port needing to be physically “up”. Strange and very niche, but pretty handy for making network appliances.

Bill

> On Sep 11, 2024, at 2:48 PM, Olaf Bohlen <olbohlen@eenfach.de> wrote:
> 
> Dear William,
> 
> maybe the create-simnet subcommand should include a very brief explanation what “simnet” actually is. So that end users understand that it is mostly a debugging facility.
> 
> Regards,
> 
> Olaf Bohlen
> olbohlen@eenfach.de


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [developer] [REVIEW] 16763: dladm simnet functionality should be documented
  2024-09-12  4:20   ` H. William Welliver
@ 2024-09-12  8:33     ` Olaf Bohlen
  2024-09-12  8:46       ` Joshua M. Clulow
  0 siblings, 1 reply; 6+ messages in thread
From: Olaf Bohlen @ 2024-09-12  8:33 UTC (permalink / raw)
  To: H. William Welliver; +Cc: illumos-developer

"H. William Welliver" <william@welliver.org> writes:

Hi,

> I did add a brief description of what simnets are in the “Description”
> section, as that is where other types of objects (vnics, etherstubs,
> etc) are introduced. I’ll also willingly admit that I don’t normally
> read that section and jump right to the command details but I was
> trying to remain consistent with the existing document.

Yes, I meant something like "the dladm create-simnet creates an
instance of a simulated network device mostly used for debugging
purposes" or similar...so an indirect formulation - because a lot
of people just skip the descriptions ;)

Regards,

Olaf

-- 
      ~       Olaf Bohlen - olbohlen@eenfach.de
      |~~     Het
     /|  \    Bruine
 ___/_|___\   Leven
   \__n____/# DGCN2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [developer] [REVIEW] 16763: dladm simnet functionality should be documented
  2024-09-12  8:33     ` Olaf Bohlen
@ 2024-09-12  8:46       ` Joshua M. Clulow
  0 siblings, 0 replies; 6+ messages in thread
From: Joshua M. Clulow @ 2024-09-12  8:46 UTC (permalink / raw)
  To: illumos-developer; +Cc: H. William Welliver

On Thu, 12 Sept 2024 at 01:33, Olaf Bohlen <olbohlen@eenfach.de> wrote:
> "H. William Welliver" <william@welliver.org> writes:
> > I did add a brief description of what simnets are in the “Description”
> > section, as that is where other types of objects (vnics, etherstubs,
> > etc) are introduced. I’ll also willingly admit that I don’t normally
> > read that section and jump right to the command details but I was
> > trying to remain consistent with the existing document.
>
> Yes, I meant something like "the dladm create-simnet creates an
> instance of a simulated network device mostly used for debugging
> purposes" or similar...so an indirect formulation - because a lot
> of people just skip the descriptions ;)

I think "debugging purposes" is a bit too editorial, to be honest.
You can use them for really any purpose, including tinkering and
simulating different network topologies between zones or VMs.  At
Oxide, we have a framework called Falcon for driving networking and
virtualisation test topologies that makes pretty heavy use of simnets
for certain things:

    https://github.com/oxidecomputer/falcon


Cheers.

-- 
Joshua M. Clulow
http://blog.sysmgr.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [developer] [REVIEW] 16763: dladm simnet functionality should be documented
@ 2024-09-27 21:21 william
  0 siblings, 0 replies; 6+ messages in thread
From: william @ 2024-09-27 21:21 UTC (permalink / raw)
  To: developer

Hello all,

I'd like, if possible, to get another round of review for the referenced 
change. I believe all previous comments have been accounted for.

Many thanks in advance!

Bill
----

Hello all,

I have an initial contribution for basic simnet documentation that I'd 
like to have reviewed.

Gerrit Review: https://code.illumos.org/c/illumos-gate/+/3683

Bug Ticket: https://www.illumos.org/issues/16763

For ease of review, I attached an HTML rendition of the proposed man 
page changes. Unfortunately, redmine helpfully renders the markup to 
text. I've temporarily made the page available at:

http://bill.welliver.org/dist/dladm.8.html

Any feedback would be welcome!

Best,

Bill

------------------------------------------
illumos: illumos-developer
Permalink: 
https://illumos.topicbox.com/groups/developer/Ta3283bbd32ecf85f-M32dbe25c3985f34d45a63077
Delivery options: 
https://illumos.topicbox.com/groups/developer/subscription

------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/Tb6887dc098e74ed0-M277ba421938e45c29643ac77
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-09-27 21:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-11  5:24 [REVIEW] 16763: dladm simnet functionality should be documented william
2024-09-11 18:48 ` [developer] " Olaf Bohlen
2024-09-12  4:20   ` H. William Welliver
2024-09-12  8:33     ` Olaf Bohlen
2024-09-12  8:46       ` Joshua M. Clulow
2024-09-27 21:21 william

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).