From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id BA79D207F08C for ; Fri, 26 Jul 2024 09:41:16 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 83D885E1FC7; Fri, 26 Jul 2024 09:41:16 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1722001276; b=rqm3D8/WrAPs23gidmDNwZkolnbM9FWT8KAwlXNhI2yx6r7roA yyh6tyQNhdPclM6e5zNC9rNZ71TwG5SN3RK2/26qrrpgXcOPDF5uYab13W8T2y9s TjmR6U4IMcDyOCaegjdYPQkvwvxJbL/pgu8k1HidfJEovxhacvKukFukjJWMxBNu +Nc124E6U7m2ytO/P5rYo7s7TnfQJQb0uX89nIbbMPC8bpbNiJ28GVjcFWSa1bEv ascMm1/YRsJpMAbdxNTCwNFfC/cW9Cz03FvJDNE+NWtgchXUyzUkdT4/9YTrLAJy 7Xyn/mdwbfRyI6V2lMZUtCjGj7cK3GehXAsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject:date :references:to:in-reply-to:message-id; s=arcseal; t=1722001276; bh=ciKIE6TT3vY/sGpIaR+EKK0iLW6Hl3i1azeTrCrS7QY=; b=hmaM4KIxGKnE 2e+hCH0LiO9/MRPEZGnunV4ejsSX7HUTU5RjMc04PaaAdEV2BU3S2LCzKrVc4NQU KfE7VoGZqDtSKvzHlic6ioCTHi2vSKlJorB3FiMUx8eHzDM4TFGS8zpbSc2XHWCe CbgnXW5x803zEG7k01Zvlw/swK95URGWlWm2ZmTgAegf7n+eMLged7QeHF1CYHl6 O2Gmo3BlfbfhkYv5/4Zx+abf/0byNywoqNWZBheX0kVh+DLA+k/Gn90fWIUC48z4 LS2pPqbQSFeQlARQJLTDji+XQl12sjRGDATuJzSIzZqcgxXtyVwYFbeNIvUYsv0z xRVB+EKJxw== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=OfKbGnbD header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.188 (mr85p00im-hyfv06021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-hyfv06021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-hyfv06021301.me.com policy.ptr=mr85p00im-hyfv06021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=OfKbGnbD header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.188 (mr85p00im-hyfv06021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-hyfv06021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-hyfv06021301.me.com policy.ptr=mr85p00im-hyfv06021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrieehgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhtggguffffhfvjgfkofesrgdtmherhhdtjeenucfh rhhomhepvfhoohhmrghsucfuohhomhgvuceothhsohhomhgvsehmvgdrtghomheqnecugg ftrfgrthhtvghrnhepffdvtdfhudduhfdtuddttdduudeuvdduleejgeffhffgfeefheev fedugfektdevnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppedujedrhe ekrddvfedrudekkedpudejrdehjedrudehvddrudeknecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehinhgvthepudejrdehkedrvdefrddukeekpdhhvghlohepmhhrke ehphdttdhimhdqhhihfhhvtdeitddvudeftddurdhmvgdrtghomhdpmhgrihhlfhhrohhm peeothhsohhomhgvsehmvgdrtghomheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoh epoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.23.188 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=mr85p00im-hyfv06021301.me.com; client-ip=17.58.23.188 Received: from mr85p00im-hyfv06021301.me.com (mr85p00im-hyfv06021301.me.com [17.58.23.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Fri, 26 Jul 2024 09:41:16 -0400 (EDT) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1722001275; bh=ciKIE6TT3vY/sGpIaR+EKK0iLW6Hl3i1azeTrCrS7QY=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=OfKbGnbDQjBGAAWyaG2C5lbTxHsgzHfiPaOO7mWW48ggXSKREEh1TC7qX7PRtcJ5p 0VHnSZWsaIb+lmGntOSAid50S7UCj8HtdUepI09VgFNGyeTBHj1s22YIqX15BW6IAc N7+I/VpfUPIsf4XeVSj3MTseTbrzRjUDjUUGr/Hncg2csF6YbiDgmbhb5O29EpSYs4 vXuR91SjXDonkZo+rAig3tj4cyUUmhx7MDUcM+XPQ6wQM80KgwkJJVy4eCyMEJZT+x uPhgn3/M35j9hGQWwGwGIr/43RYSiE1QAVtUpLoet+ViteuKZLPIdMjKmYtGWILeDH q+7R4ceSg59AQ== Received: from smtpclient.apple (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-hyfv06021301.me.com (Postfix) with ESMTPSA id 4BA202150D13 for ; Fri, 26 Jul 2024 13:41:14 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_3C7327C6-3B9B-41D1-BE99-5F4325F2F86B" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [developer] Review - 15665 svc:/network/loopback exits successfully even if it fails Date: Fri, 26 Jul 2024 16:41:01 +0300 References: <20240726082032.GA10040@reaper.citrus-it.net> To: illumos-developer In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3774.600.62) X-Proofpoint-GUID: Pjp4yvvhZqXJJGJERBQ8bixNJkOhCpiO X-Proofpoint-ORIG-GUID: Pjp4yvvhZqXJJGJERBQ8bixNJkOhCpiO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-26_11,2024-07-26_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1015 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2407260093 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: be5521b2-4b54-11ef-b152-d0ba048c7b06 --Apple-Mail=_3C7327C6-3B9B-41D1-BE99-5F4325F2F86B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 26. Jul 2024, at 15:44, Peter Tribble = wrote: >=20 > On Fri, Jul 26, 2024 at 9:21=E2=80=AFAM Andy Fiddaman = > wrote: >> Please can you review the following change? >>=20 >> 15665 svc:/network/loopback exits successfully even if it fails >> https://www.illumos.org/issues/15665 >> https://code.illumos.org/c/illumos-gate/+/3610 >=20 > When this first came up I expressed my belief that making this change = is the wrong > thing to do, and I'll express it again. >=20 > If this service fails, I think the best thing to do is drive on so = that the system can come > up as far as possible to maximise the chance that the system comes up = far enough for > an administrator to be able to get in and fix it. Not putting the = service into maintenance > is a feature, not a bug. >=20 > (If it fails, then there's something deeper wrong with the system, and = those fundamental > causes should be dealt with.) >=20 > I think generally it would be wrong for a single voice to veto any = change, which means I > would generally be uncomfortable sticking a -1 on it, but if this does = get into the gate > it will be reverted in Tribblix. >=20 hm, ok, you mean that service startup error in case of network/loopback = will block too many other services? but then again, if there is an = error, those depending services are also not functional, aren't they? = Otherwise those depending services should not depend on network/loopback = ;) rgds, toomas --Apple-Mail=_3C7327C6-3B9B-41D1-BE99-5F4325F2F86B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 26. Jul 2024, at 15:44, Peter Tribble = <peter.tribble@gmail.com> wrote:

On Fri, Jul 26, 2024 at 9:21=E2=80=AFAM Andy Fiddaman = <illumos@fiddaman.net> = wrote:
Please can you review the = following change?

    15665 svc:/network/loopback exits successfully even if it = fails
    https://www.illumos.org/issues/15665
    https://code.illumos.org/c/illumos-gate/+/3610

When this first came up I = expressed my belief that making this change is the wrong
thing = to do, and I'll express it again.

If this service fails, I = think the best thing to do is drive on so that the system can = come
up as far as possible to maximise the chance that the = system comes up far enough for
an administrator to be able to = get in and fix it. Not putting the service into maintenance
is = a feature, not a bug.

(If it fails, then there's something = deeper wrong with the system, and those fundamental
causes = should be dealt with.)

I think generally it would be wrong = for a single voice to veto any change, which means I
would = generally be uncomfortable sticking a -1 on it, but if this does get = into the gate
it will be reverted in = Tribblix.


hm, ok, = you mean that service startup error in case of network/loopback will = block too many other services? but then again, if there is an error, = those depending services are also not functional, aren't they? Otherwise = those depending services should not depend on network/loopback = ;)

rgds,
toomas

= --Apple-Mail=_3C7327C6-3B9B-41D1-BE99-5F4325F2F86B--