From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 04AFC20D5EA4 for ; Wed, 28 Aug 2024 15:56:48 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id 902520C6063; Wed, 28 Aug 2024 15:56:48 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1724875007; b=xaRjnoNa25u5W5ukjQ6FPNVCaXqV6Hq79x7d43VTZqdF0Wr5Hy mghU4bFaYIMfjLv7fRwvRUoTju8DNTH5EahgPP/EftgM0A2Pyd9dcIqUuxcw3SWS 1lJ8sKxjOQ3L5GGzJDPdpWlFtSdjbIKA6+6PLEcbzcpobfAiAGXX1Cs4VMQC3Fp1 qax7X/T7Gq+aQadWD8/uPBq9XJKkvgFxLMb/3nbXmZ3ERBi2bKmzO3TukxmHDDdw GVuFVOzTY3O3b/oM5IC3Uw/vnnbqj72W/IVelznUAr6qzZpu+O0QaYlfAemc8xpv dpZjDMLXHHqtDi2BMFiKcx6P58cr7F1lsbfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject:date :references:to:in-reply-to:message-id; s=arcseal; t=1724875007; bh=Ima+lIdP+89g3mGh7l/yv1DSQpe8XebyccjMoMTiRJ8=; b=ZBh6cHfTiIy5 7SkXQ75F32AIQXRcziRTYX2tfKc8q67apl+4+SHYLs18DDtWPANLfU7pkvYsj7qr 3KoYBVk+7kZg+R5AZTYpmqm/Fa3v+Os7bjMW1R//ItGdaAd07FvGgm8kEQ4u7CQA y4XyiuHnkwVxEF3dXzUaZ/nkRmcSJtrKVDWqsQeGjbJHAtfaBDMJ/JCuPidQOB9z jqZF8R3OLvd97IrtpzrtgVRAJGNXEl5bJGpLn4LsV3o5ZMnxvZVburaiB+tKOeT0 8eXa76QOoDiORoSxCiT/paF+jeBMYL3RTdJFcDvcZfTemQ92Q5SQfnuytE+GBMyt BUGuoBe/5g== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=QNDoXW0E header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.186 (mr85p00im-zteg06011601.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-zteg06011601.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-zteg06011601.me.com policy.ptr=mr85p00im-zteg06011601.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=QNDoXW0E header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.186 (mr85p00im-zteg06011601.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-zteg06011601.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-zteg06011601.me.com policy.ptr=mr85p00im-zteg06011601.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefvddgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhtggguffffhfvjgfkofesrgdtmherhhdtvden ucfhrhhomhepvfhoohhmrghsucfuohhomhgvuceothhsohhomhgvsehmvgdrtghomheqne cuggftrfgrthhtvghrnhepledtffefheffleegkeevveeuleefjedvheffheeiieektdek geehhfdvieeuhedtnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppeduje drheekrddvfedrudekiedpudejrdehjedrudehvddrudeknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehinhgvthepudejrdehkedrvdefrddukeeipdhhvghlohepmh hrkeehphdttdhimhdqiihtvghgtdeitdduudeitddurdhmvgdrtghomhdpmhgrihhlfhhr ohhmpeeothhsohhomhgvsehmvgdrtghomheqpdhnsggprhgtphhtthhopedupdhrtghpth htohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.23.186 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=mr85p00im-zteg06011601.me.com; client-ip=17.58.23.186 Received: from mr85p00im-zteg06011601.me.com (mr85p00im-zteg06011601.me.com [17.58.23.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Wed, 28 Aug 2024 15:56:47 -0400 (EDT) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1724875006; bh=Ima+lIdP+89g3mGh7l/yv1DSQpe8XebyccjMoMTiRJ8=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=QNDoXW0EQOBafyATjl7InoDy56HCmiKtbqBkeLHlbR8BHRLp3dwt/RG8Ds4iDTatg cHC8gUBt/d4UN0x15EXpnfNOEMSO2eOOAFCaMofhcDromomwpO+IjheTqpblt2wYTI wm4ShyXvw4V9gLx0AToU9K+nhp/VDdmaS2VakgwmC2TsdrS3r6aOTClXMzIvbuCt2v EPQUCl6Ooae9dJXubkQLo4qcKJ+iFNfPh5zEzzTodr7Qgu0zyYj9GMvpKC+6wbQ6gf VhQGP/d7Mx90k9VYRaJsdxmBk/LYWb3UUumFOY4xyHm3b3VZQRBUIWTT0dIUeX/Q9/ 3YeYwC5YIrkvQ== Received: from smtpclient.apple (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-zteg06011601.me.com (Postfix) with ESMTPSA id D47871803AD for ; Wed, 28 Aug 2024 19:56:44 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_B804968E-CF79-4E61-AD18-EB83799D3854" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: REVIEW: 16688 libipadm: storing the address of local variable Date: Wed, 28 Aug 2024 22:56:31 +0300 References: To: illumos-developer In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3776.700.51) X-Proofpoint-GUID: K9l5dwffbj-MmHxanxW-Aemtgo-blrPK X-Proofpoint-ORIG-GUID: K9l5dwffbj-MmHxanxW-Aemtgo-blrPK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-28_08,2024-08-28_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2408280145 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: ac2a223e-6577-11ef-92de-8a3b6ebd5c02 --Apple-Mail=_B804968E-CF79-4E61-AD18-EB83799D3854 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Ping:) Reworked as suggested by C Fraire. Thanks, Toomas > On 1. Aug 2024, at 15:00, Toomas Soome wrote: > > hi! > > Please review: https://code.illumos.org/c/illumos-gate/+/3617 > > I think, we can switch to use global variable in this case. > > thanks, > toomas --Apple-Mail=_B804968E-CF79-4E61-AD18-EB83799D3854 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Ping:)

Reworked as suggested by C = Fraire.

Thanks,
Toomas

On 1. Aug 2024, at 15:00, Toomas Soome = <tsoome@me.com> wrote:

hi!


I think, we can switch to use = global variable in this case.

thanks,
toomas

= = --Apple-Mail=_B804968E-CF79-4E61-AD18-EB83799D3854--