From: Jason King <jason.brian.king@gmail.com>
To: _illumos-dev <developer@lists.illumos.org>
Subject: [REVIEW] 16594 SATL confuses lengths resulting in bad resid values
Date: Tue, 4 Jun 2024 21:35:42 +0000 [thread overview]
Message-ID: <SJ0PR12MB67340E81754EC83AD49DB49AA4F82@SJ0PR12MB6734.namprd12.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
https://code.illumos.org/c/illumos-gate/+/3539
If anyone has tried using sg3 utils’ sg_log -l or sg_mode -l on a SATA drive, it more than likely fails. This should fix it.
There is arguably a second bug in the pkt_resid value when value is non-zero as described in the ticket, though there is probably some debate on what the right value should be in that circumstance. It might be worth deferring that into a separate ticket so it can be fixed if there’s a consensus on what the fix should be for that.
[-- Attachment #2: Type: text/html, Size: 2077 bytes --]
reply other threads:[~2024-06-04 21:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR12MB67340E81754EC83AD49DB49AA4F82@SJ0PR12MB6734.namprd12.prod.outlook.com \
--to=jason.brian.king@gmail.com \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).