Review: 16277 lmrc should handle early AENs safely

Review: 16277 lmrc should handle early AENs safely

[Hans Rosenfeld]

Hi,

please review this fix for lmrc:
https://www.illumos.org/issues/16277
https://code.illumos.org/c/illumos-gate/+/3295

This should fix the other panic that Maurilio reported a few days ago.

Apparently there's a short time window during lmrc attach between
lmrc_ctrl_attach() finishing and the lmrc iports attaching. If for
whatever reason the HBA generates an AEN during that time, we might try
to access the tgtmaps before they are allocated.

Thus we should short-circuit lmrc_get_pd_list() and lmrc_get_ld_list()
until the respective iports have completed attaching, causing us to
essentially ignore any early AENs. Given that both iports call the
respective functions to get LD and PD lists, we're not going to miss any
important information.


Thanks,

Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown