public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: Jonathan Perkin <jperkin@mnx.io>
To: Richard Lowe <richlowe@richlowe.net>
Cc: illumos-dev <developer@lists.illumos.org>,
	Dominik Hassler <hadfl@omnios.org>
Subject: Re: [REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants
Date: Sat, 9 Mar 2024 14:05:19 +0000	[thread overview]
Message-ID: <ZexsnzN3TdoGATtn@mnx.io> (raw)
In-Reply-To: <CAA7J0x-ka_RajoSyU-s0+jKiSecT-RVtPMj3payZ-_Sz+PBZDw@mail.gmail.com>

* On 2024-03-07 at 21:40 GMT, Richard Lowe wrote:

>https://code.illumos.org/c/illumos-gate/+/3358
>
>This fixes SIG_* constants to please modern compilers wanting to drop
>K&R support, and fixes illumos-gate to not be wrong.
>
>I'd appreciate a careful look.  I'd also appreciate it if we could get
>bulk builds of this (Jonathan? Dominik?).

I've ran it through a bulk build, looks great.

Cheers,

-- 
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com

      parent reply	other threads:[~2024-03-09 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 21:39 Richard Lowe
2024-03-07 21:45 ` Richard Lowe
2024-03-09 14:05 ` Jonathan Perkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZexsnzN3TdoGATtn@mnx.io \
    --to=jperkin@mnx.io \
    --cc=developer@lists.illumos.org \
    --cc=hadfl@omnios.org \
    --cc=richlowe@richlowe.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).