[REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants

[REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants

[Richard Lowe]

https://code.illumos.org/c/illumos-gate/+/3358

This fixes SIG_* constants to please modern compilers wanting to drop
K&R support, and fixes illumos-gate to not be wrong.

I'd appreciate a careful look.  I'd also appreciate it if we could get
bulk builds of this (Jonathan? Dominik?).

I haven't tested this much at all as yet, except with wsdiff (which
only contains differences I can explain, fwiw, but I'm not happy with
the completeness of that as yet).  I plan to at least additionally
verify with psig(1) that everything is still hooked up as we expect,
where possible.

-- Rich

Re: [REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants

[Richard Lowe]

Sorry, I forgot to also mention I'd appreciate any wordsmithing of
sigaction(2), where our previous example gave an incorrect prototype
and I just sort of bodged it.

I'd also suggest looking at:
https://pubs.opengroup.org/onlinepubs/007904875/functions/sigaction.html
regarding the 3rd argument when `SA_SIGINFO` being `void *` but "not
requiring type checking", etc.

Re: [REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants

[Jonathan Perkin]

* On 2024-03-07 at 21:40 GMT, Richard Lowe wrote:

>https://code.illumos.org/c/illumos-gate/+/3358
>
>This fixes SIG_* constants to please modern compilers wanting to drop
>K&R support, and fixes illumos-gate to not be wrong.
>
>I'd appreciate a careful look.  I'd also appreciate it if we could get
>bulk builds of this (Jonathan? Dominik?).

I've ran it through a bulk build, looks great.

Cheers,

-- 
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com