public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: Keith M Wesolowski <wesolows@oxide.computer>
To: illumos-developer <developer@lists.illumos.org>
Subject: Review - fmdump improvements: 11745, 16051-2, 16054, 16056
Date: Tue, 2 Apr 2024 09:34:57 -0700	[thread overview]
Message-ID: <ZgwzsYk_6NehtqVb@monolith.localdomain> (raw)

Please review my changes to fmdump and its documentation which may be found at
https://code.illumos.org/c/illumos-gate/+/3150.  The bugs and RFEs addressed
by this set of changes are:

11745 fmdump missing -i and -I parameter documentation in the man pages
16051 fmdump -A, -a, -H, -j, and -p should be documented
16052 fmdump -O uses unchecked strtoull
16054 fmdump mishandles interleaved arguments with -A
16056 want fmdump ability to AND event property filters

https://www.illumos.org/issues/11745
https://www.illumos.org/issues/16051
https://www.illumos.org/issues/16052
https://www.illumos.org/issues/16054
https://www.illumos.org/issues/16056

There are test results in each of the tickets except for 16051 which is
covered along with 11745.  There is also test data, which happens to be the
exact body of data that inspired the RFE in 16056, included with that ticket
if anyone wants to examine or extend it into the start of a test suite.  The
additions to the manual should help clarify the intent behind these changes if
the text in the tickets isn't enough.

Please let me know if there's anything else that would aid review.  These
changes aren't very large or complex despite the number of tickets and seeming
complexity; most of it is new block comments and doc updates.

                 reply	other threads:[~2024-04-02 16:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgwzsYk_6NehtqVb@monolith.localdomain \
    --to=wesolows@oxide.computer \
    --cc=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).