From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 7107B13E3476 for ; Tue, 2 Apr 2024 12:35:02 -0400 (EDT) (envelope-from keith@oxidecomputer.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 1972A7935BF; Tue, 2 Apr 2024 12:35:02 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1712075702; b=rLiVNWlHuOm4s2zWMQ7zDuBRayiSNHpFK04HjSzluqwYORHSWN mziktVK3fCZ/jeeDR2wZRWGWq51vNnyQq5o1UBVnwOLZef2b63ih/C7f16CJubf7 j87a1PYuiHbVb4tBbp/dc30R9gD2rjCB8mt4DXdGh7/1rtkth2l1GT0cNQAtTJVK UoVIx5DYIq05iRq2UghqY9aIny4aPKV5YSm8SkLDkXSXg+TmaVIIyIAkfI5RB68L UO1gJHEh4V+azyxn9new2B80kdgi70LwkI4tiVty6PC2wmp3aQhAZvVetENzSYci bIaaRequptQyTcDwfYd3R9+m30UhDABqlK4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1712075702; bh=NNQQcO8JLd/ImQJ6K3qmk d8rrXjrZuZVuupOKJkpB9Q=; b=NDC96A3FTc58Twgk99BdkLali3PnugvGc6Wzh 6mi1rudgCIVBmcuA8Nxb4v8om6XcfnDSv0zTid3Vpgq3foXOPLhWVHk5CLiNSMuN WPD6SKCO3ozJQK/wLJXnvhcis8Kpjay3ttSueaiCUtDt5KPgF9L8k/L2zp6OYnOd C8L3nLbNf3SxVxViSlqFl4ZpnpCUi0MYjtE47PqLx7SJMnKKpK1m0YOWDRcab96X 5DkGVusdntqYKNiqYGFABS696UMx3ys41ucV6LDh7BK90z7uBuenwad283O634m/ T5jUU9Nuu0zuzUzU726CduBC4dkngi51AfqVawKFvUg6Fn8kg== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=oxide.computer header.i=@oxide.computer header.b=m3E46gIO header.a=rsa-sha256 header.s=google x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=oxide.computer; iprev=pass smtp.remote-ip=209.85.210.171 (mail-pf1-f171.google.com); spf=pass smtp.mailfrom=keith@oxidecomputer.com smtp.helo=mail-pf1-f171.google.com; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=hs0vWRDy; x-me-sender=none; x-ptr=pass smtp.helo=mail-pf1-f171.google.com policy.ptr=mail-pf1-f171.google.com; x-return-mx=pass header.domain=oxide.computer policy.is_org=yes (MX Records found: alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com,alt2.aspmx.l.google.com); x-return-mx=pass smtp.domain=oxidecomputer.com policy.is_org=yes (MX Records found: alt1.aspmx.l.google.com,aspmx2.googlemail.com,aspmx3.googlemail.com,aspmx.l.google.com,alt2.aspmx.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=oxide.computer header.i=@oxide.computer header.b=m3E46gIO header.a=rsa-sha256 header.s=google x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=oxide.computer; iprev=pass smtp.remote-ip=209.85.210.171 (mail-pf1-f171.google.com); spf=pass smtp.mailfrom=keith@oxidecomputer.com smtp.helo=mail-pf1-f171.google.com; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=hs0vWRDy; x-me-sender=none; x-ptr=pass smtp.helo=mail-pf1-f171.google.com policy.ptr=mail-pf1-f171.google.com; x-return-mx=pass header.domain=oxide.computer policy.is_org=yes (MX Records found: alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com,alt2.aspmx.l.google.com); x-return-mx=pass smtp.domain=oxidecomputer.com policy.is_org=yes (MX Records found: alt1.aspmx.l.google.com,aspmx2.googlemail.com,aspmx3.googlemail.com,aspmx.l.google.com,alt2.aspmx.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrudefvddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvuffkgggtugesthdtredttddtvdenucfh rhhomhepmfgvihhthhcuofcuhggvshholhhofihskhhiuceofigvshholhhofihssehogi hiuggvrdgtohhmphhuthgvrheqnecuggftrfgrthhtvghrnhepteegvdekieehfeefiefg hedvtedtuedtffdugeeiudetueejleeluefftdfgledvnecuffhomhgrihhnpehilhhluh hmohhsrdhorhhgnecukfhppedvtdelrdekhedrvddutddrudejuddpudejfedrvddvhedr keelrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvd dtledrkeehrddvuddtrddujedupdhhvghlohepmhgrihhlqdhpfhduqdhfudejuddrghho ohhglhgvrdgtohhmpdhmrghilhhfrhhomhepoehkvghithhhsehogihiuggvtghomhhpuh htvghrrdgtohhmqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvhgvlhho phgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (oxidecomputer.com: Sender is authorized to use 'keith@oxidecomputer.com' in 'mfrom' identity (mechanism 'include:_spf.google.com' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="keith@oxidecomputer.com"; helo=mail-pf1-f171.google.com; client-ip=209.85.210.171 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Tue, 2 Apr 2024 12:35:01 -0400 (EDT) (envelope-from keith@oxidecomputer.com) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6ead4093f85so5048322b3a.3 for ; Tue, 02 Apr 2024 09:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oxide.computer; s=google; t=1712075699; x=1712680499; darn=lists.illumos.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=NNQQcO8JLd/ImQJ6K3qmkd8rrXjrZuZVuupOKJkpB9Q=; b=m3E46gIOlHk5k3M9AvWldM1bpiHJCFcAw1OPdl9uJCJ0mRacgPhljhQJk5SnJwdG+s jqzH/h/hlwJqA+Pz8ogiskqrm25rVOxXk152PrL7vQRZTw7EJJ0bQZauPAZqb7iEJZi8 QaDULxjcgUzhWCepNrSP+cNtVAdofyIUq+ONAyaoPiqJlZkdESRzTbIevFU/vuXguZTC X9S3oSpj7qbAxCZjOijXDh+StYbuEfbnZZsZI8zyv5Oy74h1KedHyLzBJKHmLq83uzts TaSPWuALSI3wPVSEE4bToO9LuWO3I/rFeFp7NFvjzKdeUrsDjQrd2uwfXhD+RBgz1BRZ EZSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712075699; x=1712680499; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NNQQcO8JLd/ImQJ6K3qmkd8rrXjrZuZVuupOKJkpB9Q=; b=hs0vWRDyLCVztP0tij3SYok5tOtRm2TEPWmBRb5hckUv/+TcVmIxZ2dPi4tGI2xAhG bAMm4t7FVbjRJohSnQLeugmrjtdKniaW6Q1JGgoWbLFlL8yLqhiIdeJGED6S8WS0puCV 3kC2kS5CTxz89sJimI1mqIYJx8aii66vsSMnHFNkcJmM5wsiEJEe1qO34DqaijhZH4JN D8zwD00+Y891B2L+XLVz/3nj15KZXcTvhcjSygPljAwos9djw7IVVKYCw2GYPQOz0jht 7+X1mx/ggynVTGg9H1di4o4yCutavIYFfbet6AGVLPIPZ+1ixFZ0OTlJc18Y7ZrFCDF5 CmuA== X-Gm-Message-State: AOJu0YwrMFpEsSSuHua08/J4ujbQ57gds51IR2lbtfS7uHsjoAMgWSwJ bPGVOP213CvrVBJOO2/hEBNgumopBSapY14FYN6YUr0zkPtnm2jVebcj/ViARhbm6BpYM3JCEjt b X-Google-Smtp-Source: AGHT+IHU2HcLeMiOF1wKaedanHqZcbKiw0PVkQnKMd2kBxY55Rsot58IwG7FJ3GUhIBIbwJVvCmOuQ== X-Received: by 2002:a05:6a20:258e:b0:1a7:23d1:d7dc with SMTP id k14-20020a056a20258e00b001a723d1d7dcmr1776371pzd.17.1712075699506; Tue, 02 Apr 2024 09:34:59 -0700 (PDT) Received: from oxidecomputer.com (ip-173-225-89-117-spk.cet.com. [173.225.89.117]) by smtp.gmail.com with ESMTPSA id fd34-20020a056a002ea200b006ecbcbd2293sm3195469pfb.173.2024.04.02.09.34.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 09:34:59 -0700 (PDT) Date: Tue, 2 Apr 2024 09:34:57 -0700 From: Keith M Wesolowski To: illumos-developer Subject: Review - fmdump improvements: 11745, 16051-2, 16054, 16056 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: f913d4a6-f10e-11ee-b9d5-78d1088c7b06 Please review my changes to fmdump and its documentation which may be found at https://code.illumos.org/c/illumos-gate/+/3150. The bugs and RFEs addressed by this set of changes are: 11745 fmdump missing -i and -I parameter documentation in the man pages 16051 fmdump -A, -a, -H, -j, and -p should be documented 16052 fmdump -O uses unchecked strtoull 16054 fmdump mishandles interleaved arguments with -A 16056 want fmdump ability to AND event property filters https://www.illumos.org/issues/11745 https://www.illumos.org/issues/16051 https://www.illumos.org/issues/16052 https://www.illumos.org/issues/16054 https://www.illumos.org/issues/16056 There are test results in each of the tickets except for 16051 which is covered along with 11745. There is also test data, which happens to be the exact body of data that inspired the RFE in 16056, included with that ticket if anyone wants to examine or extend it into the start of a test suite. The additions to the manual should help clarify the intent behind these changes if the text in the tickets isn't enough. Please let me know if there's anything else that would aid review. These changes aren't very large or complex despite the number of tickets and seeming complexity; most of it is new block comments and doc updates.