From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id C2F4620A9CC2 for ; Sun, 28 Jul 2024 19:16:34 -0400 (EDT) (envelope-from marcel@telka.sk) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 0F63BFEFBCC; Sun, 28 Jul 2024 19:16:34 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1722208594; b=X/jnGeJbVNs4a75+dlLqyqwjEuVal0+4XrbGwq3eBANVelaxPL K98l1hT3dYdWS/aeQbGrk02ALk5NGbt7UXyBRqGPsrLe5oJgM3oqen0I89NRvtm1 OQ4dRuAx2din45tUR3L/nms2fkaff8hk7JdMntOb2XaCHgyTvw5tBdFR2s93DGR/ MH47ai+MOWpxRaB/DZR3UWHw9Y+3Aid/itDXS0MA0iJDItLtetO5BpnU1CFwxrHq 8BA7U8plhQ6V/SZmCpLgSjcQKc6FuxqeGF1X3HIeY78+ySja6kvS6GiRbx1SO8QP ArRKIvfeiIYh+zVTvJrMZg/P4c01+Es3evhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:references :mime-version:content-type:in-reply-to; s=arcseal; t=1722208594; bh=UAopT0aWqHYKyXg8ZR5ZfEJli+0XQloqpAMu9+9w67U=; b=wSkNZqqCFxcn 7+XeOOCd73bZrskeg6qUAhUMbmbDet2Rrxbx/4POb6BpfaH/L25swUg1ivH8PpER 1vMpb/8QPA3vUh1TS/3NDyO9HJQ7Tzc8vxOtGP8gj7BKspQwFcU7oabhPbZOF4a3 L4EItPV3I4I8FKlxXWQiZJVqyD33JAtlUHOz5lcQecYbwR2rPr/nmbQ4TrKl80xV RDvV/sE1ppjfbn7eq884jM5Jctgj0B1qci+a2GibHEKSprUafJzos32CTNaYDO38 iP8/ZzrOuH5Pq+/Uq3qPWFE1rhDwE2xk9ir34S7XLTiV7MH8YudyYyIv49qPVnYH iwulJsIGRA== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=none (no signatures found); dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=telka.sk; iprev=pass smtp.remote-ip=185.14.234.118 (tortuga.telka.sk); spf=pass smtp.mailfrom=marcel@telka.sk smtp.helo=tortuga.telka.sk; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=tortuga.telka.sk policy.ptr=tortuga.telka.sk; x-return-mx=pass header.domain=telka.sk policy.is_org=yes (MX Records found: tortuga.telka.sk); x-return-mx=pass smtp.domain=telka.sk policy.is_org=yes (MX Records found: tortuga.telka.sk); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=none (no signatures found); dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=telka.sk; iprev=pass smtp.remote-ip=185.14.234.118 (tortuga.telka.sk); spf=pass smtp.mailfrom=marcel@telka.sk smtp.helo=tortuga.telka.sk; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=tortuga.telka.sk policy.ptr=tortuga.telka.sk; x-return-mx=pass header.domain=telka.sk policy.is_org=yes (MX Records found: tortuga.telka.sk); x-return-mx=pass smtp.domain=telka.sk policy.is_org=yes (MX Records found: tortuga.telka.sk); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrjedugddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfh rhhomhepofgrrhgtvghlucfvvghlkhgruceomhgrrhgtvghlsehtvghlkhgrrdhskheqne cuggftrfgrthhtvghrnhepvdduueetieetueevfeduiefgtedvvdeggeduueetgeeiteeh uddtleehudeludetnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgpdhtvghlkhgrrd hskhenucfkphepudekhedrudegrddvfeegrdduudeknecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehinhgvthepudekhedrudegrddvfeegrdduudekpdhhvghlohepth horhhtuhhgrgdrthgvlhhkrgdrshhkpdhmrghilhhfrhhomhepoehmrghrtggvlhesthgv lhhkrgdrshhkqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvhgvlhhoph gvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (telka.sk: 185.14.234.118 is authorized to use 'marcel@telka.sk' in 'mfrom' identity (mechanism 'ip4:185.14.234.118' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="marcel@telka.sk"; helo=tortuga.telka.sk; client-ip=185.14.234.118 Received: from tortuga.telka.sk (tortuga.telka.sk [185.14.234.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Sun, 28 Jul 2024 19:16:32 -0400 (EDT) (envelope-from marcel@telka.sk) Received: (qmail 25430 invoked from network); 28 Jul 2024 23:16:27 -0000 Received: from telcontar.in.telka.sk (HELO telcontar) (marcel@10.0.0.10) by tortuga.telka.sk with ESMTPSA (DHE-RSA-AES256-GCM-SHA384 encrypted); 28 Jul 2024 23:16:27 -0000 Date: Mon, 29 Jul 2024 01:16:26 +0200 From: Marcel Telka To: illumos-developer Subject: Re: [developer] CPU usage - clock related issue Message-ID: References: <4d9797a5-b68c-4c50-9a13-66a9d0d63bd0@fingolfin.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 72a65ea4-4d37-11ef-bab5-428f048c7b06 On Sun, Jul 28, 2024 at 10:50:40AM -0700, Robert Mustacchi wrote: > I've root caused this and written it up in > https://www.illumos.org/issues/16683. The short form is that I > incorrectly handled how the default initializer set the internal clock > id in the cond_t. I have verified that nwam no longer is in a 100% loop > with the fix in place and confirmed that if I used static initializers > that my tests properly caught the issue before the fix and it is working > afterwards. I'll be sending a review request with additional regression > tests in a separate thread. Thanks a lot for very fast root causing and the fix. Lookig forward to see it integrated soon. Thank you for your hard and extremely valuable work, Robert! -- +-------------------------------------------+ | Marcel Telka e-mail: marcel@telka.sk | | homepage: http://telka.sk/ | +-------------------------------------------+