From: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
To: developer@lists.illumos.org
Subject: Review: 16746 asy: improve PCI(e) device support
Date: Tue, 3 Sep 2024 13:02:02 +0200 [thread overview]
Message-ID: <ZtbsqnjTb6pIsJOZ@grumpf.hope-2000.org> (raw)
Hi,
please review this change to asy(4D):
https://code.illumos.org/c/illumos-gate/+/3660
https://www.illumos.org/issues/16746
This is the first of three patches to make asy(4D) usable on modern PCIe
UART chips. It attaches asy(4D) to the correct PCI device class and
allows it to work on PCIe devices instead of PCI only.
I didn't want to outright rip out the few bits of code in there that
deal with the quirks of a particular PCI modem chipset, the only PCI
device supported by asy(4D) to this date, but I had to rewrite them so
they don't affect any other PCI(e) devices.
As that stuff is completely untested and pretty much untestable for me
apart from verifying it doesn't break other devices, and since I don't
believe anyone has been using this kind of hardware in the past two
decades or is likely to do so in the foreseeable future, I can be very
easily persuaded to just garbage-collect that old cruft, just as I did
with the code dealing with the same quirks of the same chipset on a ISA
bus.
Thanks,
Hans
--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown
reply other threads:[~2024-09-03 11:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtbsqnjTb6pIsJOZ@grumpf.hope-2000.org \
--to=rosenfeld@grumpf.hope-2000.org \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).