From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id A84BF2498525 for ; Tue, 3 Sep 2024 07:02:05 -0400 (EDT) (envelope-from rosenfeld@grumpf.hope-2000.org) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id F97406F2A9C; Tue, 3 Sep 2024 07:02:05 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1725361325; b=JR/PzbR12pDZ5/XSNZelZqiF+S8oPwrTpdONoI61ooXXfzKeQT 8CRwcu+NjrS81CZVPogCKTV9IFup58yagItmW2IR50Ilp4XbTjiYEDa7slowx0Nu jtJ5vwX2bHcvMHQx6Ysgt0+f+UFATOTj7bMHyrHPP2eO15lIrJP/yB32DhS0uDJU CAgCNxLyIP2NPlo/3OTBuUEg/kOlM71vVtSK0tB22pPnGV9UNrATpM0rHMVyliao c0Ory32P67ZDquL09QDzKVjo6EFqmuY4j0toAzJfmtSLiW8pckAGSCe4vl325kXG djpkCmps1ahI3nNd3M2i1FCuNE2N5msu0dHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1725361325; bh=FuKbvQwjXymWLyxR0qG65 PCkDKZJQEtUO4ESDPtfDuc=; b=BUdkltx/lcWgZFaKwYl3Iow4cfuxWNzCSFG2A t6VNmdAdd/0CvsRXfz/Go8gY93REAnAOt+r4IagYyRhZ+A8/YMkHyLg8t2+kn+vJ riG2DBwzfzVjZ6uyOuNDes4FXdCjjbk8pgyoFksONX8T2yQvFTeuZVBaZ78XByiW QP5VpvhOqNFtcG903w2kvX8OKfPbKbPIoNeTtcYmphTOWDsppqQj8+o2NPVkPkNv lzm1CGSjFBo4/AxGqnNYIkuSrdNDSYrMmybNdronEUz6g1uA5JbykwwBT9PwzuxT +Lq3pJG++htw9Xezk4cc4NP1kHUV45MV5pAgjF7C16PlM5Quw== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=none (no signatures found); dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=grumpf.hope-2000.org; iprev=pass smtp.remote-ip=78.46.35.119 (smtp.hope-2000.org); spf=pass smtp.mailfrom=rosenfeld@grumpf.hope-2000.org smtp.helo=smtp.hope-2000.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=smtp.hope-2000.org policy.ptr=smtp.hope-2000.org; x-return-mx=pass header.domain=grumpf.hope-2000.org policy.org_domain=hope-2000.org policy.is_org=no (MX Records found: smtp.hope-2000.org); x-return-mx=pass smtp.domain=grumpf.hope-2000.org policy.org_domain=hope-2000.org policy.is_org=no (MX Records found: smtp.hope-2000.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=none (no signatures found); dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=grumpf.hope-2000.org; iprev=pass smtp.remote-ip=78.46.35.119 (smtp.hope-2000.org); spf=pass smtp.mailfrom=rosenfeld@grumpf.hope-2000.org smtp.helo=smtp.hope-2000.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=smtp.hope-2000.org policy.ptr=smtp.hope-2000.org; x-return-mx=pass header.domain=grumpf.hope-2000.org policy.org_domain=hope-2000.org policy.is_org=no (MX Records found: smtp.hope-2000.org); x-return-mx=pass smtp.domain=grumpf.hope-2000.org policy.org_domain=hope-2000.org policy.is_org=no (MX Records found: smtp.hope-2000.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehhedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuf fkgggtugesthdtredttddtvdenucfhrhhomhepjfgrnhhsucftohhsvghnfhgvlhguuceo rhhoshgvnhhfvghlugesghhruhhmphhfrdhhohhpvgdqvddttddtrdhorhhgqeenucggtf frrghtthgvrhhnpefftddvhedukeejudduleefgfefvdehtdfhhfejudevuddvgffghffg ffekgefhhfenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepjeekrdegie drfeehrdduudelpddvrgdtudemgehfkeemvddvudemfhgvtddtmedvvdegmegujehffhem fhgvudehmeekudejtgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvg htpeejkedrgeeirdefhedrudduledphhgvlhhopehsmhhtphdrhhhophgvqddvtddttddr ohhrghdpmhgrihhlfhhrohhmpeeorhhoshgvnhhfvghlugesghhruhhmphhfrdhhohhpvg dqvddttddtrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvhgv lhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (grumpf.hope-2000.org: 78.46.35.119 is authorized to use 'rosenfeld@grumpf.hope-2000.org' in 'mfrom' identity (mechanism 'mx' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="rosenfeld@grumpf.hope-2000.org"; helo=smtp.hope-2000.org; client-ip=78.46.35.119 Received: from smtp.hope-2000.org (smtp.hope-2000.org [78.46.35.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Tue, 3 Sep 2024 07:02:04 -0400 (EDT) (envelope-from rosenfeld@grumpf.hope-2000.org) Received: from executor.headcrashers.org (executor.headcrashers.org [IPv6:2a01:4f8:221:fe00:224:d7ff:fe15:817c]) (authenticated bits=0) by smtp.hope-2000.org (8.18.1/8.18.1) with ESMTPSA id 483B225Z013634 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Tue, 3 Sep 2024 13:02:03 +0200 (CEST) Received: from executor.headcrashers.org (executor.local [127.0.0.1]) by executor.headcrashers.org (8.18.1+Sun/8.18.1) with ESMTP id 483B22iF020666 for ; Tue, 3 Sep 2024 13:02:02 +0200 (CEST) Received: (from woodstoc@localhost) by executor.headcrashers.org (8.18.1+Sun/8.18.1/Submit) id 483B22Lg020665 for developer@lists.illumos.org; Tue, 3 Sep 2024 13:02:02 +0200 (CEST) Date: Tue, 3 Sep 2024 13:02:02 +0200 From: Hans Rosenfeld To: developer@lists.illumos.org Subject: Review: 16746 asy: improve PCI(e) device support Message-ID: Mail-Followup-To: developer@lists.illumos.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: fa151fb0-69e3-11ef-ac31-2cc6fd8b7b06 Hi, please review this change to asy(4D): https://code.illumos.org/c/illumos-gate/+/3660 https://www.illumos.org/issues/16746 This is the first of three patches to make asy(4D) usable on modern PCIe UART chips. It attaches asy(4D) to the correct PCI device class and allows it to work on PCIe devices instead of PCI only. I didn't want to outright rip out the few bits of code in there that deal with the quirks of a particular PCI modem chipset, the only PCI device supported by asy(4D) to this date, but I had to rewrite them so they don't affect any other PCI(e) devices. As that stuff is completely untested and pretty much untestable for me apart from verifying it doesn't break other devices, and since I don't believe anyone has been using this kind of hardware in the past two decades or is likely to do so in the foreseeable future, I can be very easily persuaded to just garbage-collect that old cruft, just as I did with the code dealing with the same quirks of the same chipset on a ISA bus. Thanks, Hans -- %SYSTEM-F-ANARCHISM, The operating system has been overthrown