From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob0.topicbox.com (tb-ob0.topicbox.com [64.147.108.117]) by inbox.vuxu.org (Postfix) with ESMTP id E802F24287 for ; Sat, 19 Oct 2024 21:00:40 +0200 (CEST) Received: from tb-mx0.topicbox.com (tb-mx0.nyi.icgroup.com [10.90.30.73]) by tb-ob0.topicbox.com (Postfix) with ESMTP id EF1BD19E92 for ; Sat, 19 Oct 2024 15:00:39 -0400 (EDT) (envelope-from bounce.mM0cdefe608f1f4d20bd381f93.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx0.topicbox.com (Postfix, from userid 1132) id EB0785A3DD; Sat, 19 Oct 2024 15:00:39 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=hVXxzdD5 header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:content-type :content-transfer-encoding:list-help:list-id:list-post :list-subscribe:reply-to:subject:from:list-unsubscribe; s= sysmsg-1; t=1729364439; bh=/Rt1hXpppAVJ27XuNTm1eKu6co8yUyZ+cyEvI 7eDv6Q=; b=ex2G3t0+xjJlkV1pT222N4l9+M+bPOWrBR+zgi1AA+mYrd+t5Nv64 HGFslcjnrxyuGrr93o305a6VwWYcPeTAfS46QNL7uZWpJvfoUV+ij+yGbtPB05bN hlMcVjOKg24PLFZZqRe3/75y3Mqcc6triM3toulULFRBQIsQq9J0Jc= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1729364439; b=EmAbA+969cpJkrtpV5hTA08wsamv4dFxlBmpwg7dxF02ERKxjp yq4Fc4ZEiYzk9mDxcZsXnykKdodWUkSKHtUBPz7yBLSwY2EbkuBWwJjB7r8CM2UV 3uGtR4SmnTJisitwHqXNUl6Wfq1D0Xl4LGZI4GvBFJd30uXhjcI4E1UcY= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=hVXxzdD5 header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: the-governor.hamachi.org; auth=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=hVXxzdD5 header.a=rsa-sha256 header.s=hamachi-202410; x-aligned-from=pass (Address match); x-local-user=pass; x-spam=pass score=-2.00 required=5.00 X-Received-Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=hVXxzdD5 header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= message-id:date:mime-version:to:content-type :content-transfer-encoding:list-help:list-id:list-post :list-subscribe:reply-to:subject:from:list-unsubscribe; s= dkim-1; t=1729364439; x=1729450839; bh=FJSZIbQyBpM+l1q/lcCQ0aGxX bxtElnJbbtPkIXyla4=; b=BVEEjAh1iOT68g+G7mr6IzlTUdz5ERtdM/7KAF2xe F+EcbOfH4QBivGH3RpsLzUah0xU1uMmZk1RmolDylW1lmDYGtekcAcQKuCBS7D1g Hjo+C71VRBm9k5ez35qUO0cn8JQfd1SzvyEbyXbEK4IMnqSEffaFwIM5kR24NwpT rg= Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id F401459DA7 for ; Sat, 19 Oct 2024 14:58:45 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id C65F4459B58; Sat, 19 Oct 2024 14:58:45 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1729364325; b=b6pT8bs8nj7czU+N7jeHBj7/IJheSuf97XvnpvBtm5DAlzYBR4 qTtuFAG5OdFgoljsY8KibkWP8PB4kwdmmgAvB1CQfkkH6uyVvhlEnyC5ecyDvdLV Llon9+TGLh7lc1zTSTQ7cixhT2c4zjFm/6Ptpkv74RNkq9MV2a0mFnnCGVSL3p/X ozQDM6C1pWz3qLvIqTf4M6MV3+BiGoJxWPahAWa0NOc4fdtOd56ayA4PI0kmqF2u JbQicc44ahgQRZtvtcHN+doC4ARvs8PWHIFPu64cfTSC67jFu47w81yaISZqpuEL lyvovhE0nskYxaBtNCCPVYzEtdg1UXXR4few== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:subject:from :content-type:content-transfer-encoding; s=arcseal; t= 1729364325; bh=o8TppD1BJ/OYlasXYSNf7D695SLxpNx/TdNvUz/eCpg=; b=u YBtoIllRZp0nuh3czSRwvctIhvLtMBbpGNmDytJroOIpprPnGGVSVcUDe5XcAScy nzhBavbm5gWh+6fTvlntsnwUnZ5H+wDtIWjG4u+Ens65YyEY+EZ72qQ7LcAZCUE/ /1Xb+dZyw1EfmLsjwHO/1l9UKzmT+qBC0Q4rayecl8kI0J2Ns2Yp6gfbqNh2hBkU 5fGWfuHlEm0wSgONg67AfxBpe8v6WwOtUnN0NLkMWYvbmL6zfUfUgQhgoLi3/mQy 0+icAskaVIMHEc+G7O/vB7vL7e9M986SmaVuvjf2bulNueZ+q2Rjgev0t4bPMVYi yKGTkem51+dh7hkdZhWeQ== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=hVXxzdD5 header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehhedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgg gfvffuhfgtgfesthejredttddvjeenucfhrhhomhepuehilhhlucfuohhmmhgvrhhfvghl ugcuoehsohhmmhgvrhhfvghlugeshhgrmhgrtghhihdrohhrgheqnecuggftrfgrthhtvg hrnhepuedukeeuieeuheeiieduleekteevleeifeegudehtefhueffhfduledugfeugfeu necuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppedujeefrdduuddrleegrd dvvdehpddviedtfeemfedtvdegmegvtdehmegrsgdttdemmeefnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehinhgvthepudejfedruddurdelgedrvddvhedphhgvlh hopehthhgvqdhgohhvvghrnhhorhdrhhgrmhgrtghhihdrohhrghdpmhgrihhlfhhrohhm peeoshhomhhmvghrfhgvlhgusehhrghmrggthhhirdhorhhgqedpnhgspghrtghpthhtoh epuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhumhhoshdr ohhrgheq X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (hamachi.org: 173.11.94.225 is authorized to use 'sommerfeld@hamachi.org' in 'mfrom' identity (mechanism 'mx' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="sommerfeld@hamachi.org"; helo=the-governor.hamachi.org; client-ip=173.11.94.225 Received: from the-governor.hamachi.org (the-governor.hamachi.org [173.11.94.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Sat, 19 Oct 2024 14:58:45 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from [IPV6:2603:3024:e05:ab00::3] (hydra.hamachi.org [IPv6:2603:3024:e05:ab00::3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sommerfeld) by the-governor.hamachi.org (Postfix) with ESMTPSA id 989B25EFC; Sat, 19 Oct 2024 11:58:42 -0700 (PDT) Message-ID: Date: Sat, 19 Oct 2024 11:58:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: developer@lists.illumos.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 2da51d4e-8e4c-11ef-b51b-57fbfb8b7b06 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UOWQyZDI3ODE4NDc2NDYzMi1NMGNkZWZlNjA4ZjFmNGQy?= =?UTF-8?B?MGJkMzgxZjkzPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Subject: [developer] [REVIEW] 16841 in.ndpd sometimes loses interface id on restart From: "Bill Sommerfeld via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:M0cdefe608f1f4d20bd381f93:1:J_KdeNpQbjx08Uz_ri5j7HLqXCaVxDPi2ppdSbUvdt4 Issue: https://www.illumos.org/issues/16841 CR: https://code.illumos.org/c/illumos-gate/+/3741 Diff:=20 https://code.illumos.org/~diff/9ccc0daeed048cc5d86a311d9b68fb6bccb01479 The low order 64 bits of IPv6 unicast addresses come from an interface identifier which is, by default, derived from the interface's MAC address. The "ipadm create-addr -T autoconf" command lets you specify an alternate value for the interface identifier, but it turns out that if you use this option, in.ndpd will sometimes ignore it and use the default, leading to unstable ipv6 addresses. I've been using this configuration for a few years and have been bothered with the instability. I believe I've finally found the cause and have a fix. There are multiple paths to creating a "struct phyint" inside in.ndpd, and there were inconsistancies in what they did and how they set the interface id-related fields of the "struct phyint". There are two parts to the change: 1) phyint_check_ipadm_intfid() was only called if the "struct phyint" was newly created in if_process(); if it was created earlier (for instance, if it was mentioned by name in ndpd.conf), ndpd wouldn't use the configured interface id in newly-created addresses. 2) When an address is set up by ndpd_create_addrs() with a configured interface id, the "pi->pi_default_token" boolean is cleared, but when phyint_check_ipadm_intfid() is called, pi->pi_default_token is left unchanged. If pi->pi_default_token is left set, the interface id will be overwritten the next time phyint_init_from_k() is called. I'd like to thank Andy Fiddaman for creating and integrating the link-local test in https://www.illumos.org/issues/16251; it turned out to be a reliable way to provoke address instability. Thanks in advance for your review. - Bill ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/T9d2d278184764632-= M0cdefe608f1f4d20bd381f93 Delivery options: https://illumos.topicbox.com/groups/developer/subscription