From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id AFA7B1E1DC47 for ; Fri, 26 Jul 2024 09:50:07 -0400 (EDT) (envelope-from prvs=1937796681=andy@omnios.org) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id ED35729F676; Fri, 26 Jul 2024 09:50:07 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1722001807; b=nE16N+nWBXcztoSdSA+ZhVVKASoKjEN0eb5Smwn/AC9NFN/VM/ lrIZjBcGyJu3uP2fHthwbj4zAAFJ7mPXKPFBbFgDhXLJa6Smiu983tj/Vw0hxiRl BrHedNhTu4J8dJRbeu0r6Xc4WArh5LVhWYYNBaXgmKVVIZ796vP5qQQR7Ma94PoX MusvEqch7sNjo5kvdhIVMb1gqt3M9fVCa4zAFXeARPjKu+SyZU+ELULxFkd35aUm +tiErMF04HMybATYq7N55LEwHYg6vxcDVrqZoObRJH1nKK2fAxSnfgfWs2YuJ1r2 5uDWlKyzMHrWyQjupdCCshojLl6OfLzPulqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:in-reply-to:message-id :references:mime-version:content-type; s=arcseal; t=1722001807; bh=tT+h+hSuLE1HXvahqakLYN4FTj/JgRxfI7ygrucel8A=; b=jxWZIhtmqicg K7Tbt0Xrtbk9rWOsHQ3ZunDR4rJTqaGRVE2YhR9PlipJ32okUS10vfwHK5bF+w7t Qccq76QjIphmO8IBt7sFFpvNaL6I4B8ivSyXFhakD0J3nk1BvteVGM+2UAM4SKP2 b2fcP4n4W1y5GqAg6RLjBcZxnw8Rgop3MjGwnHXR5MdbYIsz3tKOz0lUQdcpf4Pp 3Dquk1foIwco5wDv7IU7F8HyQnso0iNurTNJJmgDhNxSwDCqjFuWCr/NslLlJgyc mrc8/ff6DldFhTaypXWEEruetEixNYHeG1iw+uzYs3FqhrWv/LI1OiDbt84Qn9em 9VuPOBdotw== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=omnios.org header.i=@omnios.org header.b=OGVOma7u header.a=rsa-sha256 header.s=omnios202205 x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=omnios.org; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=none smtp.mailfrom="prvs=1937796681=andy@omnios.org" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=omnios.org policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=omnios.org policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=omnios.org header.i=@omnios.org header.b=OGVOma7u header.a=rsa-sha256 header.s=omnios202205 x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=omnios.org; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=none smtp.mailfrom="prvs=1937796681=andy@omnios.org" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=omnios.org policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=omnios.org policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrieehgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvufgjkfhfgggtsehttdertddttddvnecuhfhr ohhmpeetnhguhicuhfhiuggurghmrghnuceorghnugihsehomhhnihhoshdrohhrgheqne cuggftrfgrthhtvghrnhepjefhieekuddtkeelgfehffeuteeukeffieefteegjedutdfh ueehffffveeifedvnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppeekle drvdegkedrheehrddutdefpdekledrvdegkedrheehrdejleenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepihhnvghtpeekledrvdegkedrheehrddutdefpdhhvghloh epmhgrihhlrdgtihhtrhhushdqihhtrdhnvghtpdhmrghilhhfrhhomhepoehprhhvshep udelfeejjeelieeikedupegrnhguhiesohhmnhhiohhsrdhorhhgqedpnhgspghrtghpth htohepuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhumhho shdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: none (omnios.org: No applicable sender policy available) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="prvs=1937796681=andy@omnios.org"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Fri, 26 Jul 2024 09:50:06 -0400 (EDT) (envelope-from prvs=1937796681=andy@omnios.org) Authentication-Results: citrusmail; dkim=pass header.i=@omnios.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=omnios.org; s=omnios202205; t=1722001804; bh=61dHvAXGMeGmEp7iqV5w4sStXUnXpcC0dbP6sJZyNOg=; h=Date:From:To:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=OGVOma7u6wDOoGhVMX2tayf5J782lq8GErDhXcjsRhUTbCpMLWDmIk2zuB84bTKnn 1xulS/gcbHyE4R87gPBozHlucI2zufzIKH6lv2sliyz1m6J6TH9rXUQut8QmAIPGv4 MEgNONYb0BFygEdr3V/RmMeW1ALT3HZIPu2Ia4rA= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 46QDo41I008755 for ; Fri, 26 Jul 2024 13:50:04 GMT Date: Fri, 26 Jul 2024 13:50:04 +0000 (UTC) From: Andy Fiddaman To: illumos-developer Subject: Re: [developer] Review - 15665 svc:/network/loopback exits successfully even if it fails In-Reply-To: Message-ID: References: <20240726082032.GA10040@reaper.citrus-it.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 546QDo41I008755 X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: fbaacd36-4b55-11ef-84b1-cff3d3689c0d On Fri, 26 Jul 2024, Peter Tribble wrote: > On Fri, Jul 26, 2024 at 9:21?AM Andy Fiddaman wrote: > > > Please can you review the following change? > > > > 15665 svc:/network/loopback exits successfully even if it fails > > https://www.illumos.org/issues/15665 > > https://code.illumos.org/c/illumos-gate/+/3610 > > > > When this first came up I expressed my belief that making this change is > the wrong > thing to do, and I'll express it again. Apologies Peter. I had recalled that your objection to the original change was mostly around the addition of the extra dependency to the service, which I've removed in this new patch set (that is https://www.illumos.org/issues/15664 which remains open). > If this service fails, I think the best thing to do is drive on so that the > system can come up as far as possible to maximise the chance that the system > comes up far enough for an administrator to be able to get in and fix it. Not > putting the service into maintenance is a feature, not a bug. The impetus for this change is that over the past couple of years we've had a number of occasions where we've had to debug networking problems that have had their root in the fact that the loopback interfaces were not created for one reason or another. It happened again yesterday in a non-global zone. In all of these, it would have been really useful and expedited diagnosis if the service had gone into maintenance. I understand the perspective of allowing the system to come up as far as possible - to the point of remote access even - but it still seems wrong for a service to report success where it has not actually achieved its goal. Is there some middle ground here. > I think generally it would be wrong for a single voice to veto any change, > which means I would generally be uncomfortable sticking a -1 on it, but if > this does get into the gate it will be reverted in Tribblix. Understood. This definitely warrants further discussion. Andy