From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.listbox.com (lb-mx3.nyi.icgroup.com [10.90.30.80]) by arc2.listbox.com (Postfix) with ESMTP id 6574C1AA2F for ; Tue, 21 Jun 2016 19:50:46 -0400 (EDT) Received: from lb-mx3.nyi.icgroup.com (localhost [127.0.0.1]) by mx3.listbox.com (Postfix) with ESMTP id 62ED4144F9 for ; Tue, 21 Jun 2016 19:50:46 -0400 (EDT) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by mx3.listbox.com (Postfix) with ESMTPS id 8D2AF144F8 for ; Tue, 21 Jun 2016 19:50:43 -0400 (EDT) Received: by mail-pa0-f41.google.com with SMTP id hl6so10717223pac.2 for ; Tue, 21 Jun 2016 16:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joyent.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=+7zRkFRyNTGQDnpRxTyqbTBVOfOmpGYqDhVFkgceLSo=; b=EZEG1lBA15e0YqsYM/PBSS60hAYe75L4CGKvPU0l/xBWjwcmyxRzmzqzbTK9JAVu/8 d6a/fiWPl3wFNGZjUl1ywqoTjgzhyXh7c8Qivy0ctRpPjZ1PqulSQDK43wRaR8tK4fql cKDwmalXZ7qbuDFH90lVLYvFulBmYRfFZBgFk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=+7zRkFRyNTGQDnpRxTyqbTBVOfOmpGYqDhVFkgceLSo=; b=ky8ViMGX0luD00USvpjVrORe/MshyiGK7LiA0oe26PDHNFXQjfRGLaKH7NI5W4or6L Bb17R0A++5WY65/lK2Xak5tPxsDati8A2oU3qFWIxLL5QQmq7CQT4nW2zYTfDHaWXkQt 9xxw1Ixsajmgahx1h0uevyurVCVdhPGTWtmoyXOJfQq59Uu9euDjkDIPUnXGA8LxFySM 0gAhchrkC3+cMiNXXpJLpSiTdV/W0gpYHI0MksV21ldju3iqeKBYzdPShVQWlxyF4Ibl 11RJ8aaxlSDetbjMKC8dTOEcMCqNOeTDQC+mmKi3d34m9ZsFiHvIquTIZp3UYi90pgVN nfhw== X-Gm-Message-State: ALyK8tJQ5eWVpIAsXXlKJaDxdykU14wyovZE4OULeOdkNCmbF931q+NhWBkDshm4m0Mgpxd0 X-Received: by 10.66.132.72 with SMTP id os8mr30980575pab.63.1466553042468; Tue, 21 Jun 2016 16:50:42 -0700 (PDT) Received: from zanarkand.local ([208.184.5.170]) by smtp.gmail.com with ESMTPSA id f2sm13373961pfb.76.2016.06.21.16.50.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 16:50:41 -0700 (PDT) Subject: Re: [developer] [REVIEW] (again) 5713, 5714, 5715 updates to share man pages To: Yuri Pankov , illumos-developer References: <29706517-0a76-1565-2cf2-b054edf56813@nexenta.com> From: Robert Mustacchi Message-ID: Date: Tue, 21 Jun 2016 16:50:41 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <29706517-0a76-1565-2cf2-b054edf56813@nexenta.com> Content-Type: text/plain; charset=utf-8 content-transfer-encoding: quoted-printable Listbox-Message-Date: 2016-06-21T23:50:48Z Topicbox-Message-UUID: f8c6b2e0-380a-11e6-914b-df12146458cf On 6/19/16 7:38 , Yuri Pankov wrote: > issue: https://www.illumos.org/issues/5713 > issue: https://www.illumos.org/issues/5714 > issue: https://www.illumos.org/issues/5715 > webrev: http://www.xvoid.org/illumos/webrev/il-man-share/ >=20 > The changes are tied together thus one webrev. >=20 > - remove NFS/SMB options and access_list description from sharemgr(1M) > - remove access_list description from share_nfs(1M) > - add share_smb(1M) describing SMB options > - add shareacl(4) describing access_list format I started going through this and I'm a bit confused. Your sharemgr(1M) in sdiffs doesn't look anything like the one currently in the gate. What was this built against? I have more specific comments below: man/man1m/sharemgr.1m: I get that you're trying to consolidate information here that used to be here, but you need to give the user some kidn of hint of where to look. You've removed all the content and there's not even a See Also. In general, I'd expect there to be at least something like you had in the share_nfs(1M) changes. man/man1m/share_smb.1m: Note line numbers correspond to the raw manual page. - In general I find the description a little confusing. The mount manual pages separate out the distinction between the core mount binary doing things and for example, what mount_nfs does. I get that share is what ultimately from a user perspective does this, but it's not that all invocations of share do this. Maybe change things here to say that it's share_smb that starts this in a similar fashion to mount_nfs(1M). - What are valid strings for the cksumlist argument to the cksum option? +40: This should be .Sh, not .Ss in our manual page conventions. +196, +202, +206: Presumably these should all include the reference that the format is in shareacl(4) like the share_nfs page does. Robert