Re: [developer] Review: 13918 Want kernel test facility (IPD 20)

[Robert Mustacchi <rm@fingolfin.org>]

On 2/4/24 20:03, Ryan Zezeski wrote:
> 
> I am once again asking for review. I've rebased, rebuilt, and retested.
> I took a hiatus for a while, but I'm thinking I'm back. I'd like to start
> by getting this across the finish line.
> 
> https://code.illumos.org/c/illumos-gate/+/1585
> 
> I also believe I still need someone to officially sponsor the IPD.
> 
> https://github.com/illumos/ipd/blob/master/ipd/0020/README.adoc

I'm happy to sponsor it and will follow up on that.

Robert

> Ryan Zezeski <ryan@zinascii.com> writes:
> 
>> Almost two years later and I finally got around to addressing CR. I am
>> sorry for such an extreme delay.
>>
>> Coming back to this with fresh eyes gave me a new perspective on some
>> aspects of the implementation. I think it's now a bit simpler. I also
>> added man pages for the command and kernel APIs. I have a more thorough
>> list in the CR comments. Speaking of the CR, given the length of time
>> between updates the diff view seems very confused if you diff patchset
>> #1 and #3. I'm happy to create an entirely new CR if that's desired.
>>
>> There's certainly still rough spots in places, but I thought that's
>> where the list could help me out. I'd like to get the initial version in
>> that is "good enough" so that this is no longer something just sitting
>> on a branch and others can improve on it without waiting for my slow
>> ass.
>>
>> I also updated the IPD to reflect the changes I've made in the
>> implementation.
>>
>> CR: https://code.illumos.org/c/illumos-gate/+/1585
>> Ticket: https://www.illumos.org/issues/13918
>> IPD: https://github.com/illumos/ipd/blob/master/ipd/0020/README.adoc
>>
>> -Ryan
>>
>> Ryan Zezeski <ryan@zinascii.com> writes:
>>
>>> I would appreciate anyone who can look at my proposed implementation of
>>> the Kernel Test Facility (aka ktest), as described in IPD 20. I would
>>> have liked to include more tests out of the gate, but honestly I think
>>> this chunk of work is already large enough as it is, and there are those
>>> who would have made use of ktest a year ago had it been ready. I also
>>> left a few TODOs in there, all of which I feel would be best done as
>>> follow-up changes.
>>>
>>> CR: https://code.illumos.org/c/illumos-gate/+/1585
>>> Ticket: https://www.illumos.org/issues/13918
>>> IPD: https://github.com/illumos/ipd/blob/master/ipd/0020/README.adoc
>>>
>>> -Ryan
> 
> ------------------------------------------
> illumos: illumos-developer
> Permalink: https://illumos.topicbox.com/groups/developer/T95078dcc9ecf4b91-Me6ea8b7a0f822e78e3e6a5ca
> Delivery options: https://illumos.topicbox.com/groups/developer/subscription