From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 70B28D9A0C9 for ; Fri, 24 Feb 2023 12:26:02 -0500 (EST) (envelope-from ryan@zinascii.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id E9F8D7CB9FD; Fri, 24 Feb 2023 12:26:02 -0500 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1677259562; b=QhkJykRxE8w5tvpBfUmeLG2Nk668BFrj/akYlIER0uZ2YydLox hrA/PN4SZO1YYA/V5rqG1j9xme0dCJyep0xquw/aZU4IE4hxWjBZauqjADCP5P0p iLzxgf7yIVuaxCyFlA4Vag9vIfajNXF6jWuAYV9OHXzKdcI2pdS3WcvbaoBcmEUj jXd3QN8EVcfzLrgg43Q4h8i7cBTY5Tlpti7WWYFQ5GY+VjQvB6Qi186pio4OLBRG ii2hFzxBQCi/tYZx84LOj13lj4eGav9q2Yd4LlfcEx4mwIoN5qGWVRVVuT+3QQG4 dZvBjpMx60d+E/REfoSmwtjAbRCJIsQqdjXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=arcseal; t=1677259562; bh=YxZ85txAHDa0XSHrhY5Sn16kDiqaw9ZZwoaasUwg3rI=; b=QlOqnIOeQc0C VidRiy87LgGulUMuwUnSh6fB0ONMurViuT5T2W1umVbcW4oFlraKVSFKCZ9jfuq3 DXPwOaHrijIAiLUd4arzpAUYzRW5kQQyGlT3Lm3ETZz/MQi3O2wm/QwhXHJtOyxb pWxwz1/DCWsnMbT0ZFoePFeUbH9UuGdo1Mj3O2b6TAmMFFLgq7i41WfLQxS8BOFp jpNbcF0hzilqn81M7EztOCcogyjn/p69gpEU759kn0qOC2QWm5ckRe4/C3vNW3YG Nlf6BeYtJTlMaxXlhXkFL5u3rqg6cxA+qc2j/tTKYOPS7Ze/Bs0cFw5WjQOw9pjd EeowcKMMAw== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (2048-bit rsa key sha256) header.d=messagingengine.com header.i=@messagingengine.com header.b=kFgD1bes header.a=rsa-sha256 header.s=fm1 x-bits=2048; dkim=pass (2048-bit rsa key sha256) header.d=zinascii.com header.i=@zinascii.com header.b=XW52UaWC header.a=rsa-sha256 header.s=fm1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=zinascii.com; iprev=pass smtp.remote-ip=66.111.4.29 (out5-smtp.messagingengine.com); spf=pass smtp.mailfrom=ryan@zinascii.com smtp.helo=out5-smtp.messagingengine.com; x-aligned-from=pass (Address match); x-me-sender=pass policy.xms= KvP4Y1_gLt0Le2ILNbAaaTVAZzkL9uYf7N8G8V1BmRAARynhUjcjhNk5ZlR9gyE8NFAdja9jScDgMFLO6SEvG9dbIadci7JsnwIXbPLLq4DZqlz77awb4WThwI2AKAyyufTteD7HPiAU5Q; x-ptr=pass smtp.helo=out5-smtp.messagingengine.com policy.ptr=out5-smtp.messagingengine.com; x-return-mx=pass header.domain=zinascii.com policy.is_org=yes (MX Records found: in2-smtp.messagingengine.com,in1-smtp.messagingengine.com); x-return-mx=pass smtp.domain=zinascii.com policy.is_org=yes (MX Records found: in2-smtp.messagingengine.com,in1-smtp.messagingengine.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (2048-bit rsa key sha256) header.d=messagingengine.com header.i=@messagingengine.com header.b=kFgD1bes header.a=rsa-sha256 header.s=fm1 x-bits=2048; dkim=pass (2048-bit rsa key sha256) header.d=zinascii.com header.i=@zinascii.com header.b=XW52UaWC header.a=rsa-sha256 header.s=fm1 x-bits=2048; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=zinascii.com; iprev=pass smtp.remote-ip=66.111.4.29 (out5-smtp.messagingengine.com); spf=pass smtp.mailfrom=ryan@zinascii.com smtp.helo=out5-smtp.messagingengine.com; x-aligned-from=pass (Address match); x-me-sender=pass policy.xms= KvP4Y1_gLt0Le2ILNbAaaTVAZzkL9uYf7N8G8V1BmRAARynhUjcjhNk5ZlR9gyE8NFAdja9jScDgMFLO6SEvG9dbIadci7JsnwIXbPLLq4DZqlz77awb4WThwI2AKAyyufTteD7HPiAU5Q; x-ptr=pass smtp.helo=out5-smtp.messagingengine.com policy.ptr=out5-smtp.messagingengine.com; x-return-mx=pass header.domain=zinascii.com policy.is_org=yes (MX Records found: in2-smtp.messagingengine.com,in1-smtp.messagingengine.com); x-return-mx=pass smtp.domain=zinascii.com policy.is_org=yes (MX Records found: in2-smtp.messagingengine.com,in1-smtp.messagingengine.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekfedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecu hfhrohhmpefthigrnhcukggviigvshhkihcuoehrhigrnhesiihinhgrshgtihhirdgtoh hmqeenucggtffrrghtthgvrhhnpeffueehfeeivdekieeuudelvddvvdejvefgueekiedv udeludefjedugfehjeelgfenucffohhmrghinhepihhllhhumhhoshdrohhrghdpghhith hhuhgsrdgtohhmpdhtohhpihgtsghogidrtghomhenucfkphepieeirdduuddurdegrddv leenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeiiedrudduud drgedrvdelpdhhvghlohepohhuthehqdhsmhhtphdrmhgvshhsrghgihhnghgvnhhgihhn vgdrtghomhdpmhgrihhlfhhrohhmpeeorhihrghnseiiihhnrghstghiihdrtghomheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (zinascii.com: Sender is authorized to use 'ryan@zinascii.com' in 'mfrom' identity (mechanism 'include:spf.messagingengine.com' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="ryan@zinascii.com"; helo=out5-smtp.messagingengine.com; client-ip=66.111.4.29 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Fri, 24 Feb 2023 12:26:01 -0500 (EST) (envelope-from ryan@zinascii.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 34D515C00D8 for ; Fri, 24 Feb 2023 12:26:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 24 Feb 2023 12:26:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zinascii.com; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1677259561; x=1677345961; bh=YxZ85txAHD a0XSHrhY5Sn16kDiqaw9ZZwoaasUwg3rI=; b=XW52UaWCzI8KUv+Zf79OiSoVrs IdPHPwirHF/WYeZSAAJkuBBdvaryJMA5ofPVQlGJLZW+FnnopzbcjSDxLscScfNj 7jytMD6czKKVzEE4qgUN+r1gWd3DRcVFvBLLrEdi+/Lo5mr2IvoHlUS3XEKg7Sff H0BJpAyu+oth39c3Cf/Cph82z5y28wr9EVuCXUjwcaekRiGY0B6a1ALljp0veN+n n1KsKocp7OwQ0f8dSuqs/+NVrOXjASL/XMPHRNrbEG9BMSkK59gSDafxINVIjq3N GRaoTSbPYraCdZMMnxF7EcL7wEiZPywgtYBHb6Z1HS6gVJFqKbySnXyup6mQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677259561; x=1677345961; bh=YxZ85txAHDa0XSHrhY5Sn16kDiqa w9ZZwoaasUwg3rI=; b=kFgD1bes9+Mj9VbVizcWKUoeqMWTMFqG0+epCRVogp9r TeNKSfXLogS20QubDtuM4TVOYT0GdrdxguC9RpxNLNOKZGaY3LHW5W8+SF5xZkY2 aOfYFHYO/+O89z61P9PmkLthZnBI7QOVFfvdmufd2Na2zPkszg3YfreSlC4Uf+6J b/1TpfTj+1ui0M9rVbH2FJDvWHDU+UggkSUX04g2jJ9RYlMCNp2HTGrfKck+uHcB QRJ0DHV14mcrqs4zz4fa6t7NSEtrSjAwWmg+fjimpwq6PLLEssbSQHsgrhQgPJfw q6m/lfbVc9gDyggnifqzhu3r4kc7qGBzWV89gPSoWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekfedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefthigrnhcu kggviigvshhkihcuoehrhigrnhesiihinhgrshgtihhirdgtohhmqeenucggtffrrghtth gvrhhnpeffueehfeeivdekieeuudelvddvvdejvefgueekiedvudeludefjedugfehjeel gfenucffohhmrghinhepihhllhhumhhoshdrohhrghdpghhithhhuhgsrdgtohhmpdhtoh hpihgtsghogidrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehrhigrnhesiihinhgrshgtihhirdgtohhm X-ME-Proxy: Feedback-ID: ifa204097:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 24 Feb 2023 12:26:00 -0500 (EST) References: User-agent: mu4e 1.6.10; emacs 28.1 From: Ryan Zezeski To: illumos-developer Subject: Re: [developer] Review: 13918 Want kernel test facility (IPD 20) Date: Fri, 24 Feb 2023 10:18:50 -0700 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 52e4ec48-b468-11ed-9526-866c9586f1ab Almost two years later and I finally got around to addressing CR. I am sorry for such an extreme delay. Coming back to this with fresh eyes gave me a new perspective on some aspects of the implementation. I think it's now a bit simpler. I also added man pages for the command and kernel APIs. I have a more thorough list in the CR comments. Speaking of the CR, given the length of time between updates the diff view seems very confused if you diff patchset #1 and #3. I'm happy to create an entirely new CR if that's desired. There's certainly still rough spots in places, but I thought that's where the list could help me out. I'd like to get the initial version in that is "good enough" so that this is no longer something just sitting on a branch and others can improve on it without waiting for my slow ass. I also updated the IPD to reflect the changes I've made in the implementation. CR: https://code.illumos.org/c/illumos-gate/+/1585 Ticket: https://www.illumos.org/issues/13918 IPD: https://github.com/illumos/ipd/blob/master/ipd/0020/README.adoc -Ryan Ryan Zezeski writes: > I would appreciate anyone who can look at my proposed implementation of > the Kernel Test Facility (aka ktest), as described in IPD 20. I would > have liked to include more tests out of the gate, but honestly I think > this chunk of work is already large enough as it is, and there are those > who would have made use of ktest a year ago had it been ready. I also > left a few TODOs in there, all of which I feel would be best done as > follow-up changes. > > CR: https://code.illumos.org/c/illumos-gate/+/1585 > Ticket: https://www.illumos.org/issues/13918 > IPD: https://github.com/illumos/ipd/blob/master/ipd/0020/README.adoc > > -Ryan > > ------------------------------------------ > illumos: illumos-developer > Permalink: https://illumos.topicbox.com/groups/developer/T95078dcc9ecf4b91-M04f4542d95a640830ced6d9b > Delivery options: https://illumos.topicbox.com/groups/developer/subscription