Re: [developer] 16614 cxgbe: support code for cxgbetool register read/write functionality

[Ryan Zezeski <ryan@zinascii.com>]

"bharat via illumos-developer" <developer@lists.illumos.org> writes:

> Please review https://code.illumos.org/c/illumos-gate/+/3560
> These changes add register dump support to cxgbtool of cxgbe drivers.

Hi Bharat, thanks for the contribution.

I notice there are two CRs open against issue 16614. The first which you
linked in your original email, and this following one.

https://code.illumos.org/c/illumos-gate/+/3559/7

This later CR looks to add support for dumping the T6 regs, which I
believe you want to be part of the overall work for issue 16614. The
illumos project prefers to have logically related work as one commit;
that is, one commit per issue. I would roll these into one commit under
the 3560 CR. Furthermore, rather than removing the T4 regs I would also
add support for dumping T4 regs. Finally, the commit message should
match the issue title verbatim; so you'll want to change one or the
other so that they match.

Thanks,
Ryan