[discuss] bhyve core dump

[discuss] bhyve core dump

[courtney via illumos-discuss]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

I'm experiencing bhyve core dumps when I sysupgrade my OpenBSD virtual machines on SmartOS. The problem appears to be here

https://github.com/TritonDataCenter/illumos-joyent/blob/master/usr/src/cmd/bhyve/pci_virtio_viona.c#L1016-L1025

This is the log output I get in platform.log

{ "time": "2024-09-17T22:40:32.196518000Z", "v": 0, "hostname": "smartypants", "name": "zoneadmd","pid": 20226, "level": 30, "msg":"Assertion failed: value < VIONA_MAXQ, file pci_virtio_viona.c, line 1018, function pci_viona_write\n", "stream":"stderr" }
{ "time": "2024-09-17T22:40:33.926317000Z", "v": 0, "hostname": "smartypants", "name": "zoneadmd","pid": 20226, "level": 30, "stream":"logfile", "msg":"close" }

zoneadmd crashes and the virtual machine shuts down during this process. OpenBSD starts to create vio0 interface as bhyve core dumps. Bug?

Courtney
------------------------------------------
illumos: illumos-discuss
Permalink: https://illumos.topicbox.com/groups/discuss/T4e2284ac1aa3fba0-Mdfd15d4d11caf0b2a7f258b4
Delivery options: https://illumos.topicbox.com/groups/discuss/subscription

[-- Attachment #2: Type: text/html, Size: 2169 bytes --]

[discuss] Re: bhyve core dump

[courtney via illumos-discuss]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

I forgot to add stack info

# mdb -e "::stack" core.bhyve.19979
libc.so.1`_lwp_kill+0xa()
libc.so.1`raise+0x22(6)
libc.so.1`abort+0x58()
0xfffffc7feeef6d82()
pci_viona_write+0x4d1(f19050, 0, e, 2, 3)
pci_emul_io_handler+0xa7(f091b0, 0, 210e, 2, fffffc7fe95f5e4c, f19050)
emulate_inout+0x90(f091b0, f0ffb0, fffffc7fe95f5e4c)
vmexit_inout+0x65(f091b0, f0ffb0, fffffc7fe95f5ee0)
vm_loop+0x9f(f091b0, f0ffb0)
fbsdrun_start_thread+0x59(f10f90)
libc.so.1`_thrp_setup+0x77(fffffc7fef221240)
libc.so.1`_lwp_start()

------------------------------------------
illumos: illumos-discuss
Permalink: https://illumos.topicbox.com/groups/discuss/T4e2284ac1aa3fba0-Mbbb891181c361d7658bb71b2
Delivery options: https://illumos.topicbox.com/groups/discuss/subscription

[-- Attachment #2: Type: text/html, Size: 1417 bytes --]

[discuss] Re: bhyve core dump

[courtney via illumos-discuss]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Follow up: I found the issue to be an off by one error in the guest kernel in a recent commit.
------------------------------------------
illumos: illumos-discuss
Permalink: https://illumos.topicbox.com/groups/discuss/T4e2284ac1aa3fba0-M8d54f90bbe9e407751c0e549
Delivery options: https://illumos.topicbox.com/groups/discuss/subscription

[-- Attachment #2: Type: text/html, Size: 846 bytes --]

Re: [discuss] Re: bhyve core dump

[Joshua M. Clulow via illumos-discuss]

On Wed, 18 Sept 2024 at 12:28, courtney via illumos-discuss
<discuss@lists.illumos.org> wrote:
> Follow up: I found the issue to be an off by one error in the guest kernel in a recent commit.

I've filed a bug to cover the crash, which should never happen even if
the guest misbehaves:

    16795 bhyve assertion failure: value < VIONA_MAXQ in pci_viona_write()
        https://www.illumos.org/issues/16795


Cheers.

-- 
Joshua M. Clulow
http://blog.sysmgr.org

------------------------------------------
illumos: illumos-discuss
Permalink: https://illumos.topicbox.com/groups/discuss/T4e2284ac1aa3fba0-M1705f7734a55facc101dd8bb
Delivery options: https://illumos.topicbox.com/groups/discuss/subscription