From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29320 invoked from network); 12 Oct 2021 17:49:34 -0000 Received: from lists.gnu.org (209.51.188.17) by inbox.vuxu.org with ESMTPUTF8; 12 Oct 2021 17:49:34 -0000 Received: from localhost ([::1]:45110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maLu8-0001Um-5x for ml@inbox.vuxu.org; Tue, 12 Oct 2021 13:49:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maLty-0001RH-Gp for info-gnus-english@gnu.org; Tue, 12 Oct 2021 13:49:25 -0400 Received: from ciao.gmane.io ([116.202.254.214]:60174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maLtw-0001fX-Vd for info-gnus-english@gnu.org; Tue, 12 Oct 2021 13:49:22 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1maLtv-0006VO-AL for info-gnus-english@gnu.org; Tue, 12 Oct 2021 19:49:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: info-gnus-english@gnu.org From: Eric Abrahamsen Subject: Re: Mail source unreachable - continue yes/no? Date: Tue, 12 Oct 2021 10:49:01 -0700 Message-ID: <871r4qyvzm.fsf@ericabrahamsen.net> References: <22ee8sumb0.fsf@hiptop.liman.net> <87zgrect8z.fsf@gnus.org> <875yu2yyp9.fsf@ericabrahamsen.net> <877deib2q9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:32i99y2gV0EpHjTclc+08pm+fjs= Received-SPF: pass client-ip=116.202.254.214; envelope-from=gegu-info-gnus-english@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: info-gnus-english@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Announcements and discussions for GNUS, the GNU Emacs Usenet newsreader \(in English\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+ml=inbox.vuxu.org@gnu.org Sender: "info-gnus-english" Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> We create a few custom error symbols for backend errors, including mail >> source failures, open-server failures, etc, and we put some >> condition-cases handling those errors in `gnus-get-unread-articles'. > > This is called from nnmail-get-new-mail-1, though, which ignores errors > on its own. `gnus-get-unread-articles' also has error-ignoring > capabilities and... `nnmail-get-new-mail' is called from within `gnus-request-scan', and there's no error ignoring around `gnus-request-scan' in `gnus-get-unread-articles' -- is there? I can't see anything. I would propose removing error handling from `nnmail-get-new-mail-1': if the fetching of mail sources well and truly fails (and the user hits "no" to give up on the process), it should just signal an error up the line. >> They collect the errors, continue with the next server, and at the end >> of the process display a nice tidy message indicating which servers >> failed to connect. > > ... does just that, I think? At least that's what happens when a server > fails for me. I think nntp servers are louder than the others. When I hit "g" and the nntp connection times out, I get a "server closed connection" message, and the whole update process halts.