From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19051 invoked from network); 7 Sep 2022 01:15:19 -0000 Received: from lists.gnu.org (209.51.188.17) by inbox.vuxu.org with ESMTPUTF8; 7 Sep 2022 01:15:19 -0000 Received: from localhost ([::1]:53042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVjev-0001St-BJ for ml@inbox.vuxu.org; Tue, 06 Sep 2022 21:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVjeq-0001Sf-6a for info-gnus-english@gnu.org; Tue, 06 Sep 2022 21:15:12 -0400 Received: from ciao.gmane.io ([116.202.254.214]:38524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVjeo-0004sk-Eo for info-gnus-english@gnu.org; Tue, 06 Sep 2022 21:15:11 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oVjel-0008zt-19 for info-gnus-english@gnu.org; Wed, 07 Sep 2022 03:15:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: info-gnus-english@gnu.org To: info-gnus-english@gnu.org From: Emanuel Berg Subject: Re: Strip signature on reply without standard separator Date: Wed, 07 Sep 2022 03:14:59 +0200 Message-ID: <8735d47zos.fsf@dataswamp.org> References: <87y1vykpl2.fsf@icloud.com> <87zggbz3ho.fsf@icloud.com> <87bksaz837.fsf@icloud.com> <87a67ul62m.fsf@dataswamp.org> <87mtbufg7e.fsf@icloud.com> <875yii2oru.fsf@dataswamp.org> <875yih6n25.fsf_-_@icloud.com> <878rnaw3tw.fsf_-_@icloud.com> <87mtbgarre.fsf@icloud.com> <87czcb6gjp.fsf@dataswamp.org> <87r10onki5.fsf@icloud.com> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:9ist74jItM0QbMxV9Zki9u/NHW8= Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=gegu-info-gnus-english@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: info-gnus-english@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Announcements and discussions for GNUS, the GNU Emacs Usenet newsreader \(in English\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+ml=inbox.vuxu.org@gnu.org Sender: "info-gnus-english" Satoshi Yoshida wrote: >> 1. Split into functions with names that explain what >> they do. >> >> 2. Instead of `replace-regexp', use >> >> (while (re-search-forward RE nil t) >> (replace-match STR) ) > > I see. Thank you. Is this fix right? Make the whole thing a function that you add to the the hook. Use blank lines to separate different parts. This also makes it easier to test, you can simply call the function. And try out and optimize the different parts one by one. But only do modules when it makes sense semantically, i.e. when one can clearly say "this function does this, this other function does something different", don't split it up just because "this function is too long". One way to check if it does make sense is to write names that makes sense, when that is difficult, "hm ... what DO we call THIS function?" then that is an indication that function isn't a good idea. So while in general it's good with modules but in particular good modules are even better ;) > (strip-signature "^\n-- \n\\(.*\n\\)*" "") > (strip-signature "^\\([^[:blank:]\n<>]+>.*\\)" "> \\1") > (strip-signature "^\\([^\n>].+\n\n\\)\\(>[[:blank:]]+\n\\\)+" "\\1") > (strip-signature "^> >" ">>") > (strip-signature "^> -- .*\n\\(>.*\n\\)*" "") > (strip-signature "^\\(>[[:blank:]]+\n\\)+> \\(best\ Here it may be a better idea to have those REs in a list and then iterate that (a loop) instead of calling the same function so many times. -- underground experts united https://dataswamp.org/~incal