Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: info-gnus-english@gnu.org
Subject: Re: nnimap-split-download-body removed?
Date: Mon, 30 Nov 2020 19:35:47 -0800	[thread overview]
Message-ID: <87360qqju4.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <871rgaqlb2.fsf@gmail.com>

Bodertz <bodertz@gmail.com> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> The problem with checking the headers or the message size before
>> downloading the body is that you're then issuing one FETCH to get all
>> the messages without their bodies, and then issuing another to get the
>> bodies you want, likely just the same list as before.
>
> It may not be worth doing, but I challenge your assumption that they
> would be the same list.  For my case at least, the list of messages
> which I want split based on the body is a small subset of the list of
> new messages I receive.  When I imagine other uses of splitting based on
> the body, they are only cases where splitting on other matches such as
> from or subject wasn't enough, and that would still be a small subset of
> new messages.  Most messages can be split with just the headers.

Well, fair enough. I suppose it would also be one of those things where
we just warned the users it might be slow, and they could decide for
themselves.

>> That seems like it would end up being pretty inefficient, and I wouldn't
>> be surprised if it turned out that we had to issue one FETCH per message
>> we wanted the body for. I'll admit I haven't looked at this part of the
>> code closely, but...
>
> Since `nnimap-fetch-inbox' accepts a list of articles, I don't see why
> we couldn't feed the list of new articles to it with either "[HEADER]"
> or "[1]" based on the result of `(nnimap-ver4-p)', and then build a new
> list of articles which meet some criteria and send that to
> `nnimap-fetch-inbox' with "[]".  But I don't actually understand the
> code, so I'm sure things are more complicated than that.

Continuing our baseless speculation without looking at the code... I
wonder if it would be even possible to do this: it would require either
running splitting twice (once to split simpler messages, and return a
list of messages that needed further downloading and re-splitting), or
pausing in the middle of splitting to download messages.

Anyway, let me send in a bug report for the simpler change. I'll mention
your other request, and see if anyone else has a point of view.

Eric


_______________________________________________
info-gnus-english mailing list
info-gnus-english@gnu.org
https://lists.gnu.org/mailman/listinfo/info-gnus-english

  reply	other threads:[~2020-12-01  3:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 15:03 Bodertz
2020-11-30 17:10 ` Eric Abrahamsen
2020-12-01  0:15   ` Bodertz
2020-12-01  1:51     ` Eric Abrahamsen
2020-12-01  3:04       ` Bodertz
2020-12-01  3:35         ` Eric Abrahamsen [this message]
2020-12-01  8:46           ` Bodertz
2020-12-01 18:26             ` Eric Abrahamsen
2020-12-02  7:18               ` Bodertz
2020-12-02 20:34                 ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87360qqju4.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=info-gnus-english@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).