Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: info-gnus-english@gnu.org
Subject: Re: gnus-search since: not working for nnimap
Date: Mon, 30 Jan 2023 09:41:41 -0800	[thread overview]
Message-ID: <875ycnx6lm.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87357s48do.fsf@free.fr>

Julien Cubizolles <j.cubizolles@free.fr> writes:

> Julien Cubizolles <j.cubizolles@free.fr> writes:
>
>> 'gnus-search-transform seems to be at fault here. It uses
>> '(format-time-string "%e-%b-%Y") where %b returns the "locale’s
>> abbreviated month name" when imap commands expects the english abbreviated
>> month name.
>
> It's working with the attached patch. I'm not sure this is the best way
> to go but I'm happy with it.
>
> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
> index 27c71fa6c6..0d9a62f911 100644
> --- a/lisp/gnus/gnus-search.el
> +++ b/lisp/gnus/gnus-search.el
> @@ -1330,9 +1330,10 @@ elements are present."
>  		      (1- nyear)
>  		    nyear))
>  	  (setq dmonth 1))))
> -    (format-time-string
> -     "%e-%b-%Y"
> -     (encode-time 0 0 0 dday dmonth dyear))))
> +    (with-locale-environment "C"
> +      (format-time-string
> +       "%e-%b-%Y"
> +       (encode-time 0 0 0 dday dmonth dyear)))))
>  
>  (cl-defmethod gnus-search-imap-handle-string ((engine gnus-search-imap)
>  					      (str string))

Ooh, that's a great catch, thank you very much. I'll look around and see
if there are any other similar issues in this library, and push a fix to
master soon.

Thanks for the report,
Eric



  reply	other threads:[~2023-01-30 17:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 17:33 Eric Abrahamsen
2023-01-30  7:18 ` Julien Cubizolles
2023-01-30  9:32   ` Julien Cubizolles
2023-01-30 10:36     ` Julien Cubizolles
2023-01-30 17:41       ` Eric Abrahamsen [this message]
2023-02-01 23:05         ` Björn Bidar
  -- strict thread matches above, loose matches on Subject: below --
2023-01-28 12:22 Julien Cubizolles
2023-01-28 18:20 ` Eric Abrahamsen
2023-01-29  8:59   ` Julien Cubizolles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ycnx6lm.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=info-gnus-english@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).