From: Bodertz <bodertz@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: info-gnus-english@gnu.org
Subject: Re: nnimap-split-download-body removed?
Date: Mon, 30 Nov 2020 17:15:03 -0700 [thread overview]
Message-ID: <875z5mqt4o.fsf@gmail.com> (raw)
In-Reply-To: <87o8jesrde.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 30 Nov 2020 09:10:05 -0800")
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
I can confirm that setting `nnimap-split-download-body-default' to t
works as intended. I really should have tried that first.
It sounds like the removal wasn't intentional, so hopefully it can be
added back.
It seems to download the body before the splitting, which is
unfortunate. It would be better if it only downloaded the body when the
split required it. Or if it could match the sender against a whitelist
of accepted senders and only download when they matched. Or the same
thing but with the summary, but then it's getting close to just adding
a simpler split system before the real one, which is a little odd.
So I don't forget, someone also suggested `nnimap-split-download-body
size', which might be a useful addition:
[-- Attachment #2: Type: message/rfc822, Size: 4564 bytes --]
From: Ted Zlatanov <tzz@lifelogs.com>
Subject: Re: nnimap-split-download-body feature request
Date: Thu, 20 Nov 2003 09:20:09 -0500
Message-ID: <4n8ymbjf52.fsf@lockgroove.bwh.harvard.edu>
On Thu, 20 Nov 2003, jas@extundo.com wrote:
> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Nah, just fetch the headers. I think that's all you can reasonably
>> expect as a Gnus user. Maybe fake the body with "BODY TOO LARGE"
>> or something like that, or add a header, but I personally think
>> that retrieving just the headers in such a case is a perfectly good
>> solution.
>
> The asynchronous prefetch, agent, cache (and possibly more things)
> would cache this incomplete article. How would they know the
> message was incomplete? After requesting a re-fetch of the entire
> article, all those cached copies will need to be purged. Sounds
> like work.
I'm not sure I understand. Here's a patch to show you what I think
could be done, since nnimap-split-articles already decides between
the head and the whole body. The nnimap-check-body-size function
needs to be provided, but I hope you see what I mean.
Ted.
--- nnimap.el 4 Sep 2003 22:22:18 -0000 6.71
+++ nnimap.el 20 Nov 2003 14:20:24 -0000
@@ -1271,9 +1271,10 @@
(when (setq rule (nnimap-split-find-rule server inbox))
;; iterate over articles
(dolist (article (imap-search nnimap-split-predicate))
- (when (if (if (eq nnimap-split-download-body 'default)
- nnimap-split-download-body-default
- nnimap-split-download-body)
+ (when (if (and (nnimap-check-body-size article)
+ (if (eq nnimap-split-download-body 'default)
+ nnimap-split-download-body-default
+ nnimap-split-download-body))
(and (nnimap-request-article article)
(with-current-buffer nntp-server-buffer (mail-narrow-to-head)))
(nnimap-request-head article))
[-- Attachment #3: Type: text/plain, Size: 162 bytes --]
_______________________________________________
info-gnus-english mailing list
info-gnus-english@gnu.org
https://lists.gnu.org/mailman/listinfo/info-gnus-english
next prev parent reply other threads:[~2020-12-01 0:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 15:03 Bodertz
2020-11-30 17:10 ` Eric Abrahamsen
2020-12-01 0:15 ` Bodertz [this message]
2020-12-01 1:51 ` Eric Abrahamsen
2020-12-01 3:04 ` Bodertz
2020-12-01 3:35 ` Eric Abrahamsen
2020-12-01 8:46 ` Bodertz
2020-12-01 18:26 ` Eric Abrahamsen
2020-12-02 7:18 ` Bodertz
2020-12-02 20:34 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z5mqt4o.fsf@gmail.com \
--to=bodertz@gmail.com \
--cc=eric@ericabrahamsen.net \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).