From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14942 invoked from network); 27 Dec 2021 22:08:20 -0000 Received: from lists.gnu.org (209.51.188.17) by inbox.vuxu.org with ESMTPUTF8; 27 Dec 2021 22:08:20 -0000 Received: from localhost ([::1]:41776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1yAD-0000rc-VJ for ml@inbox.vuxu.org; Mon, 27 Dec 2021 17:08:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1yAB-0000rT-Sa for info-gnus-english@gnu.org; Mon, 27 Dec 2021 17:08:15 -0500 Received: from ciao.gmane.io ([116.202.254.214]:46218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1yAA-0000S6-Ek for info-gnus-english@gnu.org; Mon, 27 Dec 2021 17:08:15 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n1yA7-0008oO-Cb for info-gnus-english@gnu.org; Mon, 27 Dec 2021 23:08:11 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: info-gnus-english@gnu.org From: "Jose A. Ortega Ruiz" Subject: Re: gnus-search-engine set to gnus-search-notmuch and refer threads Date: Mon, 27 Dec 2021 21:54:44 +0000 Message-ID: <877dbp67dn.fsf@gnus.jao.io> References: <87lf1k11ed.fsf@onenetbeyond.org> <877dd4rmof.fsf@gnus.jao.io> <87wnk6q2ym.fsf@onenetbeyond.org> <87y24ebiw8.fsf@ust.hk> <87pmpoqrxz.fsf@gnus.jao.io> <87k0fw8hmn.fsf@ericabrahamsen.net> <87fsqk8hio.fsf@ericabrahamsen.net> <87zgos9rbv.fsf@gnus.jao.io> <8735mj11no.fsf@ericabrahamsen.net> <87r1a2hf8u.fsf@gnus.jao.io> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:7rEwAfmNXZGReMHDq4PqQDxv5os= X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Received-SPF: pass client-ip=116.202.254.214; envelope-from=gegu-info-gnus-english@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: info-gnus-english@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Announcements and discussions for GNUS, the GNU Emacs Usenet newsreader \(in English\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+ml=inbox.vuxu.org@gnu.org Sender: "info-gnus-english" --=-=-= Content-Type: text/plain Hi again, So, summing up what we have so far (patch attached), the effect of these changes is to make the errors go away, but i'm not sure if the behaviour is expected: with the patch applied, A T will "work" for me in an nnselect group, with the caveat that, when gnus-refer-thread-use-search is t (or when calling gnus-refer-thread with C-u otherwise), the result is limited to the email already present in the nnselect group... that might be expected, in which case i think the patch can be applied (it's basically what you already propose, Eric, except it constructs the query as an alist). Cheers, jao -- There are two hard things in computer science: cache invalidation, naming things, and off-by-one errors. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-fixes-for-threaded-notmuch-searches.patch >From b56af8eb9c708ae9b700a061908509e16bc5bab4 Mon Sep 17 00:00:00 2001 From: Jose A Ortega Ruiz Date: Mon, 27 Dec 2021 21:42:32 +0000 Subject: [PATCH] fixes for threaded notmuch searches --- lisp/gnus/gnus-search.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el index d64c0cb90c..0743ee79ff 100644 --- a/lisp/gnus/gnus-search.el +++ b/lisp/gnus/gnus-search.el @@ -1611,8 +1611,8 @@ gnus-search-run-search (cl-call-next-method engine server ;; Completely replace the query with our new thread-based one. - (mapconcat (lambda (thrd) (concat "thread:" thrd)) - thread-ids " or ") + `((query . ,(mapconcat (lambda (thrd) (concat "thread:" thrd)) + thread-ids " or "))) nil))) (cl-call-next-method engine server query groups))) @@ -1630,7 +1630,7 @@ gnus-search-indexed-search-command ,(if thread "--output=threads" "--output=files") - "--duplicate=1" ; I have found this necessary, I don't know why. + ,@(unless thread '("--duplicate=1")) ; I have found this necessary, I don't know why. ,@switches ,(if limit (format "--limit=%d" limit) "") ,qstring -- 2.34.1 --=-=-=--