From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.user/18836 Path: news.gmane.org!.POSTED!not-for-mail From: "N. Jackson" Newsgroups: gmane.emacs.gnus.user Subject: Typo in doc string of `gnus-dependencies-add-header'? Date: Sun, 22 Jul 2018 09:37:36 -0400 Message-ID: <87a7qjv1b3.fsf@moondust.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1532266552 30693 195.159.176.226 (22 Jul 2018 13:35:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 13:35:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: info-gnus-english@gnu.org Original-X-From: info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org Sun Jul 22 15:35:48 2018 Return-path: Envelope-to: gegu-info-gnus-english@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhEWa-0007sJ-Bw for gegu-info-gnus-english@m.gmane.org; Sun, 22 Jul 2018 15:35:48 +0200 Original-Received: from localhost ([::1]:56033 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhEYh-0004f2-0X for gegu-info-gnus-english@m.gmane.org; Sun, 22 Jul 2018 09:37:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhEYd-0004da-2W for info-gnus-english@gnu.org; Sun, 22 Jul 2018 09:37:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhEYZ-0003LS-Bq for info-gnus-english@gnu.org; Sun, 22 Jul 2018 09:37:54 -0400 Original-Received: from [195.159.176.226] (port=57365 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhEYZ-0003JH-42 for info-gnus-english@gnu.org; Sun, 22 Jul 2018 09:37:51 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fhEWJ-0007by-Ur for info-gnus-english@gnu.org; Sun, 22 Jul 2018 15:35:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:GjQefv/c8xNkNbxr6x1Ohx1no3c= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: info-gnus-english@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Announcements and discussions for GNUS, the GNU Emacs Usenet newsreader \(in English\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org Original-Sender: "info-gnus-english" Xref: news.gmane.org gmane.emacs.gnus.user:18836 Archived-At: In Gnus v5.13 in GNU Emacs 27.0.50 Repository revision: f3f67cf0b9a6388d423e048a7aafad2eb531b5a5 While poking around [1] in the code, I stumbled across something in `gnus-dependencies-add-header' that confused me. If I understand correctly, there is typo in the doc string. The paragraph in question says: If `gnus-summary-ignore-duplicates' is nil then duplicate ^^^^^^ Message-IDs will not be entered in the DEPENDENCIES table. Otherwise duplicate Message-IDs will be renamed to a unique Message-ID before being entered. but it seems to me that this should begin: If `gnus-summary-ignore-duplicates' is not nil ... . The relevant code seems to be in the `cond' in `gnus-dependencies-add-header' at Line 4323 of gnus-sum.el: (cond ... ;; Renames the existing `header' to a unique Message-ID. ((not gnus-summary-ignore-duplicates) ;; An article with this Message-ID has already been seen. ;; We rename the Message-ID. (set (setq id-dep (intern (setq id (nnmail-message-id)) dependencies)) (list header)) (mail-header-set-id header id)) ... ) Am I right that the doc string is wrong, or am I missing something? (I could easily be missing something: trying to read Lisp makes my head hurt! (The world would be so much kinder on my noggin if everything were written in C.)) Thanks. N. [1] I'm trying to get a better understanding of Bug#28477 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28477) where Gnus occasionally gets the order wrong when displaying threads (and will show message A as reply to message B when in fact message B was the later message and responds to message A).