Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: "Adam Sjøgren" <asjo@koldfront.dk>
To: info-gnus-english@gnu.org
Subject: Re: Update topic unread counts on group exit?
Date: Wed, 04 May 2022 23:16:57 +0200	[thread overview]
Message-ID: <87ee19m20m.fsf@tullinup.koldfront.dk> (raw)
In-Reply-To: <87h765oz45.fsf@ericabrahamsen.net>

Eric writes:

> In fact, gnus-topic.el already thinks it's doing what you want --
> updating topic lines on group exit -- but because of the bug in
> `gnus-topic-update-topic', the update never happens.

Oooh, cool, I didn't remember that it used to work ;-)

> Lars added that major-mode check as part of a larger commit last year, I
> have to assume it was a mistake. I'll remove the checks now.

Nice piece of debugging!

However, I think you broke something? When I try to q out of a group I
now get:

    Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t)
      gnus-topic-find-groups("feedwork" 5 nil t)
      gnus-topic-update-topic-line("feedwork")
      gnus-topic-update-topics-containing-group("nntp+fb:feedbase.blog.inspiredpython")
      gnus-group-update-group("nntp+fb:feedbase.blog.inspiredpython" nil t)
      gnus-summary-update-info()
      gnus-summary-exit()
      funcall-interactively(gnus-summary-exit)
      command-execute(gnus-summary-exit)

(when toggle-debug-on-error is on, and I have removed my hook).


  Best regards,

    Adam

-- 
 "The world is short of delimiters," says Don.              Adam Sjøgren
                                                       asjo@koldfront.dk



  reply	other threads:[~2022-05-04 21:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 17:35 Adam Sjøgren
2022-05-04 17:58 ` Eric Abrahamsen
2022-05-04 18:17   ` Adam Sjøgren
2022-05-04 18:23     ` Adam Sjøgren
2022-05-04 19:51       ` Eric Abrahamsen
2022-05-04 21:16         ` Adam Sjøgren [this message]
2022-05-04 21:44         ` Adam Sjøgren
2022-05-05  1:00           ` Eric Abrahamsen
2022-05-05  4:36             ` Adam Sjøgren
2022-05-04 18:32     ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee19m20m.fsf@tullinup.koldfront.dk \
    --to=asjo@koldfront.dk \
    --cc=info-gnus-english@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).