From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7045 invoked from network); 4 May 2022 21:35:08 -0000 Received: from lists.gnu.org (209.51.188.17) by inbox.vuxu.org with ESMTPUTF8; 4 May 2022 21:35:08 -0000 Received: from localhost ([::1]:45982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmMeI-0008Ow-7K for ml@inbox.vuxu.org; Wed, 04 May 2022 17:35:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmMMx-0005hp-N1 for info-gnus-english@gnu.org; Wed, 04 May 2022 17:17:11 -0400 Received: from ciao.gmane.io ([116.202.254.214]:47304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmMMt-0003Sb-BW for info-gnus-english@gnu.org; Wed, 04 May 2022 17:17:11 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nmMMq-0006Ug-NG for info-gnus-english@gnu.org; Wed, 04 May 2022 23:17:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: info-gnus-english@gnu.org From: =?utf-8?Q?Adam_Sj=C3=B8gren?= Subject: Re: Update topic unread counts on group exit? Date: Wed, 04 May 2022 23:16:57 +0200 Organization: koldfront - analysis & revolution, Copenhagen, Denmark Message-ID: <87ee19m20m.fsf@tullinup.koldfront.dk> References: <87mtfxi4k3.fsf@tullinup.koldfront.dk> <874k25qiwi.fsf@ericabrahamsen.net> <87h7655fj5.fsf@tullinup.koldfront.dk> <87czgt5f7x.fsf@tullinup.koldfront.dk> <87h765oz45.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:Pu/3r5hxx7A/JSA+Ufm2sR47pcU= OpenPGP: id=476630590A231909B0A0961A49D0746121BDE416; url=https://asjo.koldfront.dk/gpg.asc X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97, Q(^@xk}n4Ou rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ ^St'=VZBR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+ml=inbox.vuxu.org@gnu.org Sender: "info-gnus-english" Eric writes: > In fact, gnus-topic.el already thinks it's doing what you want -- > updating topic lines on group exit -- but because of the bug in > `gnus-topic-update-topic', the update never happens. Oooh, cool, I didn't remember that it used to work ;-) > Lars added that major-mode check as part of a larger commit last year, I > have to assume it was a mistake. I'll remove the checks now. Nice piece of debugging! However, I think you broke something? When I try to q out of a group I now get: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) gnus-topic-find-groups("feedwork" 5 nil t) gnus-topic-update-topic-line("feedwork") gnus-topic-update-topics-containing-group("nntp+fb:feedbase.blog.inspiredpython") gnus-group-update-group("nntp+fb:feedbase.blog.inspiredpython" nil t) gnus-summary-update-info() gnus-summary-exit() funcall-interactively(gnus-summary-exit) command-execute(gnus-summary-exit) (when toggle-debug-on-error is on, and I have removed my hook). Best regards, Adam -- "The world is short of delimiters," says Don. Adam Sjøgren asjo@koldfront.dk