Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,  info-gnus-english@gnu.org
Subject: Re: Highlight process-marked files in Gnus summary?
Date: Wed, 20 May 2020 01:13:07 +0200	[thread overview]
Message-ID: <87ftbvy0vw.fsf@web.de> (raw)
In-Reply-To: <87zha4ox34.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 May 2020 15:47:43 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> > I haven't ever looked at the summary-highlight code, but would it be
> > hard to add another entry in there, call it `process', to specifically
> > target the process mark?
>
> I don't think that's necessary?  Can't you just add highlighting based
> on pretty much anything in the highlighting code?  (It's been a while
> since I looked at it...)

I had a quick look.  You currently have to refer to a set of predefined
variables in entries in `gnus-summary-highlight':

score:        The article's score.
default:      The default article score.
default-high: The default score for high scored articles.
default-low:  The default score for low scored articles.
mark:         The article's mark.
uncached:     Non-nil if the article is uncached.

though, actually, any expression is allowed I think.  It would be easier
if one could refer to the article number via `article'.  So currently, I
would have to do something like this:

(add-to-list 'gnus-summary-highlight
             '((memq (or (gnus-summary-article-number) gnus-current-article)
                     gnus-newsgroup-processable)
               . hl-line))

I would suggest to at least do the following:

(1) Provide an `article' variable.  Maybe also provide `processable' as
suggested and/or `sec-mark' (somewhere in the code the process mark is
called a "secondary mark")?

(2) make the docstring of `gnus-summary-highlight' say that arbitrary
expressions are allowed, and that they are evaluated with point
positioned on the according article's line.

For (1), AFAIU two places would need to be changed:
`gnus-summary-highlight-line' and `gnus-tree-highlight-node'.  Seems to
be simple to do.

Thanks,

Michael.

_______________________________________________
info-gnus-english mailing list
info-gnus-english@gnu.org
https://lists.gnu.org/mailman/listinfo/info-gnus-english

  reply	other threads:[~2020-05-19 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18  2:42 Michael Heerdegen
2020-05-18 15:38 ` Eric Abrahamsen
2020-05-19 13:47   ` Lars Ingebrigtsen
2020-05-19 23:13     ` Michael Heerdegen [this message]
2020-05-22 13:00       ` Lars Ingebrigtsen
2021-07-25 20:08     ` Roland Winkler
2021-07-25 22:16       ` Michael Heerdegen
2021-07-26  2:26         ` Roland Winkler
2021-07-27  0:47           ` Michael Heerdegen
2021-07-25 22:20       ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftbvy0vw.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=eric@ericabrahamsen.net \
    --cc=info-gnus-english@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).