Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: info-gnus-english@gnu.org
Subject: Re: A small patch for nnir.el
Date: Sat, 20 Mar 2010 10:05:12 -0500	[thread overview]
Message-ID: <87fx3vf2zb.fsf@lifelogs.com> (raw)
In-Reply-To: <87d3z0klpi.fsf@dishevelled.net>

On Sat, 20 Mar 2010 09:09:29 +1100 Mark Triggs <mst@dishevelled.net> wrote: 

MT> Ted Zlatanov <tzz@lifelogs.com> writes:
>> On Thu, 18 Mar 2010 14:04:26 +1100 Mark Triggs <mst@dishevelled.net> wrote: 
>> 
MT> I'm writing here because I'm a bit unsure who I should offer my (tiny)
MT> nnir.el patch to.  The ding list seems to have fallen to the spammers,
MT> and Kai Großjohann said that, although my patch looked sensible, he's no
MT> longer the primary maintainer of nnir.el.
>> 
>> Send it to the ding list or post here.  I'll take a look.
>> 
>> You need to have signed papers if your patch is non-trivial.

MT> Thanks Ted.  I've attached my patch, which must be at least close to
MT> trivial--it looks bigger than it really is because wrapping the old code
MT> in an "unless" has changed the indentation.

MT> I've signed FSF copyright papers before, but never for Gnus (I think my
MT> last one was against ERC).  I'm happy to sign and submit whatever wants
MT> signing and submitting, though.

Comitted.  I renamed the function with "-override-" so it's clear it
overrides the normal flow and used an if with comments instead of the
unless.  The changes are still tiny.  Can you test and write back if
it works for you or not?

Thanks
Ted

  reply	other threads:[~2010-03-20 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  3:04 Mark Triggs
2010-03-19 19:29 ` Ted Zlatanov
2010-03-19 22:09   ` Mark Triggs
2010-03-20 15:05     ` Ted Zlatanov [this message]
2010-03-20 21:01       ` Mark Triggs
2010-03-22 12:56         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fx3vf2zb.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=info-gnus-english@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).