From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: info-gnus-english@gnu.org
Subject: Re: Mail source unreachable - continue yes/no?
Date: Fri, 15 Oct 2021 10:43:28 -0700 [thread overview]
Message-ID: <87sfx2dvzz.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87o87q4lih.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> In the meantime I got a backtrace on my stop-the-world nntp connection
>> error, which I've posted below. I guess there's nothing mysterious about
>> it -- the process dies (I can't tell if it's actually the timeout doing
>> it or not), and nntp-accept-process-output/nntp-report ends up raising
>> the error, and there's nothing up the line to catch it. Does this look
>> surprising or wrong for any reason?
>>
>> (if nntp--report-1 (progn (if nntp-record-commands (progn
>> (nntp-record-command "*** CONNECTION LOST ***"))) (throw
>
> Network errors are common, so it shouldn't be throwing an error in the
> first place.
>
> But I can't recall ever seeing the `nntp-report' function before, so who
> knows what the logic is. :-/ That looks like a... debugging function?
The function has existed and raised an error since the "dawn of time"
(since CVS days), I guess I'm surprised this hasn't annoyed anyone else.
Basically it shadows `nnheader-report', and gives the server a single
chance to reconnect in case of failure -- the "nntp-with-open-group"
mechanism -- before failing altogether. All that's fine, I wish nnimap
had something similar, but raising the error seems wrong.
In fact raising the error would be the right thing in the code sketch I
posted above! This code is ahead of its time.
Anyway, simply removing the call to error should do the trick. That
will leave `nnheader-report' as the final form, which returns nil.
`nntp-report' is the final form everywhere it's called, so the nil goes
up to callers, which will (mostly) interpret that as failure.
Eric
next prev parent reply other threads:[~2021-10-15 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 6:07 Lars-Johan Liman
2021-10-12 12:39 ` Lars Ingebrigtsen
2021-10-12 16:50 ` Eric Abrahamsen
2021-10-12 16:57 ` Lars Ingebrigtsen
2021-10-12 17:49 ` Eric Abrahamsen
2021-10-12 17:56 ` Lars Ingebrigtsen
2021-10-12 18:18 ` Eric Abrahamsen
2021-10-12 18:25 ` Lars Ingebrigtsen
2021-10-12 19:50 ` Eric Abrahamsen
2021-10-13 11:33 ` Lars Ingebrigtsen
2021-10-14 5:03 ` Eric Abrahamsen
2021-10-14 11:22 ` Lars Ingebrigtsen
2021-10-14 18:31 ` Eric Abrahamsen
2021-10-15 10:42 ` Lars Ingebrigtsen
2021-10-15 17:43 ` Eric Abrahamsen [this message]
2021-10-12 16:57 ` Lars-Johan Liman
2021-10-14 17:39 ` Eric Abrahamsen
2021-10-15 10:48 ` Lars Ingebrigtsen
2021-10-15 17:52 ` Eric Abrahamsen
2021-10-18 6:42 ` Lars Ingebrigtsen
2021-10-18 15:03 ` Eric Abrahamsen
2021-10-19 13:42 ` Lars Ingebrigtsen
2021-10-19 15:15 ` Eric Abrahamsen
2021-10-21 23:36 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfx2dvzz.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).