From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16181 invoked from network); 23 Dec 2021 00:30:46 -0000 Received: from lists.gnu.org (209.51.188.17) by inbox.vuxu.org with ESMTPUTF8; 23 Dec 2021 00:30:46 -0000 Received: from localhost ([::1]:41444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0C0J-0008GQ-US for ml@inbox.vuxu.org; Wed, 22 Dec 2021 19:30:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0C0F-0008G1-FY for info-gnus-english@gnu.org; Wed, 22 Dec 2021 19:30:39 -0500 Received: from ciao.gmane.io ([116.202.254.214]:39652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0C0D-000248-Qk for info-gnus-english@gnu.org; Wed, 22 Dec 2021 19:30:39 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n0C0B-0008DN-Nl for info-gnus-english@gnu.org; Thu, 23 Dec 2021 01:30:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: info-gnus-english@gnu.org From: Eric Abrahamsen Subject: Re: gnus-search-engine set to gnus-search-notmuch and refer threads Date: Wed, 22 Dec 2021 16:30:16 -0800 Message-ID: <87v8zg6u3r.fsf@ericabrahamsen.net> References: <87lf1k11ed.fsf@onenetbeyond.org> <877dd4rmof.fsf@gnus.jao.io> <87wnk6q2ym.fsf@onenetbeyond.org> <87y24ebiw8.fsf@ust.hk> <87pmpoqrxz.fsf@gnus.jao.io> <87k0fw8hmn.fsf@ericabrahamsen.net> <87fsqk8hio.fsf@ericabrahamsen.net> <87zgos9rbv.fsf@gnus.jao.io> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:FCC+D4QCv5L0yC++69c6/gOsPWI= Received-SPF: pass client-ip=116.202.254.214; envelope-from=gegu-info-gnus-english@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: info-gnus-english@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Announcements and discussions for GNUS, the GNU Emacs Usenet newsreader \(in English\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: info-gnus-english-bounces+ml=inbox.vuxu.org@gnu.org Sender: "info-gnus-english" "Jose A. Ortega Ruiz" writes: > On Wed, Dec 22 2021, Eric Abrahamsen wrote: > > [...] > >> My guess is that we need to go to point-min right here. >> >>> (while (re-search-forward "^thread:\\([^ ]+\\)" (point-max) t) >>> (push (match-string 1) thread-ids)) >>> (cl-call-next-method >>> engine server >>> ;; Completely replace the query with our new thread-based one. >>> (mapconcat (lambda (thrd) (concat "thread:" thrd)) >>> thread-ids " or ") >>> nil))) >>> (cl-call-next-method engine server query groups))) > > it's not enough. before that, there's a problem with invoking the > search for threads, because notmuch is passed the flag --duplicate=1, > and that's not accepted for format thread: > > Error: --duplicate=N is only supported with --output=files and --output=messages. > > funny thing is that that flag is added for no apparent reason in line > 1633 of gnus-search.el: > > "--duplicate=1" ; I have found this necessary, I don't know why. Hmm, I inherited this code, and didn't know why it was necessary either, so I didn't take it out. I think notmuch can return multiple search results if the same message exists in multiple folders, but since we're filtering folders to begin with, maybe we don't need this. > i don't know why either because searches seem to work without it :). > if one eliminates that flag and adds your suggested (goto-char > (point-min)) we are not out the woods yet: the thread id is read, but > including an eol, so one needs > > (while (re-search-forward "^thread:\\([^\n ]+\\)" (point-max) t) > ^^^^ Obviously I was hoping this would Just Work™ without me having to actually install notmuch and test it. > and then, we still fail, because that leads, somehow to an error of the > form: > > Debugger entered--Lisp error: (wrong-type-argument listp "thread:000000000001a830") > alist-get(parsed-query "thread:000000000001a830") > #f(compiled-function (engine query-spec) #)(# "thread:000000000001a830") > apply(#f(compiled-function (engine query-spec) #) # "thread:000000000001a830") > gnus-search-make-query-string(# "thread:000000000001a830") > > which indicates that the notmuch method for > gnus-search-make-query-string is buggy: it doesn't know how to parse > "thread:000000000001a830" queries... and here i ran out of steam, but > the fix seems nearby :) You have done heroic work, and I hope it may yet be unnecessary for me to install and configure notmuch. Telling notmuch what to do with "thread:xxx" queries is not difficult, and I should have a solution for this in the next day or so. Thanks for the extensive debugging, Eric