gnus registry menu problem in emacs 23.1

gnus registry menu problem in emacs 23.1

[Paul Bibbings]

To give the context, I recently upgraded to Emacs 23.1 running on
Windows Vista, and followed the instructions in `gnus-registry.el',
adding the lines:

    (setq gnus-registry-max-entries 2500
          gnus-registry-use-long-group-names t)

    (gnus-registry-initialize)

to my ~/.gnus.el file.

In ~./.emacs I already have:

    (custom-set-variables
       ...
       '(gnus-registry-install t)
       '(gnus-registry-marks (quote (
            (Important :char 105 :image "summary_important") 
            (Work :char 119 :image "summary_work") 
            (Personal :char 112 :image "summary_personal") 
            (To-Do :char 116 :image "summary_todo") 
            (Later :char 108 :image "summary_later"))))
       '(gnus-registry-max-entries nil)
       '(gnus-registry-use-long-group-names t)
       ...)

If I then check everything after loading gnus:

   1. `C-H f' gnus-registry-set-article-Important-mark (for example)
       tells me this function is available in `.gnus.el'
   2.  With an appropriate article selected,
           `M-x' gnus-registry-set-article-Important-mark
       executes as expected and sets the mark.

However, with the same article selected as in 2. (above) clicking on the
menu item:
     Gnus | Registry Mark | Important
fails with:
     "Symbol's function definition is void: 
         gnus-registry-set-article-Important-mark"

Is anybody able to help me understand what the problem might be here?
I'm at a loss, being quite new to Emacs and Gnus (though loving it, I
have to say). The menu item seems to be hooked into the correct function
call, but it is somehow believing that it is undefined, whereas the
other tests (above) show that it clearly is, and operates properly.

Thanks in advance.

Regards

Paul Bibbings

Re: gnus registry menu problem in emacs 23.1

[Ted Zlatanov]

On Sat, 16 Jan 2010 17:35:33 +0000 Paul Bibbings <paul.bibbings@gmail.com> wrote: 

PB> However, with the same article selected as in 2. (above) clicking on the
PB> menu item:
PB>      Gnus | Registry Mark | Important
PB> fails with:
PB>      "Symbol's function definition is void: 
PB>          gnus-registry-set-article-Important-mark"

PB> Is anybody able to help me understand what the problem might be here?
PB> I'm at a loss, being quite new to Emacs and Gnus (though loving it, I
PB> have to say). The menu item seems to be hooked into the correct function
PB> call, but it is somehow believing that it is undefined, whereas the
PB> other tests (above) show that it clearly is, and operates properly.

Try using this in gnus-sum.el around line 2640:

	("Registry Mark"
	 ["Important"     (lambda () (interactive) (gnus-registry-set-article-Important-mark))    t]
	 ["Not Important" (lambda () (interactive) (gnus-registry-remove-article-Important-mark)) t]
	 ["Personal"      (lambda () (interactive) (gnus-registry-set-article-Personal-mark))     t]
	 ["Not Personal"  (lambda () (interactive) (gnus-registry-remove-article-Personal-mark))  t]
	 ["Later"         (lambda () (interactive) (gnus-registry-set-article-Later-mark))        t]
	 ["Not Later"     (lambda () (interactive) (gnus-registry-remove-article-Later-mark))     t]
	 ["Work"          (lambda () (interactive) (gnus-registry-set-article-Work-mark))         t]
	 ["Not Work"      (lambda () (interactive) (gnus-registry-remove-article-Work-mark))      t]
	 ["To Do"         (lambda () (interactive) (gnus-registry-set-article-To-Do-mark))        t]
	 ["Not To Do"     (lambda () (interactive) (gnus-registry-remove-article-To-Do-mark))     t])

instead of the version that just calls those functions.  I think it's
happening because the function is not defined when the menu is made, but
I don't know the exact failure mode.

If the above doesn't work, I may have to use `intern'.  Does anyone have
a better idea?  I don't want gnus-sum.el to load the registry because
not everyone wants it, but once this menu is built it's hard to update
it again.

Ted

Re: gnus registry menu problem in emacs 23.1

[Ted Zlatanov]

On Fri, 29 Jan 2010 12:24:48 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Sat, 16 Jan 2010 17:35:33 +0000 Paul Bibbings <paul.bibbings@gmail.com> wrote: 
PB> However, with the same article selected as in 2. (above) clicking on the
PB> menu item:
PB> Gnus | Registry Mark | Important
PB> fails with:
PB> "Symbol's function definition is void: 
PB> gnus-registry-set-article-Important-mark"

PB> Is anybody able to help me understand what the problem might be here?
PB> I'm at a loss, being quite new to Emacs and Gnus (though loving it, I
PB> have to say). The menu item seems to be hooked into the correct function
PB> call, but it is somehow believing that it is undefined, whereas the
PB> other tests (above) show that it clearly is, and operates properly.

TZ> Try using this in gnus-sum.el around line 2640:

TZ> 	("Registry Mark"
TZ> 	 ["Important"     (lambda () (interactive) (gnus-registry-set-article-Important-mark))    t]
TZ> 	 ["Not Important" (lambda () (interactive) (gnus-registry-remove-article-Important-mark)) t]
TZ> 	 ["Personal"      (lambda () (interactive) (gnus-registry-set-article-Personal-mark))     t]
TZ> 	 ["Not Personal"  (lambda () (interactive) (gnus-registry-remove-article-Personal-mark))  t]
TZ> 	 ["Later"         (lambda () (interactive) (gnus-registry-set-article-Later-mark))        t]
TZ> 	 ["Not Later"     (lambda () (interactive) (gnus-registry-remove-article-Later-mark))     t]
TZ> 	 ["Work"          (lambda () (interactive) (gnus-registry-set-article-Work-mark))         t]
TZ> 	 ["Not Work"      (lambda () (interactive) (gnus-registry-remove-article-Work-mark))      t]
TZ> 	 ["To Do"         (lambda () (interactive) (gnus-registry-set-article-To-Do-mark))        t]
TZ> 	 ["Not To Do"     (lambda () (interactive) (gnus-registry-remove-article-To-Do-mark))     t])

TZ> instead of the version that just calls those functions.  I think it's
TZ> happening because the function is not defined when the menu is made, but
TZ> I don't know the exact failure mode.

TZ> If the above doesn't work, I may have to use `intern'.  Does anyone have
TZ> a better idea?  I don't want gnus-sum.el to load the registry because
TZ> not everyone wants it, but once this menu is built it's hard to update
TZ> it again.

Can anyone else try this change or suggest a better fix?

Ted

Re: gnus registry menu problem in emacs 23.1

[Paul Bibbings]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Sat, 16 Jan 2010 17:35:33 +0000 Paul Bibbings <paul.bibbings@gmail.com> wrote: 
>
> PB> However, with the same article selected as in 2. (above) clicking on the
> PB> menu item:
> PB>      Gnus | Registry Mark | Important
> PB> fails with:
> PB>      "Symbol's function definition is void: 
> PB>          gnus-registry-set-article-Important-mark"
>
> PB> Is anybody able to help me understand what the problem might be here?
> PB> I'm at a loss, being quite new to Emacs and Gnus (though loving it, I
> PB> have to say). The menu item seems to be hooked into the correct function
> PB> call, but it is somehow believing that it is undefined, whereas the
> PB> other tests (above) show that it clearly is, and operates properly.
>
> Try using this in gnus-sum.el around line 2640:
>
> 	("Registry Mark"
> 	 ["Important"     (lambda () (interactive) (gnus-registry-set-article-Important-mark))    t]
> 	 ["Not Important" (lambda () (interactive) (gnus-registry-remove-article-Important-mark)) t]
> 	 ["Personal"      (lambda () (interactive) (gnus-registry-set-article-Personal-mark))     t]
> 	 ["Not Personal"  (lambda () (interactive) (gnus-registry-remove-article-Personal-mark))  t]
> 	 ["Later"         (lambda () (interactive) (gnus-registry-set-article-Later-mark))        t]
> 	 ["Not Later"     (lambda () (interactive) (gnus-registry-remove-article-Later-mark))     t]
> 	 ["Work"          (lambda () (interactive) (gnus-registry-set-article-Work-mark))         t]
> 	 ["Not Work"      (lambda () (interactive) (gnus-registry-remove-article-Work-mark))      t]
> 	 ["To Do"         (lambda () (interactive) (gnus-registry-set-article-To-Do-mark))        t]
> 	 ["Not To Do"     (lambda () (interactive) (gnus-registry-remove-article-To-Do-mark))     t])
>
> instead of the version that just calls those functions.  I think it's
> happening because the function is not defined when the menu is made, but
> I don't know the exact failure mode.
>
> If the above doesn't work, I may have to use `intern'.  Does anyone have
> a better idea?  I don't want gnus-sum.el to load the registry because
> not everyone wants it, but once this menu is built it's hard to update
> it again.

Hello Ted

Thank you for your response, and apologies for not replying to you
sooner.  I can confirm that I have made the modifications that you
suggest above, re-compiled to gnus-sum.elc and reloaded everything and
it *doesn't*, unfortunately correct the problem.  I do believe that the
problem is something to do with the functions not being defined when the
menu is made, as you say.  When you say "I don't know the exact failure
mode," is there any more information that I could provide? Having said
that, I'm not immediately clear how to debug this one since the
functions in question are created "on the fly," so to speak.

Regards

Paul Bibbings

Re: gnus registry menu problem in emacs 23.1

[Ted Zlatanov]

I believe the registry mark menus work properly now.  Tested under a
fresh Emacs checkout.

Let me know if you find issues...  Thanks!

Ted

Re: gnus registry menu problem in emacs 23.1

[Paul Bibbings]

Ted Zlatanov <tzz@lifelogs.com> writes:

> I believe the registry mark menus work properly now.  Tested under a
> fresh Emacs checkout.
>
> Let me know if you find issues...  Thanks!
>
> Ted

Hi Ted

I have downloaded the latest gnus from cvs and installed under Emacs
23.1 (Windows).  I'll post if there are any issue but, after initial
testing, the registry mark menus do indeed now appear to work properly.

Thank you for your work on this.

Regards

Paul Bibbings