From: Reiner Steib <reinersteib+gmane@imap.cc>
To: info-gnus-english@gnu.org
Subject: Re: message-signature-file toggled to nil locally
Date: Sun, 03 Feb 2008 19:53:13 +0100 [thread overview]
Message-ID: <v9lk613m92.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <87ejbt3ord.fsf@patagonia.sebmags.homelinux.org>
On Sun, Feb 03 2008, Sebastian P. Luque wrote:
> On Sun, 03 Feb 2008 18:12:57 +0100,
> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>> On Sun, Feb 03 2008, Sebastian P. Luque wrote:
>>> I noticed that message-signature-file gets set to nil when composing
>>> messages, even though the signature is chosen correctly, based on
>>> gnus-posting-styles: [...]
>
>> So what is the problem?
>
> The problem is that if I want to change the signature, say through 'C-c
> C-w' (message-insert-signature), or gnus-personalities, then any
> reference to this variable doesn't do what's expected.
I see. Does the following quite untested patch do the right thing?
--8<---------------cut here---------------start------------->8---
--- message.el 28 Jan 2008 09:02:57 -0000 7.239
+++ message.el 3 Feb 2008 18:49:59 -0000
@@ -3281,7 +3281,11 @@
(defun message-insert-signature (&optional force)
"Insert a signature. See documentation for variable `message-signature'."
(interactive (list 0))
- (let* ((signature
+ (let* ((message-signature-file (or message-signature-file
+ (default-value 'message-signature-file)))
+ (message-signature (or message-signature
+ (default-value 'message-signature)))
+ (signature
(cond
((and (null message-signature)
(eq force 0))
--8<---------------cut here---------------end--------------->8---
Bye, Reiner.
next prev parent reply other threads:[~2008-02-03 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 16:38 Sebastian P. Luque
2008-02-03 17:12 ` Reiner Steib
2008-02-03 17:59 ` Sebastian P. Luque
2008-02-03 18:53 ` Reiner Steib [this message]
2008-02-03 23:10 ` Sebastian P. Luque
2008-02-03 22:18 ` Sebastian P. Luque
[not found] ` <mailman.6907.1202077097.18990.info-gnus-english@gnu.org>
2008-02-04 10:42 ` Slackrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9lk613m92.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).