From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.user/10292
Path: news.gmane.org!not-for-mail
From: Reiner Steib <reinersteib+gmane@imap.cc>
Newsgroups: gmane.emacs.gnus.user
Subject: Re: message-signature-file toggled to nil locally
Date: Sun, 03 Feb 2008 19:53:13 +0100
Organization: T-Online
Message-ID: <v9lk613m92.fsf@marauder.physik.uni-ulm.de>
References: <87hcgqov0y.fsf@patagonia.sebmags.homelinux.org>
	<v9wspm2cbq.fsf@marauder.physik.uni-ulm.de>
	<87ejbt3ord.fsf@patagonia.sebmags.homelinux.org>
Reply-To: Reiner Steib <Reiner.Steib@gmx.de>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1202078431 632 80.91.229.12 (3 Feb 2008 22:40:31 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 3 Feb 2008 22:40:31 +0000 (UTC)
To: info-gnus-english@gnu.org
Original-X-From: info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org Sun Feb 03 23:40:51 2008
Return-path: <info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org>
Envelope-to: gegu-info-gnus-english@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JLnW7-0006vt-D5
	for gegu-info-gnus-english@m.gmane.org; Sun, 03 Feb 2008 23:40:51 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1JLnVf-0008SP-1c
	for gegu-info-gnus-english@m.gmane.org; Sun, 03 Feb 2008 17:40:23 -0500
Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!panix!newsfeed-00.mathworks.com!kanaga.switch.ch!switch.ch!news.belwue.de!newsfeed01.sul.t-online.de!newsfeedt0.toon.t-online.de!newsmm00.sul.t-online.de!t-online.de!news.t-online.com!not-for-mail
Original-Newsgroups: gnu.emacs.gnus
Original-Lines: 37
Original-X-Trace: news.t-online.com 1202074655 03 7091 ljO315ClMspPlOj 080203 21:37:35
Original-X-Complaints-To: usenet-abuse@t-online.de
X-ID: E4A4H0ZpreX1kjS537oFMt9JNT8omx4VloB+jQUzGp+M1bxe3ihVr3
X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+<OV~fQY=S61n*cJ|<hmq6\]&vOTQs+z`}WHHM/
	E?ZYqI^aM0-^*)pWU&1tb.Tw}GDqeE.+(!jEP8@b&IcxNU1QQz%1d1; aeOzyizTPc;
	q(88/ar*bN|S IU"]xqU`R)i%Jp-lu3<!7QjP@, 9xqE@*G{3ESw3x#1N1?,
	(r0&q(1LKm)hS@d89lfo+'=Y$#7"g<&v hNp|fgfb<eK="G5fxvZ3FyyWQNI9JL+C<g
Mail-Copies-To: nobody
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
Cancel-Lock: sha1:U2ErXkOvqygZSE4K2hL/AFthV3Q=
Original-Xref: shelby.stanford.edu gnu.emacs.gnus:80502
X-BeenThere: info-gnus-english@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Announcements and discussions for GNUS,
	the GNU Emacs Usenet newsreader \(in English\)"
	<info-gnus-english.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/info-gnus-english>,
	<mailto:info-gnus-english-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/info-gnus-english>
List-Post: <mailto:info-gnus-english@gnu.org>
List-Help: <mailto:info-gnus-english-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/info-gnus-english>,
	<mailto:info-gnus-english-request@gnu.org?subject=subscribe>
Original-Sender: info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org
Errors-To: info-gnus-english-bounces+gegu-info-gnus-english=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.gnus.user:10292
Archived-At: <http://permalink.gmane.org/gmane.emacs.gnus.user/10292>

On Sun, Feb 03 2008, Sebastian P. Luque wrote:

> On Sun, 03 Feb 2008 18:12:57 +0100,
> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>> On Sun, Feb 03 2008, Sebastian P. Luque wrote:
>>> I noticed that message-signature-file gets set to nil when composing
>>> messages, even though the signature is chosen correctly, based on
>>> gnus-posting-styles: [...]
>
>> So what is the problem?
>
> The problem is that if I want to change the signature, say through 'C-c
> C-w' (message-insert-signature), or gnus-personalities, then any
> reference to this variable doesn't do what's expected.

I see.  Does the following quite untested patch do the right thing?

--8<---------------cut here---------------start------------->8---
--- message.el	28 Jan 2008 09:02:57 -0000	7.239
+++ message.el	3 Feb 2008 18:49:59 -0000
@@ -3281,7 +3281,11 @@
 (defun message-insert-signature (&optional force)
   "Insert a signature.  See documentation for variable `message-signature'."
   (interactive (list 0))
-  (let* ((signature
+  (let* ((message-signature-file (or message-signature-file
+				     (default-value 'message-signature-file)))
+	 (message-signature (or message-signature
+				(default-value 'message-signature)))
+	 (signature
 	  (cond
 	   ((and (null message-signature)
 		 (eq force 0))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.