Re: tbl issues with 1.11.1

[Yuri Pankov <yuri.pankov@gmail.com>]

On Sat, May 14, 2011 at 06:12:28AM +0200, Ingo Schwarze wrote:
> Hi Kristaps and Joerg,
> 
> >>> Ingo, that's your change from January. Care to check the attached patch?
> >> Anyone?
> > Ingo?  I remember you checking these in... care to take another look?
> 
> Er, jaja, i was a bit swamped...
> 
> Unfortunately, Joergs patch is not right, i breaks the horizontal
> spacing in tables without vertical rulers almost completely, see
> for example captoinfo(1) and compare the groff and mandoc output.
> 
> Getting this right in both cases - with and without vertical rulers -
> requires rather large changes.  The logic, as far as i understand it
> so far, goes like this:
> 
>  - box produces "|"
>  - no spacing at this point
>  - first cell, width is max(lengths)
>  - one space
>  - vertical ruler, if none, another space
>  - another space, unless there was a double ruler (!!)
>  - second cell
>  - and so on.
> 
> That is vastly different from what we have now, both regarding the
> width calculations - which apparently must not include padding - and
> regarding the output itself.
> 
> The work-in-progress patch below comes closer.  However, it still
> has at least two deficiencies, so it is not ready for commit:
>  - There still is a bogus space after double rulers, see (!!).
>  - The handling of explicit spacing options got sweeped away
>    by the reorg i was forced to do.  Probably, i need to put
>    it back in at the right places.  It was in the calc routine
>    but probably belongs in the output routines themselves.
> 
> Just sending this such that you finally get some feedback.
> In case we need more discussion, we should probably move to tech@.

Sorry for bringing this up again, but I'm still seeing the same
behaviour in 1.11.6. Is there anything wrong with proposed patch?


Yuri
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv