Re: Portability of fts() functions

[Ingo Schwarze <schwarze@usta.de>]

Hi Paul,

Paul Onyschuk wrote on Sun, Aug 10, 2014 at 01:26:53AM +0200:
> On Sat, 9 Aug 2014 23:59:19 +0200 Ingo Schwarze wrote:

>> Oh you mean if mandoc is compiled on a 32bit glibc platform with 32bit
>> off_t but more than 2 billion files in one file system or files larger
>> than 2 GB inside a manual tree, mandoc will compile all right,
>> but i may crash at runtime due to the broken fts(3) implementation
>> contained in glibc?  Did i get that right?

> I think you got it right.
 
>> I'm not sure what i could do about that - both in the long term
>> and as a quick fix for this release.  What would you suggest?

> There isn't much you to do about for time now I guess.  Explanation in
> readme and  that "BUILD_TARGETS += db-build" won't compile on systems
> without fts(3) would do.

I've added a comment to the relevant place in the Makefile.

>> Indeed, that sounds bad.
>> 
>> I guess i won't change that for this release, though.  I worry that
>> if we are very unlucky, whatever guard i put in there might break
>> on another system that was already tested and may not be tested
>> again.
>> 
>> For the next release, i have to keep this in mind.
>> I might do some more cleanup related to configure, anyway.

> What about something like that before 'set -e':
> 
> echo "/* RUNNING ./CONFIGURE - SHOULD BE USED ONLY VIA MAKE, READ INSTALL */"
> 
> Maybe that would be enough? 

Sounds reasonable for now and certainly not dangerous; done.

Thanks,
  Ingo


Index: Makefile
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/Makefile,v
retrieving revision 1.434
diff -u -p -r1.434 Makefile
--- Makefile	8 Aug 2014 23:47:21 -0000	1.434
+++ Makefile	10 Aug 2014 02:42:13 -0000
@@ -52,9 +52,10 @@ INSTALL_MAN	 = $(INSTALL_DATA)
 
 # --- user settings related to database support ------------------------
 
-# If you want to build without database support, for example to avoid
-# the dependency on SQLite3, comment the following line.
-# However, you won't get apropos(1) and makewhatis(8) in that case.
+# Building apropos(1) and makewhatis(8) requires both SQLite3 and fts(3).
+# To avoid those dependencies, comment the following line.
+# Be careful: the fts(3) implementation in glibc is broken on 32bit
+# machines, see: https://sourceware.org/bugzilla/show_bug.cgi?id=15838
 #
 BUILD_TARGETS	+= db-build
 
Index: configure
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/configure,v
retrieving revision 1.7
diff -u -p -r1.7 configure
--- configure	8 Aug 2014 23:47:21 -0000	1.7
+++ configure	10 Aug 2014 02:42:13 -0000
@@ -14,6 +14,8 @@
 # ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
+echo "/* RUNNING ./CONFIGURE - SHOULD BE USED ONLY VIA MAKE, READ INSTALL */"
+
 set -e
 exec > config.h 2> config.log
 
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv