From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-02.scc.kit.edu (scc-mailout-kit-02.scc.kit.edu [129.13.231.82]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 45711a4f for ; Sat, 7 Nov 2015 09:26:15 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-02.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1Zv4RY-00023H-QS; Sat, 07 Nov 2015 15:26:14 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1Zv4RY-0000PL-Nj; Sat, 07 Nov 2015 15:26:12 +0100 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84) (envelope-from ) id 1Zv4RY-0005Kx-IQ; Sat, 07 Nov 2015 15:26:12 +0100 Received: from localhost (1031@localhost [local]); by localhost (OpenSMTPD) with ESMTPA id 8701c5ab; Sat, 7 Nov 2015 15:26:12 +0100 (CET) Date: Sat, 7 Nov 2015 15:26:12 +0100 From: Ingo Schwarze To: Peter Bray Cc: discuss@mdocml.bsd.lv Subject: Re: mdocml [CVS_2015_11_07] Code needs HAVE_ERR guards Message-ID: <20151107142612.GE10393@athene.usta.de> References: <563D6968.8020401@yahoo.com.au> <563D7AA2.40306@yahoo.com.au> X-Mailinglist: mdocml-discuss Reply-To: discuss@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563D7AA2.40306@yahoo.com.au> User-Agent: Mutt/1.5.23 (2014-03-12) Hi Peter, Peter Bray wrote on Sat, Nov 07, 2015 at 03:14:26PM +1100: > Regardless of the solution chosen, 'compat_err.c' should not be including > as we already know we don't have it, because of the larger cpp(1) > guards (#if HAVE_ERR) around the code. Besides, test-err.c should always try to #include , no #if there. I committed your patch (solution 1). Having "compat_*.h" only seems useful for cases where the file contains substantial amounts of code, more than one would like to put into config.h. Thanks, Ingo -- To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv