From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-01.scc.kit.edu (scc-mailout-kit-01.scc.kit.edu [129.13.231.81]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 64d81741 for ; Sat, 29 Jul 2017 09:28:29 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-01.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1dbSjD-0007Rh-Mn; Sat, 29 Jul 2017 16:28:28 +0200 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1dbSjD-00053r-9A; Sat, 29 Jul 2017 16:28:27 +0200 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84_2) (envelope-from ) id 1dbSjD-0003K9-4A; Sat, 29 Jul 2017 16:28:27 +0200 Received: from localhost (athene.usta.de [local]) by athene.usta.de (OpenSMTPD) with ESMTPA id 7548be12; Sat, 29 Jul 2017 16:28:27 +0200 (CEST) Date: Sat, 29 Jul 2017 16:28:27 +0200 From: Ingo Schwarze To: Yuri Pankov Cc: discuss@mandoc.bsd.lv Subject: Re: mandoc-1.14.2 released Message-ID: <20170729142827.GF24945@athene.usta.de> References: <20170728181244.GD58985@athene.usta.de> <69d1d7f2-ce86-62e1-7623-e1a4c05f6f4d@gmx.com> X-Mailinglist: mandoc-discuss Reply-To: discuss@mandoc.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69d1d7f2-ce86-62e1-7623-e1a4c05f6f4d@gmx.com> User-Agent: Mutt/1.8.0 (2017-02-23) Hi Yuri, Yuri Pankov Illumos wrote on Sat, Jul 29, 2017 at 04:35:37PM +0300: > I'm in the process of updating the mandoc version in our tree, Great. You are working fast. :-) > and have noticed that man pages bundled with the release are not > entirely '-Tlint -Wstyle' clean as reported by 1.14.2 version that > I've just built, a lot of noise about man.options.1 (which we don't > use though), Indeed, that one isn't really intended to be installed. The target audience are mandoc developers (and developers of other man(1) systems), just like for the *.3 pages, which are not installed by default either, in particular the internal ones like man.cgi.3, mandoc_headers.3, mandoc_html.3. The man.options.1 file is not a clean mdoc(7) page but uses some low-level roff(7) features that are not needed in normal manual pages. > and the ones below: > > mandoc: /home/yuri/mandoc-1.14.2/mandoc.1:99:20: STYLE: no blank before > trailing delimiter: Oo ...; > mandoc: /home/yuri/mandoc-1.14.2/mandoc_char.7:204:11: STYLE: no blank > before trailing delimiter: Sq \e&. > mandoc: /home/yuri/mandoc-1.14.2/mandoc_html.3:272:6: STYLE: no blank > before trailing delimiter: Cm s? > mandoc: /home/yuri/mandoc-1.14.2/mdoc.7:3076:8: STYLE: no blank before > trailing delimiter: Sq \e&. > mandoc: /home/yuri/mandoc-1.14.2/roff.7:1868:7: STYLE: trailing > delimiter: Ss \e, That is known, too. It is not easy to get style messages 100% free of false positives. That is even documented, see mandoc(1): style An input file uses dubious or discouraged style. This is not a complaint about the syntax, and probably neither formatting nor portability are in danger. While great care is taken to avoid false positives on the higher message levels, the style level tries to reduce the probability that issues go unnoticed, so it may occasionally issue bogus suggestions. Please use your good judgement to decide whether any particular style suggestion really justifies a change to the input file. If you cannot tolerate a small number of false positives in the build, consider using -Wwarning instead. It wouldn't really help to change the mandoc manuals themselves to not issue these five false positives. Probably, there are also a few false positives in the rest of your tree. Warning and error messages should almost always be fixed - or else reported to me as bogus when they cause false positives, such that i can fix them. But making the criteria for style messages even stricter such that they never cause false positives would degrade their usefulness by making them miss many real issues. Yours, Ingo -- To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv