From: "Pali Rohár" <pali.rohar@gmail.com> To: Ingo Schwarze <schwarze@usta.de> Cc: discuss@mandoc.bsd.lv Subject: Re: Undesirable space after parenthesis in HTML output Date: Fri, 23 Nov 2018 21:22:31 +0100 [thread overview] Message-ID: <20181123202231.jiaupzi6igqqww6v@pali> (raw) In-Reply-To: <20181123193009.GA7177@athene.usta.de> [-- Attachment #1: Type: text/plain, Size: 2169 bytes --] On Friday 23 November 2018 20:30:09 Ingo Schwarze wrote: > Hi Pali, > > Pali Rohar wrote on Thu, Nov 22, 2018 at 03:24:28PM +0100: > > > $ printf "%s\ntest test test test test %s\n" \ > > 'Name (\fItest@example.org\fR)' 'Name (\fItest@example.org\fR)' \ > > | mandoc -T html > > > > I got following output: > > > > <div class="manual-text">Name (<i>test@example.org</i>) test test test test test > > Name ( <i>test@example.org</i>)</div> > > <table class="foot"> > > > > First Name is correct, second Name not. > > Ah. Yes, i can reproduce that on -current. > > It wasn't even related to parentheses. I just spotted it on lot of places around email addresses generated by pod2man, therefore I thought it is related to parentheses around. > The bug simply caused output > of whitespace in the middle of words when there were font escape > sequences - though not always. Whether the bug hit depended on the > spacing mode before the word containing the font escape, which made > it a bit elusive. > > Fixed in the following commit. > > Thanks for reporting the bug, > Ingo Thanks for fix! > > Log Message: > ----------- > When a font escape appears in the middle of a string, > make sure it doesn't cause output of bogus whitespace. > Fixing a bug reported by Pali dot Rohar at gmail dot com. > > Modified Files: > -------------- > mandoc: > html.c > > Revision Data > ------------- > Index: html.c > =================================================================== > RCS file: /home/cvs/mandoc/mandoc/html.c,v > retrieving revision 1.242 > retrieving revision 1.243 > diff -Lhtml.c -Lhtml.c -u -p -r1.242 -r1.243 > --- html.c > +++ html.c > @@ -416,8 +416,11 @@ print_encode(struct html *h, const char > case ESCAPE_FONTBI: > case ESCAPE_FONTCW: > case ESCAPE_FONTROMAN: > - if (0 == norecurse) > + if (0 == norecurse) { > + h->flags |= HTML_NOSPACE; > print_metaf(h, esc); > + h->flags &= ~HTML_NOSPACE; > + } > continue; > case ESCAPE_SKIPCHAR: > h->flags |= HTML_SKIPCHAR; -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2018-11-23 20:22 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 20:03 Pali Rohár 2018-11-22 14:08 ` Ingo Schwarze 2018-11-22 14:24 ` Pali Rohár 2018-11-23 19:30 ` Ingo Schwarze 2018-11-23 20:22 ` Pali Rohár [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181123202231.jiaupzi6igqqww6v@pali \ --to=pali.rohar@gmail.com \ --cc=discuss@mandoc.bsd.lv \ --cc=schwarze@usta.de \ --subject='Re: Undesirable space after parenthesis in HTML output' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).