Re: .br vertical spacing in html output

[Ingo Schwarze <schwarze@usta.de>]

Hi Mark,

Mark Harris wrote on Sat, Dec 01, 2018 at 01:31:05PM -0800:

> With -Thtml, with or without -Ostyle=mandoc.css, a roff .br (line break)
> directive is producing a large vertical space between lines.  This is
> unexpected and does not occur with -Tascii/utf8.  Here is an example:
[...]
> .br
>   Beta

The first commit in the context of the HTML syntax audit already
reduced the spacing a bit, see below.  There is still a spurious
blank line, though, and more is also needed to prevent bad nesting
in other situations.

Yours,
  Ingo


Log Message:
-----------
Render .br as <br/>, not as an empty <div>.
The element <br/> was already employed for many other purposes,
so there is nothing wrong with using it.
Also, it is safer because <br/> is permitted in phrasing content,
whereas <div> is only allowed in flow content.

This is the first part of the HTML syntax audit which i wanted 
to do for a long time.  Reminded by a loosely related bug report 
from Mark Harris <mark dot hsj at gmail dot com>.

Examples of where this caused HTML nesting syntax errors:
* in man(7) code between .nf and .fi
* in mdoc(7) code between .Bd -unfilled and .Ed
* in mdoc(7) code between .Ql Xo and .Xc
* in mdoc(7) code between .Rs and .Re

Modified Files:
--------------
    mandoc:
        roff_html.c

Revision Data
-------------
Index: roff_html.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/roff_html.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -Lroff_html.c -Lroff_html.c -u -p -r1.12 -r1.13
--- roff_html.c
+++ roff_html.c
@@ -58,11 +58,7 @@ roff_html_pre(struct html *h, const stru
 static void
 roff_html_pre_br(ROFF_HTML_ARGS)
 {
-	struct tag	*t;
-
-	t = print_otag(h, TAG_DIV, "");
-	print_text(h, "\\~");  /* So the div isn't empty. */
-	print_tagq(h, t);
+	print_otag(h, TAG_BR, "");
 }
 
 static void
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv