help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: Mark Harris <mark.hsj@gmail.com>
Cc: discuss@mandoc.bsd.lv
Subject: Re: .br vertical spacing in html output
Date: Tue, 4 Dec 2018 04:38:27 +0100	[thread overview]
Message-ID: <20181204033827.GF92067@athene.usta.de> (raw)
In-Reply-To: <fd14efed-283d-3921-1ae9-f0725481725b@gmail.com>

Hi Mark,

Mark Harris wrote on Sat, Dec 01, 2018 at 01:31:05PM -0800:

> With -Thtml, with or without -Ostyle=mandoc.css, a roff .br (line break)
> directive is producing a large vertical space between lines.  This is
> unexpected and does not occur with -Tascii/utf8.  Here is an example:
> .br
>   Beta

After some cleanup that was required first, i fixed this now with the
commit appended below.


Log Message:
During validation, drop .br before a text line starting with a 
blank, rather than teaching each formatter individually to ignore
the .br in such situations.  That's simpler and also results in
better diagnostics.

Mark Harris <mark dot hsj at gmail dot com> reported 
that -T html got confused in particular.

Modified Files:

Revision Data
Index: roff_validate.c
RCS file: /home/cvs/mandoc/mandoc/roff_validate.c,v
retrieving revision 1.11
retrieving revision 1.12
diff -Lroff_validate.c -Lroff_validate.c -u -p -r1.11 -r1.12
--- roff_validate.c
+++ roff_validate.c
@@ -67,6 +67,14 @@ roff_valid_br(ROFF_VALID_ARGS)
 		mandoc_vmsg(MANDOCERR_ARG_SKIP, man->parse,
 		    n->line, n->pos, "br %s", n->child->string);
+	if (n->next != NULL && n->next->type == ROFFT_TEXT &&
+	    *n->next->string == ' ') {
+		mandoc_msg(MANDOCERR_PAR_SKIP, man->parse, n->line, n->pos,
+		    "br before text line with leading blank");
+		roff_node_delete(man, n);
+		return;
+	}
 	if ((np = n->prev) == NULL)
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv

      parent reply	other threads:[~2018-12-04  3:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-01 21:31 Mark Harris
2018-12-02 17:21 ` Ingo Schwarze
2018-12-03 16:30 ` Ingo Schwarze
2018-12-04  3:38 ` Ingo Schwarze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204033827.GF92067@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=discuss@mandoc.bsd.lv \
    --cc=mark.hsj@gmail.com \
    --subject='Re: .br vertical spacing in html output' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).