Re: Broken tables in HTML output

[Ingo Schwarze <schwarze@usta.de>]

Hi Pali,

Pali Rohar wrote on Mon, Dec 03, 2018 at 09:46:28PM +0100:

> Hi! I played with colors and seems that browsers do not inherit table
> border color to td border color.

Well, inheritance always works, but it can be overridden, and it
appears that some browsers override border-color on varying levels
of the table element hierarchy without overriding the default for
the levels above.

> And by default my chrome and firefox
> uses gray color for table (if not specified).
> 
> E.g. when you set "table { border-color: yellow; }" and border of
> "table" and "tr" elements are yellow, but "td" elements in black.

That doesn't match what my Firefox 62.0.2 does: it draws "table"
borders yellow but "tr" and "td" borders black.

[...]
> What do you think about this patch? In troff/tbl you does not specify
> color, but I think that HTML output should have consistent colors -- not
> different color for horizontal lines and different for vertical lines.
> Just because browsers have different defaults.

I think that is reasonable.  CSS is the place where styles are
supposed to be defined, so adding a few additional attributes is OK
when there are good reasons, as opposed to adding style= attributes
to the HTML code.

I think "browsers have inconsistent defaults and we want consistent
layout" is a good enough reasons to add a few CSS attributes, even
though "browsers have bugs" does not look like a good reason to
encumber the HTML code with spurious "style=" attributes.

So i committed the following patch.

Yours,
  Ingo


Log Message:
-----------
Make sure all borders in a table are drawn in the same color.
Required because browsers tend to have inconsistent defaults:
For example, Firefox 62.0.2 sets border-color for tbody, but not for table,
and Pali Rohar reports that Chrome set it for td, but not for tr or tbody.
The td part is from Pali Rohar, the tbody and tr parts from me.

Modified Files:
--------------
    mandoc:
        mandoc.css

Revision Data
-------------
Index: mandoc.css
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mandoc.css,v
retrieving revision 1.40
retrieving revision 1.41
diff -Lmandoc.css -Lmandoc.css -u -p -r1.40 -r1.41
--- mandoc.css
+++ mandoc.css
@@ -15,9 +15,14 @@ body {		font-family: Helvetica,Arial,san
 table {		margin-top: 0em;
 		margin-bottom: 0em;
 		border-collapse: collapse; }
+/* Some browsers set border-color in a browser style for tbody,
+ * but not for table, resulting in inconsistent border styling. */
+tbody {		border-color: inherit; }
+tr {		border-color: inherit; }
 td {		vertical-align: middle;
 		padding-left: 0.2em;
-		padding-right: 0.2em; }
+		padding-right: 0.2em;
+		border-color: inherit; }
 ul, ol, dl {	margin-top: 0em;
 		margin-bottom: 0em; }
 li, dt {	margin-top: 1em; }
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv