discuss@mandoc.bsd.lv
 help / color / Atom feed
* mandoc 1.14.5 white space nits
@ 2019-06-14 16:01 Michal Nowak
  2019-07-01 23:34 ` Ingo Schwarze
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Nowak @ 2019-06-14 16:01 UTC (permalink / raw)
  To: discuss

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

Hi,

I am just finishing mandoc update to 1.14.5 on illumos and while 
preparing the change-set for integration I run our `git pbchk` tool [1].

It found one misspelling, and couple of <space><tab> sequences and 
trailing spaces:

mandoc nits:

Man page format/spelling:
usr/src/man/man5/mandoc_roff.5: Line 2282 contains "idiosyncracy", a 
common misspelling of "idiosyncrasy"

white space nits:
usr/src/cmd/mandoc/tbl_term.c:166: space tab sequences
usr/src/cmd/mandoc/mansearch.c:194: has trailing spaces
usr/src/cmd/mandoc/mdoc_markdown.c:1293: has trailing spaces
usr/src/cmd/mandoc/dbm.c:236: has trailing spaces
usr/src/cmd/mandoc/dbm.c:318: has trailing spaces
usr/src/cmd/mandoc/man_term.c:313: space tab sequences
usr/src/cmd/mandoc/roff.c:782: space tab sequences
usr/src/cmd/mandoc/roff.c:1589: space tab sequences

The patch I applied is attached (the last portion does not apply to mandoc).

Let me know, if you apply it in some form.

Thanks,
Michal

[1] 
https://github.com/illumos/illumos-gate/tree/master/usr/src/tools/scripts

[-- Attachment #2: 0002-mandoc-nits.patch --]
[-- Type: text/x-patch, Size: 4794 bytes --]

From 4a61453d9811fa44872cfcf8b0a48b68af92fbf0 Mon Sep 17 00:00:00 2001
From: Michal Nowak <mnowak@startmail.com>
Date: Fri, 14 Jun 2019 16:31:46 +0200
Subject: [PATCH 2/2] mandoc nits

---
 usr/src/cmd/mandoc/dbm.c           | 4 ++--
 usr/src/cmd/mandoc/man_term.c      | 2 +-
 usr/src/cmd/mandoc/mansearch.c     | 2 +-
 usr/src/cmd/mandoc/mdoc_markdown.c | 2 +-
 usr/src/cmd/mandoc/roff.c          | 4 ++--
 usr/src/cmd/mandoc/tbl_term.c      | 2 +-
 usr/src/man/man5/mandoc_roff.5     | 2 +-
 usr/src/tools/scripts/webrev.sh    | 4 ++--
 8 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/usr/src/cmd/mandoc/dbm.c b/usr/src/cmd/mandoc/dbm.c
index f6b1259ef5..7637a036a5 100644
--- a/usr/src/cmd/mandoc/dbm.c
+++ b/usr/src/cmd/mandoc/dbm.c
@@ -233,7 +233,7 @@ static struct dbm_res
 page_bytitle(enum iter arg_iter, const struct dbm_match *arg_match)
 {
 	static const struct dbm_match	*match;
-	static const char		*cp;	
+	static const char		*cp;
 	static int32_t			 ip;
 	struct dbm_res			 res = {-1, 0};
 
@@ -315,7 +315,7 @@ page_byarch(const struct dbm_match *arg_match)
 	static const struct dbm_match	*match;
 	struct dbm_res			 res = {-1, 0};
 	static int32_t			 ip;
-	const char			*cp;	
+	const char			*cp;
 
 	/* Initialize for a new iteration. */
 
diff --git a/usr/src/cmd/mandoc/man_term.c b/usr/src/cmd/mandoc/man_term.c
index d867762dca..4bb3f9da28 100644
--- a/usr/src/cmd/mandoc/man_term.c
+++ b/usr/src/cmd/mandoc/man_term.c
@@ -310,7 +310,7 @@ pre_alternate(DECL_ARGS)
 		assert(nn->type == ROFFT_TEXT);
 		term_word(p, nn->string);
 		if (nn->flags & NODE_EOS)
-                	p->flags |= TERMP_SENTENCE;
+			p->flags |= TERMP_SENTENCE;
 		if (nn->next != NULL)
 			p->flags |= TERMP_NOSPACE;
 	}
diff --git a/usr/src/cmd/mandoc/mansearch.c b/usr/src/cmd/mandoc/mansearch.c
index 0c457f95d1..4e968332e3 100644
--- a/usr/src/cmd/mandoc/mansearch.c
+++ b/usr/src/cmd/mandoc/mansearch.c
@@ -191,7 +191,7 @@ mansearch(const struct mansearch *search,
 			    mpage->file, R_OK) == -1) {
 				warn("%s", mpage->file);
 				warnx("outdated mandoc.db contains "
-				    "bogus %s entry, run makewhatis %s", 
+				    "bogus %s entry, run makewhatis %s",
 				    page->file + 1, paths->paths[i]);
 				free(mpage->file);
 				free(rp);
diff --git a/usr/src/cmd/mandoc/mdoc_markdown.c b/usr/src/cmd/mandoc/mdoc_markdown.c
index e9a931218c..b73811b76b 100644
--- a/usr/src/cmd/mandoc/mdoc_markdown.c
+++ b/usr/src/cmd/mandoc/mdoc_markdown.c
@@ -1290,7 +1290,7 @@ md_post_It(struct roff_node *n)
 		while ((n = n->prev) != NULL && n->type != ROFFT_HEAD)
 			i++;
 
-		/* 
+		/*
 		 * If a width was specified for this column,
 		 * subtract what printed, and
 		 * add the same spacing as in mdoc_term.c.
diff --git a/usr/src/cmd/mandoc/roff.c b/usr/src/cmd/mandoc/roff.c
index 2b07352b90..e84295aac3 100644
--- a/usr/src/cmd/mandoc/roff.c
+++ b/usr/src/cmd/mandoc/roff.c
@@ -779,7 +779,7 @@ roff_reset(struct roff *r)
 void
 roff_free(struct roff *r)
 {
-	int	 	 i;
+	int		i;
 
 	roff_free1(r);
 	for (i = 0; i < r->mstacksz; i++)
@@ -1586,7 +1586,7 @@ char *
 roff_getarg(struct roff *r, char **cpp, int ln, int *pos)
 {
 	struct buf	 buf;
-	char	 	*cp, *start;
+	char		*cp, *start;
 	int		 newesc, pairs, quoted, white;
 
 	/* Quoting can only start with a new word. */
diff --git a/usr/src/cmd/mandoc/tbl_term.c b/usr/src/cmd/mandoc/tbl_term.c
index a197f8ef74..a411107bd1 100644
--- a/usr/src/cmd/mandoc/tbl_term.c
+++ b/usr/src/cmd/mandoc/tbl_term.c
@@ -163,7 +163,7 @@ term_tbl(struct termp *tp, const struct tbl_span *sp)
 	const struct tbl_cell	*cp, *cpn, *cpp, *cps;
 	const struct tbl_dat	*dp;
 	static size_t		 offset;
-	size_t		 	 save_offset;
+	size_t			 save_offset;
 	size_t			 coloff, tsz;
 	int			 hspans, ic, more;
 	int			 dvert, fc, horiz, lhori, rhori, uvert;
diff --git a/usr/src/man/man5/mandoc_roff.5 b/usr/src/man/man5/mandoc_roff.5
index 01cf99c666..0a9aa7cbd8 100644
--- a/usr/src/man/man5/mandoc_roff.5
+++ b/usr/src/man/man5/mandoc_roff.5
@@ -2279,7 +2279,7 @@ code.
 .Pp
 The special semantics of the
 .Cm nS
-number register is an idiosyncracy of
+number register is an idiosyncrasy of
 .Ox
 manuals and not supported by other
 .Xr mdoc 5
diff --git a/usr/src/tools/scripts/webrev.sh b/usr/src/tools/scripts/webrev.sh
index 2b91ea2548..39f709d444 100644
--- a/usr/src/tools/scripts/webrev.sh
+++ b/usr/src/tools/scripts/webrev.sh
@@ -873,7 +873,7 @@ html_quote()
 	$SED -e "s/&/\&amp;/g" -e "s/</\&lt;/g" -e "s/>/\&gt;/g" "$@" | expand
 }
 
-# 
+#
 # Trim a digest-style revision to a conventionally readable yet useful length
 #
 trim_digest()
@@ -2075,7 +2075,7 @@ function git_wxfile
 	    }
 	}
 	close(F);
-	 
+
 	for (sort keys %files) {
 	    if ($realfiles{$_} ne $_) {
 		print "$_ $realfiles{$_}\n$files{$_}\n\n";
-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: mandoc 1.14.5 white space nits
  2019-06-14 16:01 mandoc 1.14.5 white space nits Michal Nowak
@ 2019-07-01 23:34 ` Ingo Schwarze
  2019-07-02  8:18   ` Michal Nowak
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Schwarze @ 2019-07-01 23:34 UTC (permalink / raw)
  To: Michal Nowak; +Cc: discuss

Hi Michael,

Michal Nowak wrote on Fri, Jun 14, 2019 at 06:01:01PM +0200:

> I am just finishing mandoc update to 1.14.5 on illumos

Nice.  I also noted it on

  http://mandoc.bsd.lv/ports.html         and
  http://mandoc.bsd.lv/porthistory.html

> and while preparing the change-set for integration
> I run our `git pbchk` tool [1].
> 
> It found one misspelling, and couple of <space><tab> sequences and 
> trailing spaces:

Thanks for the report.

> Let me know, if you apply it in some form.

I applied it by hand (because whitespace patches are hard to read
and also because i slightly mistrust patches prepared with git).

Yours,
  Ingo


Log Message:
-----------
use the standard spelling of the word "idiosyncrasy";
suggested by Michal Nowak <mnowak at startmail dot com>

Modified Files:
--------------
    mandoc:
        roff.7

Revision Data
-------------
Index: roff.7
===================================================================
RCS file: /home/cvs/mandoc/mandoc/roff.7,v
retrieving revision 1.112
retrieving revision 1.113
diff -Lroff.7 -Lroff.7 -u -p -r1.112 -r1.113
--- roff.7
+++ roff.7
@@ -2278,7 +2278,7 @@ code.
 .Pp
 The special semantics of the
 .Cm nS
-number register is an idiosyncracy of
+number register is an idiosyncrasy of
 .Ox
 manuals and not supported by other
 .Xr mdoc 7


Log Message:
-----------
delete trailing whitespace and space-tab sequences; no code change;
patch from Michal Nowak <mnowak at startmail dot com>
who found these with git pbchk in the illumos tree

Modified Files:
--------------
    mandoc:
        configure
        dbm.c
        dbm_map.h
        lib.in
        man_term.c
        mansearch.c
        mdoc_markdown.c
        roff.c
        tbl_term.c
    mandoc/regress:
        regress.pl

Revision Data
-------------
Index: tbl_term.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/tbl_term.c,v
retrieving revision 1.71
retrieving revision 1.72
diff -Ltbl_term.c -Ltbl_term.c -u -p -r1.71 -r1.72
--- tbl_term.c
+++ tbl_term.c
@@ -164,7 +164,7 @@ term_tbl(struct termp *tp, const struct 
 	const struct tbl_cell	*cp, *cpn, *cpp, *cps;
 	const struct tbl_dat	*dp;
 	static size_t		 offset;
-	size_t		 	 save_offset;
+	size_t			 save_offset;
 	size_t			 coloff, tsz;
 	int			 hspans, ic, more;
 	int			 dvert, fc, horiz, lhori, rhori, uvert;
Index: mansearch.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mansearch.c,v
retrieving revision 1.81
retrieving revision 1.82
diff -Lmansearch.c -Lmansearch.c -u -p -r1.81 -r1.82
--- mansearch.c
+++ mansearch.c
@@ -191,7 +191,7 @@ mansearch(const struct mansearch *search
 			    mpage->file, R_OK) == -1) {
 				warn("%s", mpage->file);
 				warnx("outdated mandoc.db contains "
-				    "bogus %s entry, run makewhatis %s", 
+				    "bogus %s entry, run makewhatis %s",
 				    page->file + 1, paths->paths[i]);
 				free(mpage->file);
 				free(rp);
Index: lib.in
===================================================================
RCS file: /home/cvs/mandoc/mandoc/lib.in,v
retrieving revision 1.21
retrieving revision 1.22
diff -Llib.in -Llib.in -u -p -r1.21 -r1.22
--- lib.in
+++ lib.in
@@ -43,7 +43,7 @@ LINE("libcipher",	"FreeSec Crypt Library
 LINE("libcompat",	"Compatibility Library (libcompat, \\-lcompat)")
 LINE("libcrypt",	"Crypt Library (libcrypt, \\-lcrypt)")
 LINE("libcurses",	"Curses Library (libcurses, \\-lcurses)")
-LINE("libcuse", 	"Userland Character Device Library (libcuse, \\-lcuse)")
+LINE("libcuse",		"Userland Character Device Library (libcuse, \\-lcuse)")
 LINE("libdevattr",	"Device attribute and event library (libdevattr, \\-ldevattr)")
 LINE("libdevctl",	"Device Control Library (libdevctl, \\-ldevctl)")
 LINE("libdevinfo",	"Device and Resource Information Utility Library (libdevinfo, \\-ldevinfo)")
Index: dbm_map.h
===================================================================
RCS file: /home/cvs/mandoc/mandoc/dbm_map.h,v
retrieving revision 1.1
retrieving revision 1.2
diff -Ldbm_map.h -Ldbm_map.h -u -p -r1.1 -r1.2
--- dbm_map.h
+++ dbm_map.h
@@ -14,7 +14,7 @@
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  *
- * Private interface for low-level routines for the map-based version 
+ * Private interface for low-level routines for the map-based version
  * of the mandoc database, for read-only access.
  * To be used by dbm*.c only.
  */
Index: roff.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/roff.c,v
retrieving revision 1.365
retrieving revision 1.366
diff -Lroff.c -Lroff.c -u -p -r1.365 -r1.366
--- roff.c
+++ roff.c
@@ -783,7 +783,7 @@ roff_reset(struct roff *r)
 void
 roff_free(struct roff *r)
 {
-	int	 	 i;
+	int		 i;
 
 	roff_free1(r);
 	for (i = 0; i < r->mstacksz; i++)
@@ -1590,7 +1590,7 @@ char *
 roff_getarg(struct roff *r, char **cpp, int ln, int *pos)
 {
 	struct buf	 buf;
-	char	 	*cp, *start;
+	char		*cp, *start;
 	int		 newesc, pairs, quoted, white;
 
 	/* Quoting can only start with a new word. */
Index: man_term.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/man_term.c,v
retrieving revision 1.229
retrieving revision 1.230
diff -Lman_term.c -Lman_term.c -u -p -r1.229 -r1.230
--- man_term.c
+++ man_term.c
@@ -315,7 +315,7 @@ pre_alternate(DECL_ARGS)
 		assert(nn->type == ROFFT_TEXT);
 		term_word(p, nn->string);
 		if (nn->flags & NODE_EOS)
-                	p->flags |= TERMP_SENTENCE;
+			p->flags |= TERMP_SENTENCE;
 		if (nn->next != NULL)
 			p->flags |= TERMP_NOSPACE;
 	}
Index: dbm.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/dbm.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -Ldbm.c -Ldbm.c -u -p -r1.6 -r1.7
--- dbm.c
+++ dbm.c
@@ -233,7 +233,7 @@ static struct dbm_res
 page_bytitle(enum iter arg_iter, const struct dbm_match *arg_match)
 {
 	static const struct dbm_match	*match;
-	static const char		*cp;	
+	static const char		*cp;
 	static int32_t			 ip;
 	struct dbm_res			 res = {-1, 0};
 
@@ -315,7 +315,7 @@ page_byarch(const struct dbm_match *arg_
 	static const struct dbm_match	*match;
 	struct dbm_res			 res = {-1, 0};
 	static int32_t			 ip;
-	const char			*cp;	
+	const char			*cp;
 
 	/* Initialize for a new iteration. */
 
Index: mdoc_markdown.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mdoc_markdown.c,v
retrieving revision 1.30
retrieving revision 1.31
diff -Lmdoc_markdown.c -Lmdoc_markdown.c -u -p -r1.30 -r1.31
--- mdoc_markdown.c
+++ mdoc_markdown.c
@@ -1290,7 +1290,7 @@ md_post_It(struct roff_node *n)
 		while ((n = n->prev) != NULL && n->type != ROFFT_HEAD)
 			i++;
 
-		/* 
+		/*
 		 * If a width was specified for this column,
 		 * subtract what printed, and
 		 * add the same spacing as in mdoc_term.c.
Index: configure
===================================================================
RCS file: /home/cvs/mandoc/mandoc/configure,v
retrieving revision 1.70
retrieving revision 1.71
diff -Lconfigure -Lconfigure -u -p -r1.70 -r1.71
--- configure
+++ configure
@@ -529,7 +529,7 @@ fi
 	echo "extern	char	 *mkdtemp(char *);"
 
 if [ ${HAVE_PROGNAME} -eq 0 ]; then
-	echo "extern 	const char *getprogname(void);"
+	echo "extern	const char *getprogname(void);"
 	echo "extern	void	  setprogname(const char *);"
 fi
 
Index: regress.pl
===================================================================
RCS file: /home/cvs/mandoc/mandoc/regress/regress.pl,v
retrieving revision 1.10
retrieving revision 1.11
diff -Lregress/regress.pl -Lregress/regress.pl -u -p -r1.10 -r1.11
--- regress/regress.pl
+++ regress/regress.pl
@@ -424,7 +424,7 @@ if ($count_total == 1) {
 	print "\n";
 } else {
 	print "No tests were run.\n";
-} 
+}
 if ($targets{clean}) {
 	if ($count_rm) {
 		print "Deleted $count_rm test output files.\n";
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: mandoc 1.14.5 white space nits
  2019-07-01 23:34 ` Ingo Schwarze
@ 2019-07-02  8:18   ` Michal Nowak
  2019-07-02 12:19     ` Ingo Schwarze
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Nowak @ 2019-07-02  8:18 UTC (permalink / raw)
  To: Ingo Schwarze; +Cc: discuss

Hi.

On 07/02/19 01:34 AM, Ingo Schwarze wrote:
> Hi Michael,
> 
> Michal Nowak wrote on Fri, Jun 14, 2019 at 06:01:01PM +0200:
> 
>> I am just finishing mandoc update to 1.14.5 on illumos
> 
> Nice.  I also noted it on
> 
>    http://mandoc.bsd.lv/ports.html         and
>    http://mandoc.bsd.lv/porthistory.html

If you could just fix my name to "Michal Nowak" (sic). Thanks.

> 
>> and while preparing the change-set for integration
>> I run our `git pbchk` tool [1].
>>
>> It found one misspelling, and couple of <space><tab> sequences and
>> trailing spaces:
> 
> Thanks for the report.
> 
>> Let me know, if you apply it in some form.
> 
> I applied it by hand (because whitespace patches are hard to read
> and also because i slightly mistrust patches prepared with git).

Great, thanks for merging them. I wasn't sure if those nits are 
something you are interested for future reports.

Michal

> 
> Yours,
>    Ingo
> 
> 
> Log Message:
> -----------
> use the standard spelling of the word "idiosyncrasy";
> suggested by Michal Nowak <mnowak at startmail dot com>
> 
> Modified Files:
> --------------
>      mandoc:
>          roff.7
> 
> Revision Data
> -------------
> Index: roff.7
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/roff.7,v
> retrieving revision 1.112
> retrieving revision 1.113
> diff -Lroff.7 -Lroff.7 -u -p -r1.112 -r1.113
> --- roff.7
> +++ roff.7
> @@ -2278,7 +2278,7 @@ code.
>   .Pp
>   The special semantics of the
>   .Cm nS
> -number register is an idiosyncracy of
> +number register is an idiosyncrasy of
>   .Ox
>   manuals and not supported by other
>   .Xr mdoc 7
> 
> 
> Log Message:
> -----------
> delete trailing whitespace and space-tab sequences; no code change;
> patch from Michal Nowak <mnowak at startmail dot com>
> who found these with git pbchk in the illumos tree
> 
> Modified Files:
> --------------
>      mandoc:
>          configure
>          dbm.c
>          dbm_map.h
>          lib.in
>          man_term.c
>          mansearch.c
>          mdoc_markdown.c
>          roff.c
>          tbl_term.c
>      mandoc/regress:
>          regress.pl
> 
> Revision Data
> -------------
> Index: tbl_term.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/tbl_term.c,v
> retrieving revision 1.71
> retrieving revision 1.72
> diff -Ltbl_term.c -Ltbl_term.c -u -p -r1.71 -r1.72
> --- tbl_term.c
> +++ tbl_term.c
> @@ -164,7 +164,7 @@ term_tbl(struct termp *tp, const struct
>   	const struct tbl_cell	*cp, *cpn, *cpp, *cps;
>   	const struct tbl_dat	*dp;
>   	static size_t		 offset;
> -	size_t		 	 save_offset;
> +	size_t			 save_offset;
>   	size_t			 coloff, tsz;
>   	int			 hspans, ic, more;
>   	int			 dvert, fc, horiz, lhori, rhori, uvert;
> Index: mansearch.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/mansearch.c,v
> retrieving revision 1.81
> retrieving revision 1.82
> diff -Lmansearch.c -Lmansearch.c -u -p -r1.81 -r1.82
> --- mansearch.c
> +++ mansearch.c
> @@ -191,7 +191,7 @@ mansearch(const struct mansearch *search
>   			    mpage->file, R_OK) == -1) {
>   				warn("%s", mpage->file);
>   				warnx("outdated mandoc.db contains "
> -				    "bogus %s entry, run makewhatis %s",
> +				    "bogus %s entry, run makewhatis %s",
>   				    page->file + 1, paths->paths[i]);
>   				free(mpage->file);
>   				free(rp);
> Index: lib.in
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/lib.in,v
> retrieving revision 1.21
> retrieving revision 1.22
> diff -Llib.in -Llib.in -u -p -r1.21 -r1.22
> --- lib.in
> +++ lib.in
> @@ -43,7 +43,7 @@ LINE("libcipher",	"FreeSec Crypt Library
>   LINE("libcompat",	"Compatibility Library (libcompat, \\-lcompat)")
>   LINE("libcrypt",	"Crypt Library (libcrypt, \\-lcrypt)")
>   LINE("libcurses",	"Curses Library (libcurses, \\-lcurses)")
> -LINE("libcuse", 	"Userland Character Device Library (libcuse, \\-lcuse)")
> +LINE("libcuse",		"Userland Character Device Library (libcuse, \\-lcuse)")
>   LINE("libdevattr",	"Device attribute and event library (libdevattr, \\-ldevattr)")
>   LINE("libdevctl",	"Device Control Library (libdevctl, \\-ldevctl)")
>   LINE("libdevinfo",	"Device and Resource Information Utility Library (libdevinfo, \\-ldevinfo)")
> Index: dbm_map.h
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/dbm_map.h,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -Ldbm_map.h -Ldbm_map.h -u -p -r1.1 -r1.2
> --- dbm_map.h
> +++ dbm_map.h
> @@ -14,7 +14,7 @@
>    * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
>    * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>    *
> - * Private interface for low-level routines for the map-based version
> + * Private interface for low-level routines for the map-based version
>    * of the mandoc database, for read-only access.
>    * To be used by dbm*.c only.
>    */
> Index: roff.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/roff.c,v
> retrieving revision 1.365
> retrieving revision 1.366
> diff -Lroff.c -Lroff.c -u -p -r1.365 -r1.366
> --- roff.c
> +++ roff.c
> @@ -783,7 +783,7 @@ roff_reset(struct roff *r)
>   void
>   roff_free(struct roff *r)
>   {
> -	int	 	 i;
> +	int		 i;
>   
>   	roff_free1(r);
>   	for (i = 0; i < r->mstacksz; i++)
> @@ -1590,7 +1590,7 @@ char *
>   roff_getarg(struct roff *r, char **cpp, int ln, int *pos)
>   {
>   	struct buf	 buf;
> -	char	 	*cp, *start;
> +	char		*cp, *start;
>   	int		 newesc, pairs, quoted, white;
>   
>   	/* Quoting can only start with a new word. */
> Index: man_term.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/man_term.c,v
> retrieving revision 1.229
> retrieving revision 1.230
> diff -Lman_term.c -Lman_term.c -u -p -r1.229 -r1.230
> --- man_term.c
> +++ man_term.c
> @@ -315,7 +315,7 @@ pre_alternate(DECL_ARGS)
>   		assert(nn->type == ROFFT_TEXT);
>   		term_word(p, nn->string);
>   		if (nn->flags & NODE_EOS)
> -                	p->flags |= TERMP_SENTENCE;
> +			p->flags |= TERMP_SENTENCE;
>   		if (nn->next != NULL)
>   			p->flags |= TERMP_NOSPACE;
>   	}
> Index: dbm.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/dbm.c,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -Ldbm.c -Ldbm.c -u -p -r1.6 -r1.7
> --- dbm.c
> +++ dbm.c
> @@ -233,7 +233,7 @@ static struct dbm_res
>   page_bytitle(enum iter arg_iter, const struct dbm_match *arg_match)
>   {
>   	static const struct dbm_match	*match;
> -	static const char		*cp;	
> +	static const char		*cp;
>   	static int32_t			 ip;
>   	struct dbm_res			 res = {-1, 0};
>   
> @@ -315,7 +315,7 @@ page_byarch(const struct dbm_match *arg_
>   	static const struct dbm_match	*match;
>   	struct dbm_res			 res = {-1, 0};
>   	static int32_t			 ip;
> -	const char			*cp;	
> +	const char			*cp;
>   
>   	/* Initialize for a new iteration. */
>   
> Index: mdoc_markdown.c
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/mdoc_markdown.c,v
> retrieving revision 1.30
> retrieving revision 1.31
> diff -Lmdoc_markdown.c -Lmdoc_markdown.c -u -p -r1.30 -r1.31
> --- mdoc_markdown.c
> +++ mdoc_markdown.c
> @@ -1290,7 +1290,7 @@ md_post_It(struct roff_node *n)
>   		while ((n = n->prev) != NULL && n->type != ROFFT_HEAD)
>   			i++;
>   
> -		/*
> +		/*
>   		 * If a width was specified for this column,
>   		 * subtract what printed, and
>   		 * add the same spacing as in mdoc_term.c.
> Index: configure
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/configure,v
> retrieving revision 1.70
> retrieving revision 1.71
> diff -Lconfigure -Lconfigure -u -p -r1.70 -r1.71
> --- configure
> +++ configure
> @@ -529,7 +529,7 @@ fi
>   	echo "extern	char	 *mkdtemp(char *);"
>   
>   if [ ${HAVE_PROGNAME} -eq 0 ]; then
> -	echo "extern 	const char *getprogname(void);"
> +	echo "extern	const char *getprogname(void);"
>   	echo "extern	void	  setprogname(const char *);"
>   fi
>   
> Index: regress.pl
> ===================================================================
> RCS file: /home/cvs/mandoc/mandoc/regress/regress.pl,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -Lregress/regress.pl -Lregress/regress.pl -u -p -r1.10 -r1.11
> --- regress/regress.pl
> +++ regress/regress.pl
> @@ -424,7 +424,7 @@ if ($count_total == 1) {
>   	print "\n";
>   } else {
>   	print "No tests were run.\n";
> -}
> +}
>   if ($targets{clean}) {
>   	if ($count_rm) {
>   		print "Deleted $count_rm test output files.\n";
> 
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: mandoc 1.14.5 white space nits
  2019-07-02  8:18   ` Michal Nowak
@ 2019-07-02 12:19     ` Ingo Schwarze
  0 siblings, 0 replies; 4+ messages in thread
From: Ingo Schwarze @ 2019-07-02 12:19 UTC (permalink / raw)
  To: Michal Nowak; +Cc: discuss

Hi Michal,

Michal Nowak wrote on Tue, Jul 02, 2019 at 10:18:27AM +0200:
> On 07/02/19 01:34 AM, Ingo Schwarze wrote:

>> Nice.  I also noted it on
>> 
>>    http://mandoc.bsd.lv/ports.html         and
>>    http://mandoc.bsd.lv/porthistory.html

> If you could just fix my name to "Michal Nowak" (sic). Thanks.

Oops, sorry; that is corrected now.
Fortunately, i got your name right in the commit messages,
which would have been harder to fix.

> Great, thanks for merging them. I wasn't sure if those nits are 
> something you are interested for future reports.

Your are right, that differs among projects.

I wouldn't have been in mandoc five years ago because such glitches
were still quite numerous in the codebase back then and applying
such patches would have been very tedious.  Also, such patches would
not be useful for OpenBSD at large (outside mandoc or other specific
areas where maintainers care) because we normally fix minor glitches
only when working on the code anyway.

But nowadays, mandoc is mostly clean in this respect, and i'm still
actively working on the code quite regularly, so it makes sense to
keep it completely clean.

Yours,
  Ingo
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 16:01 mandoc 1.14.5 white space nits Michal Nowak
2019-07-01 23:34 ` Ingo Schwarze
2019-07-02  8:18   ` Michal Nowak
2019-07-02 12:19     ` Ingo Schwarze

discuss@mandoc.bsd.lv

Archives are clonable: git clone --mirror http://inbox.vuxu.org/mandoc-discuss

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.mandoc.discuss


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git