Re: [PATCH] Fix formatting in wg-quick(8)

[Ingo Schwarze <schwarze@usta.de>]

Hi Anthony,

Anthony J. Bentley wrote on Thu, Feb 13, 2020 at 09:00:19PM -0700:

> My attempt is below.

Thanks!

> - There were a few places like this where I wasn't sure if squeezing Ar
>   in there might be overkill:
> 
>     Upon bringing the interface up, this runs
>     .Ql resolvconf -a tun.INTERFACE -m 0 -x
>     and upon bringing it down, this runs
>     .Ql resolvconf -d tun.INTERFACE .

Right, these are somewhat ugly.  Long in-line code examples tend
to look ugly in general, but where they can't be avoided, .Ql is
the right macro to use.  This can hardly be improved without
rewording the text, which you rightly avoided during the conversion.

It is technically possible to use .Ar inside .Ql, but i'd say
it is better avoided.

> - Does the config file support statements across multiple lines (with
>   backslash or some such)? Then we could avoid the ugly wrapping in
>   wg-quick(8)'s EXAMPLES.
> 
> - Wasn't there discussion on the Groff list about moving to title case
>   instead of all caps in section headers? Is that something we want to
>   encourage in downstream manuals?

Not yet, maybe in the future.  Groff now supports the new way.
Support in mandoc is still pending.  Before advertising it widely,
we should make a decision for OpenBSD base.

> - Not sure of my use of Bro/Brc.

Usually, such braces are not needed, we almost never use them in
OpenBSD base.  Then again, you didn't want to change the wording
or the punctuation, and retaining them isn't wrong.  If you want
curlies here, then .Bro is the right macro.

> - The hanging indent in long tag list items seems problematic here.
>   Suggestions?

As any other details, that can be polished after commit.

Ultimately, i would probably recommend something like

  .It Ic set Ar interface Op Ar options
  Set configuration values for the specified
  .Ar interface .
  .Pp
  The options are as follows:
  .Bl -tag -width Ds
  .It Cm fwmark Ar fwmark
  The 32-bit [replace jargon word by an actual description]
  for outgoing packets, either as a decimal integer or as a
  hexadecimal integer starting with
  .Ql 0x .
  The default is 0 [which disables the feature; or even better, say
  more precisely what it means when this feature is "off"].
  The special value
  .Cm off
  is an alias for 0 [or even better, deprecate the duplication
  in the user interface and stop documenting it].
  .It Cm listen-port Ar port
  [A description is missing here what it means.]
  The default is 0, which causes a port to be chosen randomly when
  the interface comes up.
  .It [...]

and so one.  Usually, tagged lists are more readable than long
paragraphs of prose with keywords scattered in the middle.

Yes, i do think the page still needs some work after this initial
conversion, also regarding the content, but that is better done in
multiple steps, each patch focussed on one aspect, with careful
review of each patch.

Yours,
  Ingo
--
 To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv