From: Ingo Schwarze <schwarze@usta.de>
To: Stephen Gregoratto <dev@sgregoratto.me>
Cc: discuss@mandoc.bsd.lv
Subject: Re: Cannot compile on Arch Linux due to conflicing int types
Date: Fri, 3 Apr 2020 12:39:26 +0200 [thread overview]
Message-ID: <20200403103926.GA181@athene.usta.de> (raw)
In-Reply-To: <C1R8UFWVURJZ.1ZFF5RNAN6OCW@dextop.sgregoratto.me>
Hi Stephen,
Stephen Gregoratto wrote on Fri, Apr 03, 2020 at 02:14:37PM +1100:
> The ohash functions included in tag.c use the stdint.h types, but tag.c
> does not include them directly. This leads to compile errors like so:
thank you very much for the very useful report. It really helps
to find such glitches long before i call for release testing because
it reduces the strain on everyone having to re-test on all platforms
after last-minute fixes had to be rushed in for bugs found no earlier
than during release testing itself. So every bug found *before*
the start of release testing really improves the situation.
Indeed, you are right, <stdint.h> is required before <ohash.h>,
both the ohash_init(3) manual page and mandoc_headers(3) say so.
Fixed with the commit appended below.
Yours,
Ingo
Log Message:
-----------
#include <stdint.h> because that is needed before #include <ohash.h>;
fixing a build failure of mandoc-portable on Arch Linux
reported by Stephen Gregoratto <dev at sgregoratto dot me>.
Modified Files:
--------------
mandoc:
tag.c
Revision Data
-------------
Index: tag.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/tag.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -Ltag.c -Ltag.c -u -p -r1.31 -r1.32
--- tag.c
+++ tag.c
@@ -24,6 +24,7 @@
#include <assert.h>
#include <limits.h>
#include <stddef.h>
+#include <stdint.h>
#include <stdlib.h>
#include <string.h>
--
To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv
prev parent reply other threads:[~2020-04-03 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 3:14 Stephen Gregoratto
2020-04-03 10:39 ` Ingo Schwarze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403103926.GA181@athene.usta.de \
--to=schwarze@usta.de \
--cc=dev@sgregoratto.me \
--cc=discuss@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).