discuss@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Kristaps Dzonsons <kristaps@bsd.lv>
To: discuss@mdocml.bsd.lv
Cc: Yuri Pankov <yuri.pankov@gmail.com>
Subject: Re: uname() in mdoc_validate.c on Solaris
Date: Thu, 31 Mar 2011 12:23:21 +0200	[thread overview]
Message-ID: <4D945619.1060508@bsd.lv> (raw)
In-Reply-To: <20110331100458.GA1293@darklight.org.ru>

> uname(2) on Solaris (OpenSolaris, OpenIndiana, Solaris 11 Express)
> states:
>
> RETURN VALUES
>       Upon  successful  completion,  a   non-negative   value   is
>       returned.  Otherwise,  -1  is  returned  and errno is set to
>       indicate the error.
>
> Could we possibly change
>
>      if (uname(&utsname)) {
>
> to
>
>      if (uname(&utsname) == -1) {
>
> to make .Os without arguments work on these OSes?

Ingo,

This surprises me, as I usually do (-1 == syscall()).  And indeed, it 
seems this was lost in version 1.136 of mdoc_validate.c:

http://mdocml.bsd.lv/cgi-bin/cvsweb/mdoc_validate.c.diff?r1=1.135&r2=1.136&cvsroot=mdocml&f=h

Is there a technical reason for this (according to the CVS log, I was 
merging your changes)?  If not, I'll revert to the specific check for -1.

Yuri, thanks for the note!

Thanks,

Kristaps
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv

  reply	other threads:[~2011-03-31 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 10:04 Yuri Pankov
2011-03-31 10:23 ` Kristaps Dzonsons [this message]
2011-04-02 22:20   ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D945619.1060508@bsd.lv \
    --to=kristaps@bsd.lv \
    --cc=discuss@mdocml.bsd.lv \
    --cc=yuri.pankov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).